http/client: Throw error early if .path given and non AF_UNIX family

Author: daurnimator

http/client.lua

@@ -123,7 +123,19 @@ end
 
 local function connect(options, timeout)
 	local family = options.family
+	if family == nil then
+		family = cs.AF_UNSPEC
+	end
+
 	local path = options.path
+	if path then
+		if family == cs.AF_UNSPEC then
+			family = cs.AF_UNIX
+		elseif family ~= cs.AF_UNIX then
+			error("cannot use .path with non-unix address family")
+		end
+	end
+
 	local host = options.host
 	if not path and not http_util.is_ip(host) then
 		local dns_resolver = options.dns_resolver or cqueues_dns.getpool()

spec/client_spec.lua

@@ -15,6 +15,11 @@ describe("http.client module", function()
 	local openssl_pkey = require "openssl.pkey"
 	local openssl_ctx = require "openssl.ssl.context"
 	local openssl_x509 = require "openssl.x509"
+	it("throws error on invalid family+path combination", function()
+		assert.has.errors(function()
+			client.connect{family = cs.AF_INET, path = "/somepath"}
+		end)
+	end)
 	it("invalid network parameters return nil, err, errno", function()
 		-- Invalid network parameters will return nil, err, errno
 		local ok, err, errno = client.connect{host="127.0.0.1", port="invalid"}