Skip to content

Commit 092f6ed

Browse files
committed
spec/h1_connection_spec: Mark ECONNRESET tests as pending; they don't work on OSX
1 parent 39f5f7e commit 092f6ed

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

spec/h1_connection_spec.lua

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@ describe("low level http 1 connection operations", function()
5353
assert.same({nil}, {s:peername()})
5454
end
5555
end)
56-
it("persists errors (except ETIMEDOUT) until cleared", function()
56+
-- Pending as ECONNRESET behaviour is unportable
57+
pending("persists errors (except ETIMEDOUT) until cleared", function()
5758
local s, c = new_pair(1.1)
5859
assert.same(ce.ETIMEDOUT, select(3, s:read_request_line(0)))
59-
-- remote end closing with un-read data gives ECONNRESET (only on linux?)
6060
assert(s:write_status_line(1.0, "100", "continue", TEST_TIMEOUT))
6161
assert(s:flush(TEST_TIMEOUT))
6262
c:close()
@@ -342,7 +342,8 @@ describe("low level http 1 connection operations", function()
342342
s:close()
343343
c:close()
344344
end)
345-
it("handles connection reset", function()
345+
-- Pending as ECONNRESET behaviour is unportable
346+
pending("handles connection reset", function()
346347
local s, c = new_pair(1.1)
347348
assert(s:write_body_plain("something that flushes"))
348349
c:close()
@@ -395,7 +396,8 @@ describe("low level http 1 connection operations", function()
395396
s:close()
396397
c:close()
397398
end)
398-
it("connection reset", function()
399+
-- Pending as ECONNRESET behaviour is unportable
400+
pending("connection reset", function()
399401
local s, c = new_pair(1.1)
400402
assert(s:write_body_plain("something that flushes"))
401403
c:close()

0 commit comments

Comments
 (0)