NODEJS-647: Log negotiated SSL/TLS versions when using encrypted connections

Author: absurdfarce

lib/connection.js

@@ -188,7 +188,7 @@ class Connection extends events.EventEmitter {
       }
 
       this.netClient = tls.connect(this.port, this.address, sslOptions, function tlsConnectCallback() {
-        self.log('verbose', `Secure socket connected to ${self.endpointFriendlyName}`);
+        self.log('verbose', `Secure socket connected to ${self.endpointFriendlyName} with protocol ${self.netClient.getProtocol()}`);
         self.bindSocketListeners();
         self.startup(callback);
       });

lib/datastax/cloud/index.js

@@ -63,6 +63,8 @@ class CloudOptions {
     } else {
       this.serviceUrl = clientOptions.cloud.endpoint;
     }
+    // Include a log emitter to enable logging within the cloud connection logic
+    this.logEmitter = clientOptions.logEmitter;
 
     this.contactPoints = null;
     this.localDataCenter = null;
@@ -157,6 +159,8 @@ function getMetadataServiceInfo(cloudOptions, callback) {
   const req = https.get(requestOptions, res => {
     let data = '';
 
+    utils.log('verbose', `Connected to metadata service with SSL/TLS protocol ${res.socket.getProtocol()}`, {}, cloudOptions);
+
     res
       .on('data', chunk => data += chunk.toString())
       .on('end', () => {

lib/utils.js

@@ -126,12 +126,13 @@ function fixStack(stackTrace, error) {
  * @param {String} info
  * @param [furtherInfo]
  */
-function log(type, info, furtherInfo) {
+function log(type, info, furtherInfo, options) {
   if (!this.logEmitter) {
-    if (!this.options || !this.options.logEmitter) {
+    const effectiveOptions = options || this.options;
+    if (!effectiveOptions || !effectiveOptions.logEmitter) {
       throw new Error('Log emitter not defined');
     }
-    this.logEmitter = this.options.logEmitter;
+    this.logEmitter = effectiveOptions.logEmitter;
   }
   this.logEmitter('log', type, this.constructor.name, info, furtherInfo || '');
 }