Skip to content

Commit 3e946c4

Browse files
stuartquinstuartquin
committed
Update prrettier/eslint to double quotes
1 parent 00adb7d commit 3e946c4

File tree

5 files changed

+65
-67
lines changed

5 files changed

+65
-67
lines changed

‎.eslintrc.js‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
11
module.exports = {
22
extends: [
3-
'eslint:recommended',
4-
'plugin:@typescript-eslint/eslint-recommended',
5-
'plugin:@typescript-eslint/recommended',
6-
'plugin:prettier/recommended'
3+
"eslint:recommended",
4+
"plugin:@typescript-eslint/eslint-recommended",
5+
"plugin:@typescript-eslint/recommended",
6+
"plugin:prettier/recommended",
77
],
8-
parser: '@typescript-eslint/parser',
8+
parser: "@typescript-eslint/parser",
99
parserOptions: {
10-
project: 'tsconfig.eslint.json',
11-
sourceType: 'module'
10+
project: "tsconfig.eslint.json",
11+
sourceType: "module",
1212
},
13-
plugins: ['@typescript-eslint'],
13+
plugins: ["@typescript-eslint"],
1414
rules: {
15-
'@typescript-eslint/no-unused-vars': ['warn', { args: 'none' }],
16-
'@typescript-eslint/no-explicit-any': 'off',
17-
'@typescript-eslint/no-namespace': 'off',
18-
'@typescript-eslint/no-use-before-define': 'off',
19-
'@typescript-eslint/quotes': [
20-
'error',
21-
'single',
22-
{ avoidEscape: true, allowTemplateLiterals: false }
15+
"@typescript-eslint/no-unused-vars": ["warn", { args: "none" }],
16+
"@typescript-eslint/no-explicit-any": "off",
17+
"@typescript-eslint/no-namespace": "off",
18+
"@typescript-eslint/no-use-before-define": "off",
19+
"@typescript-eslint/quotes": [
20+
"error",
21+
"double",
22+
{ avoidEscape: true, allowTemplateLiterals: false },
2323
],
24-
curly: ['error', 'all'],
25-
eqeqeq: 'error',
26-
'prefer-arrow-callback': 'error'
27-
}
28-
};
24+
curly: ["error", "all"],
25+
eqeqeq: "error",
26+
"prefer-arrow-callback": "error",
27+
},
28+
};

‎.prettierrc‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
{
2-
"singleQuote": true
3-
}
2+
}

‎examples/introduction.ipynb‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,17 +50,16 @@
5050
},
5151
{
5252
"cell_type": "code",
53-
"execution_count": 7,
53+
"execution_count": 8,
5454
"metadata": {},
5555
"outputs": [
5656
{
5757
"data": {
5858
"text/plain": [
59-
"[{'start': 6, 'end': 16, 'text': 'March 2014', 'label': 'date'},\n",
60-
" {'start': 43, 'end': 55, 'text': 'Jonathan Ive', 'label': 'person'}]"
59+
"[{'start': 6, 'end': 16, 'text': 'March 2014', 'label': 'date'}]"
6160
]
6261
},
63-
"execution_count": 7,
62+
"execution_count": 8,
6463
"metadata": {},
6564
"output_type": "execute_result"
6665
}

‎src/annotate.ts‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -13,38 +13,38 @@ export function annotate(
1313
): HTMLElement {
1414
// TODO this is state
1515
let spans = initialSpans || [];
16-
console.log('SPANS', spans);
17-
let selectedLabel = labels.length ? labels[0] : '';
18-
19-
const wrapperEl = document.createElement('div');
20-
const labelContainerEl = document.createElement('div');
21-
labelContainerEl.classList.add('flex');
22-
labelContainerEl.classList.add('labelContainer');
23-
const contentEl = document.createElement('div');
24-
contentEl.classList.add('content');
16+
console.log("SPANS", spans);
17+
let selectedLabel = labels.length ? labels[0] : "";
18+
19+
const wrapperEl = document.createElement("div");
20+
const labelContainerEl = document.createElement("div");
21+
labelContainerEl.classList.add("flex");
22+
labelContainerEl.classList.add("labelContainer");
23+
const contentEl = document.createElement("div");
24+
contentEl.classList.add("content");
2525
contentEl.innerHTML = initialText;
2626

27-
wrapperEl.innerHTML = '';
27+
wrapperEl.innerHTML = "";
2828
wrapperEl.appendChild(labelContainerEl);
2929
wrapperEl.appendChild(contentEl);
3030

3131
function getSpanEl(text: string, span: Span) {
32-
const spanEl = document.createElement('span');
33-
spanEl.classList.add('span');
32+
const spanEl = document.createElement("span");
33+
spanEl.classList.add("span");
3434
const content = text.slice(span.start, span.end);
3535
spanEl.title = content;
3636

37-
const spanLabelEl = document.createElement('span');
38-
spanLabelEl.classList.add('spanLabel');
37+
const spanLabelEl = document.createElement("span");
38+
spanLabelEl.classList.add("spanLabel");
3939
spanLabelEl.innerHTML = span.label;
4040

41-
const spanContentEl = document.createElement('span');
41+
const spanContentEl = document.createElement("span");
4242
spanContentEl.innerHTML = content;
4343

4444
spanEl.appendChild(spanContentEl);
4545
spanEl.appendChild(spanLabelEl);
4646

47-
spanEl.addEventListener('click', () => {
47+
spanEl.addEventListener("click", () => {
4848
spans = spans.filter((s: Span) => s.start !== span.start);
4949
updateSpans();
5050
});
@@ -53,16 +53,16 @@ export function annotate(
5353
}
5454

5555
function renderLabels() {
56-
labelContainerEl.innerHTML = '';
56+
labelContainerEl.innerHTML = "";
5757

5858
labels.forEach((label) => {
59-
const labelEl = document.createElement('div');
60-
labelEl.classList.add('label');
59+
const labelEl = document.createElement("div");
60+
labelEl.classList.add("label");
6161
if (label === selectedLabel) {
62-
labelEl.classList.add('selected');
62+
labelEl.classList.add("selected");
6363
}
6464
labelEl.innerHTML = label;
65-
labelEl.addEventListener('click', () => {
65+
labelEl.addEventListener("click", () => {
6666
if (selectedLabel !== label) {
6767
selectedLabel = label;
6868
renderLabels();
@@ -72,7 +72,7 @@ export function annotate(
7272
});
7373
}
7474
function renderSpans() {
75-
contentEl.innerHTML = '';
75+
contentEl.innerHTML = "";
7676
contentEl.appendChild(getHighlightedText(initialText));
7777
}
7878

@@ -82,13 +82,13 @@ export function annotate(
8282
}
8383

8484
function getHighlightedText(text: string) {
85-
const textEl = document.createElement('div');
85+
const textEl = document.createElement("div");
8686
let prevOffset = 0;
8787

8888
spans
8989
.sort((a, b) => (a.start > b.start ? 1 : -1))
9090
.forEach((span) => {
91-
const prevEl = document.createElement('span');
91+
const prevEl = document.createElement("span");
9292
prevEl.dataset.offset = `${prevOffset}`;
9393
prevEl.innerHTML = text.slice(prevOffset, span.start);
9494
textEl.appendChild(prevEl);
@@ -97,7 +97,7 @@ export function annotate(
9797
prevOffset = span.end;
9898
});
9999

100-
const prevEl = document.createElement('span');
100+
const prevEl = document.createElement("span");
101101
prevEl.dataset.offset = `${prevOffset}`;
102102
prevEl.innerHTML = text.slice(prevOffset);
103103
textEl.appendChild(prevEl);
@@ -107,9 +107,9 @@ export function annotate(
107107

108108
function onSelect(event: any): void {
109109
const dataset = event.target?.dataset || {};
110-
const offset = parseInt(dataset.offset || '0', 10);
110+
const offset = parseInt(dataset.offset || "0", 10);
111111
const selected = window.getSelection();
112-
const selectedText = selected?.toString() || '';
112+
const selectedText = selected?.toString() || "";
113113
if (!selectedText.trim() || !selected) {
114114
return;
115115
}
@@ -124,7 +124,7 @@ export function annotate(
124124
updateSpans();
125125
}
126126

127-
contentEl.addEventListener('mouseup', onSelect);
127+
contentEl.addEventListener("mouseup", onSelect);
128128
renderLabels();
129129
renderSpans();
130130

‎src/widget.ts‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,40 +5,40 @@ import {
55
DOMWidgetModel,
66
DOMWidgetView,
77
ISerializers,
8-
} from '@jupyter-widgets/base';
8+
} from "@jupyter-widgets/base";
99

10-
import { MODULE_NAME, MODULE_VERSION } from './version';
11-
import { annotate, Span } from './annotate';
10+
import { MODULE_NAME, MODULE_VERSION } from "./version";
11+
import { annotate, Span } from "./annotate";
1212
// Import the CSS
13-
import '../css/widget.css';
13+
import "../css/widget.css";
1414

1515
export class ExampleModel extends DOMWidgetModel {
1616
static serializers: ISerializers = {
1717
...DOMWidgetModel.serializers,
1818
// Add any extra serializers here
1919
};
2020

21-
static model_name = 'ExampleModel';
21+
static model_name = "ExampleModel";
2222
static model_module = MODULE_NAME;
2323
static model_module_version = MODULE_VERSION;
24-
static view_name = 'ExampleView'; // Set to null if no view
24+
static view_name = "ExampleView"; // Set to null if no view
2525
static view_module = MODULE_NAME; // Set to null if no view
2626
static view_module_version = MODULE_VERSION;
2727
}
2828

2929
export class ExampleView extends DOMWidgetView {
30-
render() {
31-
const text = this.model.get('text');
32-
const labels = this.model.get('labels');
33-
const initialSpans = this.model.get('spans');
30+
render(): void {
31+
const text = this.model.get("text");
32+
const labels = this.model.get("labels");
33+
const initialSpans = this.model.get("spans");
3434

3535
this.el.appendChild(
3636
annotate(text, labels, initialSpans, (spans) => this.handleChange(spans))
3737
);
3838
}
3939

40-
handleChange(spans: Span[]) {
41-
this.model.set('spans', spans);
40+
handleChange(spans: Span[]): void {
41+
this.model.set("spans", spans);
4242
this.model.save_changes();
4343
}
4444
}

0 commit comments

Comments
 (0)