Standardize SQL syntax and variable naming

This commit updates SQL statements and variable names across multiple scripts for consistency and correctness. Changes include standardizing keyword casing, fixing typos, using proper SQL Server object references, and improving code readability in queries and examples.

Author: potatoqualitee

private/functions/New-DbaLogShippingPrimarySecondary.ps1

@@ -93,7 +93,7 @@ function New-DbaLogShippingPrimarySecondary {
         Stop-Function -Message "Database $SecondaryDatabase is not available on instance $SecondaryServer" -Target $SecondaryServer -Continue
     }
 
-    $Query = "SELECT primary_database FROM msdb.dbo.log_shipping_primary_databases WHERE primary_database = '$PrimaryDatabase'"
+    $Query = "SELECT primary_database FROM msdb.dbo.log_shipping_primary_databases WHERE primary_database = N'$PrimaryDatabase'"
 
     try {
         Write-Message -Message "Executing query:`n$Query" -Level Verbose
@@ -106,7 +106,7 @@ function New-DbaLogShippingPrimarySecondary {
     }
 
     # Set the query for the log shipping primary and secondary
-    $Query = "EXEC master.sys.sp_add_log_shipping_primary_secondary
+    $Query = "EXEC msdb.dbo.sp_add_log_shipping_primary_secondary
         @primary_database = N'$PrimaryDatabase'
         ,@secondary_server = N'$SecondaryServer'
         ,@secondary_database = N'$SecondaryDatabase' "

private/functions/Start-DbccCheck.ps1

@@ -20,7 +20,7 @@ function Start-DbccCheck {
                 Write-Verbose "Dbcc CheckTables finished successfully for $DbName on $servername"
             } else {
                 if ($MaxDop) {
-                    $null = $server.Query("DBCC CHECKDB ([$DbName]) WITH MAXDOP = $MaxDop")
+                    $null = $server.Query("DBCC CHECKDB ([$DbName]) WITH MaxDop = $MaxDop")
                     Write-Verbose "Dbcc CHECKDB finished successfully for $DbName on $servername"
                 } else {
                     $null = $server.Query("DBCC CHECKDB ([$DbName])")

private/functions/Update-SqlDbReadOnly.ps1

@@ -18,9 +18,9 @@ function Update-SqlDbReadOnly {
     )
 
     if ($readonly) {
-        $sql = "ALTER DATABASE [$DbName] SET READ_ONLY WITH NO_WAIT"
+        $sql = "ALTER DATABASE [$DbName] SET READONLY WITH (NO_WAIT)"
     } else {
-        $sql = "ALTER DATABASE [$DbName] SET READ_WRITE WITH NO_WAIT"
+        $sql = "ALTER DATABASE [$DbName] SET READWRITE WITH (NO_WAIT)"
     }
 
     try {

public/Backup-DbaDatabase.ps1

@@ -321,7 +321,7 @@ function Backup-DbaDatabase {
                 try {
                     # cl gave a bad example in dbatools in a month of lunches, accommodate it
                     Write-Message -Level Verbose -Message "Checking to see if FilePath is a directory"
-                    $isdir = ($server.Query("EXEC master.dbo.xp_fileexist '$FilePath'")).Item(1)
+                    $isdir = ($server.Query("EXEC sys.xp_fileexist '$FilePath'")).Item(1)
                 } catch {
                     # ignore
                 }
@@ -401,7 +401,7 @@ function Backup-DbaDatabase {
                 try {
                     # cl gave a bad example in dbatools in a month of lunches, accommodate it
                     Write-Message -Level Verbose -Message "Checking to see if FilePath is a directory"
-                    $isdir = ($db.Query("EXEC master.dbo.xp_fileexist '$FilePath'")).Item(1)
+                    $isdir = ($db.Query("EXEC sys.xp_fileexist '$FilePath'")).Item(1)
                 } catch {
                     # ignore
                 }

public/Clear-DbaLatchStatistics.ps1

@@ -81,7 +81,7 @@ function Clear-DbaLatchStatistics {
 
             if ($Pscmdlet.ShouldProcess($instance, "Performing CLEAR of sys.dm_os_latch_stats")) {
                 try {
-                    $server.Query("DBCC SQLPERF (N'sys.dm_os_latch_stats' , CLEAR);")
+                    $server.Query("DBCC SQLPERF (N'sys.dm_os_latch_stats', CLEAR);")
                     $status = "Success"
                 } catch {
                     $status = $_.Exception

public/Connect-DbaInstance.ps1

@@ -198,41 +198,41 @@ function Connect-DbaInstance {
 
     .EXAMPLE
         PS C:\> $server = Connect-DbaInstance -SqlInstance myserver.database.windows.net -Database mydb -SqlCredential me@mydomain.onmicrosoft.com -DisableException
-        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "select 1 as test"
+        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "SELECT 1 AS test"
 
         Logs into Azure SQL DB using AAD / Azure Active Directory, then performs a sample query.
 
     .EXAMPLE
         PS C:\> $server = Connect-DbaInstance -SqlInstance psdbatools.database.windows.net -Database dbatools -DisableException
-        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "select 1 as test"
+        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "SELECT 1 AS test"
 
         Logs into Azure SQL DB using AAD Integrated Auth, then performs a sample query.
 
     .EXAMPLE
         PS C:\> $server = Connect-DbaInstance -SqlInstance "myserver.public.cust123.database.windows.net,3342" -Database mydb -SqlCredential me@mydomain.onmicrosoft.com -DisableException
-        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "select 1 as test"
+        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "SELECT 1 AS test"
 
         Logs into Azure SQL Managed instance using AAD / Azure Active Directory, then performs a sample query.
 
     .EXAMPLE
         PS C:\> $server = Connect-DbaInstance -SqlInstance db.mycustomazure.com -Database mydb -AzureDomain mycustomazure.com -DisableException
-        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "select 1 as test"
+        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "SELECT 1 AS test"
 
         In the event your AzureSqlDb is not on a database.windows.net domain, you can set a custom domain using the AzureDomain parameter.
         This tells Connect-DbaInstance to login to the database using the method that works best with Azure.
 
     .EXAMPLE
         PS C:\> $connstring = "Data Source=TCP:mydb.database.windows.net,1433;User ID=sqladmin;Password=adfasdf;Connect Timeout=30;"
         PS C:\> $server = Connect-DbaInstance -ConnectionString $connstring
-        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "select 1 as test"
+        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "SELECT 1 AS test"
 
         Logs into Azure using a preconstructed connstring, then performs a sample query.
         ConnectionString is an alias of SqlInstance, so you can use -SqlInstance $connstring as well.
 
     .EXAMPLE
         PS C:\> $cred = Get-Credential guid-app-id-here # appid for username, clientsecret for password
         PS C:\> $server = Connect-DbaInstance -SqlInstance psdbatools.database.windows.net -Database abc -SqlCredential $cred -Tenant guidheremaybename
-        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "select 1 as test"
+        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "SELECT 1 AS test"
 
         When connecting from a non-Azure workstation, logs into Azure using Universal with MFA Support with a username and password, then performs a sample query.
 
@@ -256,7 +256,7 @@ function Connect-DbaInstance {
         PS C:\> $azureInstance = "YOURSERVER.database.windows.net"
         PS C:\> $azureDatabase = "MYDATABASE"
         PS C:\> $server = Connect-DbaInstance -SqlInstance $azureInstance -Database $azureDatabase -AccessToken $azureToken
-        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "select 1 as test"
+        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "SELECT 1 AS test"
 
         Connect to an Azure SQL Database or an Azure SQL Managed Instance with an AccessToken.
         Works with both Azure PowerShell v13 (string tokens) and v14+ (SecureString tokens).
@@ -268,7 +268,7 @@ function Connect-DbaInstance {
         PS C:\> $azureToken = (Get-AzAccessToken -ResourceUrl https://database.windows.net).Token
         PS C:\> $azureInstance = "YOUR-AZURE-SQL-MANAGED-INSTANCE.database.windows.net"
         PS C:\> $server = Connect-DbaInstance -SqlInstance $azureInstance -Database "YOURDATABASE" -AccessToken $azureToken
-        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "select 1 as test"
+        PS C:\> Invoke-DbaQuery -SqlInstance $server -Query "SELECT 1 AS test"
 
         Connect to an Azure SQL Managed Instance using Azure PowerShell v14+ where Get-AzAccessToken returns a SecureString.
         The function automatically detects and converts the SecureString token to the required format.

public/Copy-DbaAgentAlert.ps1

@@ -192,14 +192,14 @@ function Copy-DbaAgentAlert {
                     if ($PSCmdlet.ShouldProcess($destinstance, "Dropping alert $alertName and recreating")) {
                         try {
                             Write-Message -Message "Dropping Alert $alertName on $destServer." -Level Verbose
-                            $sql = "EXEC msdb.dbo.sp_delete_alert @name = N'$($alertname)';"
+                            $sql = "EXEC msdb.dbo.sp_delete_alert @name = N'$($alertName)';"
                             Write-Message -Message $sql -Level Debug
                             $null = $destServer.Query($sql)
                             $destAlerts.Refresh()
                         } catch {
                             $copyAgentAlertStatus.Status = "Failed"
                             $copyAgentAlertStatus | Select-DefaultView -Property DateTime, SourceServer, DestinationServer, Name, Type, Status, Notes -TypeName MigrationObject
-                            Write-Message -Level Verbose -Message "Issue dropping/recreating alert $alertname on $destInstance | $PSItem"
+                            Write-Message -Level Verbose -Message "Issue dropping/recreating alert $alertName on $destInstance | $PSItem"
                             continue
                         }
                     }
@@ -244,7 +244,7 @@ function Copy-DbaAgentAlert {
                     } catch {
                         $copyAgentAlertStatus.Status = "Failed"
                         $copyAgentAlertStatus | Select-DefaultView -Property DateTime, SourceServer, DestinationServer, Name, Type, Status, Notes -TypeName MigrationObject
-                        Write-Message -Level Verbose -Message "Issue creating alert $alertname on $destinstance | $PSItem"
+                        Write-Message -Level Verbose -Message "Issue creating alert $alertName on $destinstance | $PSItem"
                     }
                 }
 

public/Copy-DbaAgentJob.ps1

@@ -161,7 +161,7 @@ function Copy-DbaAgentJob {
                 $MaintenancePlanName = $sourceServer.Query($sql).MaintenancePlanName
 
                 if ($MaintenancePlanName) {
-                    if ($Pscmdlet.ShouldProcess($destinstance, "Job [$jobName] is associated with Maintenance Plan: $MaintenancePlanNam")) {
+                    if ($Pscmdlet.ShouldProcess($destinstance, "Job [$jobName] is associated with Maintenance Plan: $MaintenancePlanName")) {
                         $copyJobStatus.Status = "Skipped"
                         $copyJobStatus.Notes = "Job is associated with maintenance plan"
                         $copyJobStatus | Select-DefaultView -Property DateTime, SourceServer, DestinationServer, Name, Type, Status, Notes -TypeName MigrationObject

public/Copy-DbaAgentJobCategory.ps1

@@ -324,7 +324,7 @@ function Copy-DbaAgentJobCategory {
                                     Write-Message -Level Verbose -Message "Dropping Alert category $categoryName"
                                     $destServer.JobServer.AlertCategories[$categoryName].Drop()
                                     Write-Message -Level Verbose -Message "Copying Alert category $categoryName"
-                                    $sql = $alertcategory.Script() | Out-String
+                                    $sql = $alertCategory.Script() | Out-String
                                     Write-Message -Level Debug -Message "SQL Statement: $sql"
                                     $destServer.Query($sql)
                                 } catch {

public/Copy-DbaAgentProxy.ps1

@@ -167,7 +167,7 @@ function Copy-DbaAgentProxy {
                     $copyAgentProxyAccountStatus.Name = $proxyName
                     $copyAgentProxyAccountStatus.Type = "ProxyAccount"
 
-                    if ($force -eq $false) {
+                    if (-not $Force) {
                         if ($Pscmdlet.ShouldProcess($destinstance, "Server proxy account $proxyName exists at destination. Use -Force to drop and migrate.")) {
                             $copyAgentProxyAccountStatus.Status = "Skipped"
                             $copyAgentProxyAccountStatus.Notes = "Already exists on destination"