You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Standardize SQL syntax and improve query consistency
Updated SQL statements across multiple functions to use consistent casing for keywords (e.g., SELECT, AS, FROM, WHERE), standardized aliasing, and improved query formatting. These changes enhance code readability, maintainability, and reduce potential issues with SQL compatibility.
Copy file name to clipboardExpand all lines: private/functions/Get-DecryptedObject.ps1
+9-9Lines changed: 9 additions & 9 deletions
Original file line number
Diff line number
Diff line change
@@ -23,10 +23,10 @@ function Get-DecryptedObject {
23
23
# key_id 102 eq service master key, thumbprint 3 means encrypted with machinekey
24
24
Write-Message-Level Verbose -Message "Querying service master key"
25
25
try {
26
-
$sql="SELECT substring(crypt_property,9,len(crypt_property)-8) as smk FROM sys.key_encryptions WHERE key_id=102 and thumbprint=0x0300000001"
26
+
$sql="SELECT SUBSTRING(crypt_property,9,LEN(crypt_property)-8) AS smk FROM sys.key_encryptions WHERE key_id=102 AND thumbprint=0x0300000001"
27
27
$smkBytes=$server.Query($sql).smk
28
28
if (-not$smkBytes) {
29
-
$sql="SELECT substring(crypt_property,9,len(crypt_property)-8) as smk FROM sys.key_encryptions WHERE key_id=102 and thumbprint=0x03"
29
+
$sql="SELECT SUBSTRING(crypt_property,9,LEN(crypt_property)-8) AS smk FROM sys.key_encryptions WHERE key_id=102 AND thumbprint=0x03"
30
30
$smkBytes=$server.Query($sql).smk
31
31
}
32
32
} catch {
@@ -77,17 +77,17 @@ function Get-DecryptedObject {
77
77
"LinkedServer" {
78
78
"SELECT sysservers.srvname,
79
79
syslnklgns.name,
80
-
substring(syslnklgns.pwdhash,5,$ivlen) iv,
81
-
substring(syslnklgns.pwdhash,$($ivlen+5),
82
-
len(syslnklgns.pwdhash)-$($ivlen+4)) pass
80
+
SUBSTRING(syslnklgns.pwdhash,5,$ivlen) AS iv,
81
+
SUBSTRING(syslnklgns.pwdhash,$($ivlen+5),
82
+
LEN(syslnklgns.pwdhash)-$($ivlen+4)) AS pass
83
83
FROM master.sys.syslnklgns
84
-
inner join master.sys.sysservers
85
-
on syslnklgns.srvid=sysservers.srvid
86
-
WHERE len(pwdhash) > 0"
84
+
INNER JOIN master.sys.sysservers
85
+
ON syslnklgns.srvid=sysservers.srvid
86
+
WHERE LEN(pwdhash) > 0"
87
87
}
88
88
"Credential" {
89
89
#"SELECT name,QUOTENAME(name) quotename,credential_identity,substring(imageval,5,$ivlen) iv, substring(imageval,$($ivlen + 5),len(imageval)-$($ivlen + 4)) pass from sys.credentials cred inner join sys.sysobjvalues obj on cred.credential_id = obj.objid where valclass=28 and valnum=2"
90
-
"SELECT cred.name,QUOTENAME(cred.name) quotename,credential_identity,substring(imageval,5,$ivlen) iv, substring(imageval,$($ivlen+5),len(imageval)-$($ivlen+4)) pass,target_type as 'mappedClassType', cp.name as 'ProviderName' from sys.credentials cred inner join sys.sysobjvalues obj on cred.credential_id = obj.objid left outer join sys.cryptographic_providers cp on cred.target_id = cp.provider_id where valclass=28 and valnum=2"
90
+
"SELECT cred.name,QUOTENAME(cred.name) AS quotename,credential_identity,SUBSTRING(imageval,5,$ivlen) AS iv, SUBSTRING(imageval,$($ivlen+5),LEN(imageval)-$($ivlen+4)) AS pass,target_type AS 'mappedClassType', cp.name AS 'ProviderName' FROM sys.credentials cred INNER JOIN sys.sysobjvalues obj ON cred.credential_id = obj.objid LEFT OUTER JOIN sys.cryptographic_providers cp ON cred.target_id = cp.provider_id WHERE valclass=28 AND valnum=2"
Copy file name to clipboardExpand all lines: private/functions/Get-LoginPasswordHash.ps1
+3-3Lines changed: 3 additions & 3 deletions
Original file line number
Diff line number
Diff line change
@@ -47,15 +47,15 @@ function Get-LoginPasswordHash {
47
47
$sql=switch ($server.VersionMajor) {
48
48
8 {
49
49
# SQL Server 2000
50
-
"SELECT CONVERT(VARBINARY(256), password) as hashedpass FROM master.dbo.sysxlogins WHERE name = '$($Login.Name)'"
50
+
"SELECT CONVERT(VARBINARY(256), password) AS hashedpass FROM master.dbo.sysxlogins WHERE name = '$($Login.Name)'"
51
51
}
52
52
9 {
53
53
# SQL Server 2005
54
-
"SELECT CONVERT(VARBINARY(256), password_hash) as hashedpass FROM sys.sql_logins WHERE name = '$($Login.Name)'"
54
+
"SELECT CONVERT(VARBINARY(256), password_hash) AS hashedpass FROM sys.sql_logins WHERE name = '$($Login.Name)'"
55
55
}
56
56
default {
57
57
# SQL Server 2008 and above
58
-
"SELECT CAST(CONVERT(varchar(256), CAST(LOGINPROPERTY(name, 'PasswordHash') AS VARBINARY(256)), 1) AS NVARCHAR(max)) as hashedpass FROM sys.server_principals WHERE principal_id = $($Login.ID)"
58
+
"SELECT CAST(CONVERT(VARCHAR(256), CAST(LOGINPROPERTY(name, 'PasswordHash') AS VARBINARY(256)), 1) AS NVARCHAR(MAX)) AS hashedpass FROM sys.server_principals WHERE principal_id = $($Login.ID)"
Copy file name to clipboardExpand all lines: private/functions/Get-RestoreContinuableDatabase.ps1
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -23,7 +23,7 @@ function Get-RestoreContinuableDatabase {
23
23
return
24
24
}
25
25
if ($server.VersionMajor-ge9) {
26
-
$sql="select distinct db_name(database_id) as 'Database', differential_base_lsn, redo_start_lsn, redo_start_fork_guid as 'FirstRecoveryForkID' from master.sys.master_files where redo_start_lsn is not NULL"
26
+
$sql="SELECT DISTINCT DB_NAME(database_id) AS 'Database', differential_base_lsn, redo_start_lsn, redo_start_fork_guid AS 'FirstRecoveryForkID' FROM master.sys.master_files WHERE redo_start_lsn IS NOT NULL"
0 commit comments