Merge pull request #635 from datafold/fix-keyerror-for-no-differences-diff-json

dlawin · web-flow · commit e0ee7416ecfe · 2023-06-30T11:27:31.000-06:00
fix KeyError exception for --json diffs
diff --git a/data_diff/diff_tables.py b/data_diff/diff_tables.py
@@ -177,9 +177,7 @@ def get_stats_dict(self, is_dbt: bool = False):
             "total": sum(diff_stats.diff_by_sign.values()),
             "stats": self.stats,
         }
-        if diff_stats.extra_column_diffs:
-            json_output["values"] = diff_stats.extra_column_diffs
-
+        json_output["values"] = diff_stats.extra_column_diffs or {}
         return json_output
 
 
diff --git a/tests/test_api.py b/tests/test_api.py
@@ -66,7 +66,7 @@ def test_api_get_stats_dict(self):
             "updated": 0,
             "unchanged": 4,
             "total": 1,
-            # "stats": {"rows_downloaded": 5},
+            "values": {},
         }
         t1 = connect_to_table(TEST_MYSQL_CONN_STRING, self.table_src_name)
         t2 = connect_to_table(TEST_MYSQL_CONN_STRING, self.table_dst_name)

Original file line number	Diff line number	Diff line change
`@@ -177,9 +177,7 @@ def get_stats_dict(self, is_dbt: bool = False):`
`177`	`177`	`"total": sum(diff_stats.diff_by_sign.values()),`
`178`	`178`	`"stats": self.stats,`
`179`	`179`	`}`
`180`		`- if diff_stats.extra_column_diffs:`
`181`		`- json_output["values"] = diff_stats.extra_column_diffs`
`182`		`-`
	`180`	`+ json_output["values"] = diff_stats.extra_column_diffs or {}`
`183`	`181`	`return json_output`
`184`	`182`
`185`	`183`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ def test_api_get_stats_dict(self):`
`66`	`66`	`"updated": 0,`
`67`	`67`	`"unchanged": 4,`
`68`	`68`	`"total": 1,`
`69`		`- # "stats": {"rows_downloaded": 5},`
	`69`	`+ "values": {},`
`70`	`70`	`}`
`71`	`71`	`t1 = connect_to_table(TEST_MYSQL_CONN_STRING, self.table_src_name)`
`72`	`72`	`t2 = connect_to_table(TEST_MYSQL_CONN_STRING, self.table_dst_name)`