Fixes for oracle

Author: erezsh

data_diff/databases/oracle.py

@@ -4,6 +4,7 @@
 from .base import ThreadedDatabase, import_helper, ConnectError, QueryError
 from .base import DEFAULT_DATETIME_PRECISION, DEFAULT_NUMERIC_PRECISION
 
+SESSION_TIME_ZONE = None    # Changed by the tests
 
 @import_helper("oracle")
 def import_oracle():
@@ -34,7 +35,10 @@ def __init__(self, *, host, database, thread_count, **kw):
     def create_connection(self):
         self._oracle = import_oracle()
         try:
-            return self._oracle.connect(**self.kwargs)
+            c = self._oracle.connect(**self.kwargs)
+            if SESSION_TIME_ZONE:
+                c.cursor().execute(f"ALTER SESSION SET TIME_ZONE = '{SESSION_TIME_ZONE}'")
+            return c
         except Exception as e:
             raise ConnectError(*e.args) from e
 

tests/test_database_types.py

@@ -12,7 +12,7 @@
 from parameterized import parameterized
 
 from data_diff import databases as db
-import data_diff.databases.postgresql as postgresql
+from data_diff.databases import postgresql, oracle
 from data_diff.utils import number_to_human
 from data_diff.diff_tables import TableDiffer, TableSegment, DEFAULT_BISECTION_THRESHOLD
 from .common import CONN_STRINGS, N_SAMPLES, N_THREADS, BENCHMARK, GIT_REVISION, random_table_suffix
@@ -21,7 +21,7 @@
 CONNS = {k: db.connect_to_uri(v, N_THREADS) for k, v in CONN_STRINGS.items()}
 
 CONNS[db.MySQL].query("SET @@session.time_zone='+00:00'", None)
-postgresql.SESSION_TIME_ZONE = 'UTC'
+oracle.SESSION_TIME_ZONE = postgresql.SESSION_TIME_ZONE = 'UTC'
 
 
 class PaginatedTable: