add setting

Author: SkyFan2002

src/query/settings/src/settings_default.rs

@@ -408,6 +408,13 @@ impl DefaultSettings {
                     scope: SettingScope::Both,
                     range: Some(SettingRange::Numeric(0..=1)),
                 }),
+                ("enable_experimental_common_subexpression_elimination", DefaultSettingValue {
+                    value: UserSettingValue::UInt64(1),
+                    desc: "Enables experimental common subexpression elimination optimization.",
+                    mode: SettingMode::Both,
+                    scope: SettingScope::Both,
+                    range: Some(SettingRange::Numeric(0..=1)),
+                }),
                 ("enable_dio", DefaultSettingValue {
                     value: UserSettingValue::UInt64(1),
                     desc: "Enables Direct IO.",

src/query/settings/src/settings_getter_setter.rs

@@ -342,6 +342,10 @@ impl Settings {
         Ok(self.try_get_u64("enable_cbo")? != 0)
     }
 
+    pub fn get_enable_experimental_common_subexpression_elimination(&self) -> Result<bool> {
+        Ok(self.try_get_u64("enable_experimental_common_subexpression_elimination")? != 0)
+    }
+
     pub fn get_enable_dio(&self) -> Result<bool> {
         Ok(self.try_get_u64("enable_dio")? != 0)
     }

src/query/sql/src/planner/optimizer/optimizer.rs

@@ -263,7 +263,10 @@ pub async fn optimize_query(opt_ctx: Arc<OptimizerContext>, s_expr: SExpr) -> Re
             RuleID::SplitAggregate,
         ]))
         // 10. Apply CSE optimization to reduce redundant computations
-        .add(CommonSubexpressionOptimizer::new(opt_ctx.clone()))
+        .add_if(
+            opt_ctx.get_enable_experimental_common_subexpression_elimination(),
+            CommonSubexpressionOptimizer::new(opt_ctx.clone()),
+        )
         // 11. Apply DPhyp algorithm for cost-based join reordering
         .add(DPhpyOptimizer::new(opt_ctx.clone()))
         // 12. After join reorder, Convert some single join to inner join.

src/query/sql/src/planner/optimizer/optimizer_context.rs

@@ -36,6 +36,7 @@ pub struct OptimizerContext {
     enable_distributed_optimization: RwLock<bool>,
     enable_join_reorder: RwLock<bool>,
     enable_dphyp: RwLock<bool>,
+    enable_experimental_common_subexpression_elimination: RwLock<bool>,
     max_push_down_limit: RwLock<usize>,
     planning_agg_index: RwLock<bool>,
     #[educe(Debug(ignore))]
@@ -59,6 +60,7 @@ impl OptimizerContext {
             enable_distributed_optimization: RwLock::new(false),
             enable_join_reorder: RwLock::new(true),
             enable_dphyp: RwLock::new(true),
+            enable_experimental_common_subexpression_elimination: RwLock::new(true),
             max_push_down_limit: RwLock::new(10000),
             sample_executor: RwLock::new(None),
             planning_agg_index: RwLock::new(false),
@@ -70,6 +72,9 @@ impl OptimizerContext {
     pub fn with_settings(self: Arc<Self>, settings: &Settings) -> Result<Arc<Self>> {
         self.set_enable_join_reorder(unsafe { !settings.get_disable_join_reorder()? });
         *self.enable_dphyp.write() = settings.get_enable_dphyp()?;
+        *self
+            .enable_experimental_common_subexpression_elimination
+            .write() = settings.get_enable_experimental_common_subexpression_elimination()?;
         *self.max_push_down_limit.write() = settings.get_max_push_down_limit()?;
         *self.enable_trace.write() = settings.get_enable_optimizer_trace()?;
 
@@ -106,6 +111,12 @@ impl OptimizerContext {
         *self.enable_dphyp.read()
     }
 
+    pub fn get_enable_experimental_common_subexpression_elimination(&self) -> bool {
+        *self
+            .enable_experimental_common_subexpression_elimination
+            .read()
+    }
+
     pub fn set_sample_executor(
         self: &Arc<Self>,
         sample_executor: Option<Arc<dyn QueryExecutor>>,