File tree Expand file tree Collapse file tree 2 files changed +2
-0
lines changed
functions-v2/src/aggregates Expand file tree Collapse file tree 2 files changed +2
-0
lines changed Original file line number Diff line number Diff line change @@ -161,6 +161,7 @@ impl AggregateDistinctStringState {
161161 let data = unsafe { key. as_slice ( ) } ;
162162
163163 let holder = self . holders . last_mut ( ) . unwrap ( ) ;
164+ // TODO(sundy): may cause memory fragmentation, refactor this using arena
164165 if holder. may_resize ( data. len ( ) ) {
165166 let mut holder = StringColumnBuilder :: with_capacity (
166167 HOLDER_CAPACITY ,
Original file line number Diff line number Diff line change @@ -187,6 +187,7 @@ impl AggregateDistinctStringState {
187187 let data = unsafe { key. as_slice ( ) } ;
188188
189189 let holder = self . holders . last_mut ( ) . unwrap ( ) ;
190+ // TODO(sundy): may cause memory fragmentation, refactor this using arena
190191 if holder. may_resize ( data. len ( ) ) {
191192 let mut holder = MutableStringColumn :: with_values_capacity (
192193 HOLDER_BYTES_CAPACITY . max ( data. len ( ) ) ,
You can’t perform that action at this time.
0 commit comments