Added a new configuration key include-generated-columns (or environment variable DB_DUMP_INCLUDE_GENERATED_COLUMNS) to allow users to control whether generated columns should be included in database dumps.

Signed-off-by: chenen <itfunx@hotmail.com>

Author: n2em

pkg/core/dumpoptions.go

@@ -11,24 +11,24 @@ import (
 )
 
 type DumpOptions struct {
-	Targets             []storage.Storage
-	Safechars           bool
-	DBNames             []string
-	DBConn              *database.Connection
-	Compressor          compression.Compressor
-	Encryptor           encrypt.Encryptor
-	Exclude             []string
-	PreBackupScripts    string
-	PostBackupScripts   string
-	Compact             bool
-	Triggers            bool
-	Routines            bool
-	SuppressUseDatabase bool
-	SkipExtendedInsert  bool
+	Targets                 []storage.Storage
+	Safechars               bool
+	DBNames                 []string
+	DBConn                  *database.Connection
+	Compressor              compression.Compressor
+	Encryptor               encrypt.Encryptor
+	Exclude                 []string
+	PreBackupScripts        string
+	PostBackupScripts       string
+	Compact                 bool
+	Triggers                bool
+	Routines                bool
+	SuppressUseDatabase     bool
+	SkipExtendedInsert      bool
 	IncludeGeneratedColumns bool
-	MaxAllowedPacket    int
-	Run                 uuid.UUID
-	FilenamePattern     string
+	MaxAllowedPacket        int
+	Run                     uuid.UUID
+	FilenamePattern         string
 	// PostDumpDelay inafter each dump is complete, while holding connection open. Do not use outside of tests.
 	PostDumpDelay time.Duration
 	// Parallelism how many databases to back up at once, consuming that number of threads

pkg/database/mysql/dump.go

@@ -39,21 +39,21 @@ Data struct to configure dump behavior
 	LockTables:       Lock all tables for the duration of the dump
 */
 type Data struct {
-	Out                    io.Writer
-	Connection             *sql.DB
-	IgnoreTables           []string
-	MaxAllowedPacket       int
-	LockTables             bool
-	Schema                 string
-	Compact                bool
-	Triggers               bool
-	Routines               bool
-	Host                   string
-	SuppressUseDatabase    bool
-	SkipExtendedInsert     bool
-	Charset                string
-	Collation              string
-	PostDumpDelay          time.Duration
+	Out                     io.Writer
+	Connection              *sql.DB
+	IgnoreTables            []string
+	MaxAllowedPacket        int
+	LockTables              bool
+	Schema                  string
+	Compact                 bool
+	Triggers                bool
+	Routines                bool
+	Host                    string
+	SuppressUseDatabase     bool
+	SkipExtendedInsert      bool
+	Charset                 string
+	Collation               string
+	PostDumpDelay           time.Duration
 	IncludeGeneratedColumns bool
 
 	tx                 *sql.Tx