Merge pull request #448 from data-driven-forms/fix-pf4-radio-again

fix(pf4): fixed radio not being checked.

Author: rvsia

packages/pf4-component-mapper/src/files/radio.js

@@ -4,15 +4,13 @@ import { useFieldApi } from '@data-driven-forms/react-form-renderer';
 import { Radio as Pf4Radio } from '@patternfly/react-core';
 import FormGroup from '../common/form-group';
 
-const RadioOption = ({ name, option, isDisabled, isReadOnly, radioGroupValue }) => {
-  const {
-    input: { checked, ...input }
-  } = useFieldApi({ name, value: option.value });
+const RadioOption = ({ name, option, isDisabled, isReadOnly }) => {
+  const { input } = useFieldApi({ name, value: option.value });
   return (
     <Pf4Radio
       key={`${name}-${option.value}`}
       {...input}
-      isChecked={radioGroupValue === option.value}
+      isChecked={input.value === option.value}
       value={option.value}
       onChange={() => input.onChange(option.value)}
       label={option.label}
@@ -51,7 +49,7 @@ const Radio = ({ name, options, type, ...props }) => {
       id={id || input.name}
     >
       {options.map((option) => (
-        <RadioOption radioGroupValue={input.value} key={option.value} name={name} option={option} isReadOnly={isReadOnly} isDisabled={isDisabled} />
+        <RadioOption key={option.value} name={name} option={option} isReadOnly={isReadOnly} isDisabled={isDisabled} />
       ))}
     </FormGroup>
   );

packages/pf4-component-mapper/src/tests/__snapshots__/form-fields.test.js.snap

@@ -862,7 +862,6 @@ exports[`FormFields should render Radio correctly 1`] = `
                   "value": "1",
                 }
               }
-              radioGroupValue=""
             >
               <Radio
                 aria-label="One"
@@ -913,7 +912,6 @@ exports[`FormFields should render Radio correctly 1`] = `
                   "value": "2",
                 }
               }
-              radioGroupValue=""
             >
               <Radio
                 aria-label="Two"
@@ -964,7 +962,6 @@ exports[`FormFields should render Radio correctly 1`] = `
                   "value": "3",
                 }
               }
-              radioGroupValue=""
             >
               <Radio
                 aria-label="Three"
@@ -2388,7 +2385,6 @@ exports[`FormFields should render disabled Radio correctly 1`] = `
                   "value": "1",
                 }
               }
-              radioGroupValue=""
             >
               <Radio
                 aria-label="One"
@@ -2439,7 +2435,6 @@ exports[`FormFields should render disabled Radio correctly 1`] = `
                   "value": "2",
                 }
               }
-              radioGroupValue=""
             >
               <Radio
                 aria-label="Two"
@@ -2490,7 +2485,6 @@ exports[`FormFields should render disabled Radio correctly 1`] = `
                   "value": "3",
                 }
               }
-              radioGroupValue=""
             >
               <Radio
                 aria-label="Three"