Refactor pos/neg zero utils

Author: honno

array_api_tests/pytest_helpers.py

@@ -14,6 +14,8 @@
     "doesnt_raise",
     "nargs",
     "fmt_kw",
+    "is_pos_zero",
+    "is_neg_zero",
     "assert_dtype",
     "assert_kw_dtype",
     "assert_default_float",
@@ -69,6 +71,14 @@ def fmt_kw(kw: Dict[str, Any]) -> str:
     return ", ".join(f"{k}={v}" for k, v in kw.items())
 
 
+def is_pos_zero(n: float) -> bool:
+    return n == 0 and math.copysign(1, n) == 1
+
+
+def is_neg_zero(n: float) -> bool:
+    return n == 0 and math.copysign(1, n) == -1
+
+
 def assert_dtype(
     func_name: str,
     in_dtype: Union[DataType, Sequence[DataType]],

array_api_tests/test_operators_and_elementwise_functions.py

@@ -123,7 +123,10 @@ def default_filter(s: Scalar) -> bool:
 
     Used by default as these values are typically special-cased.
     """
-    return math.isfinite(s) and s is not -0.0 and s is not +0.0
+    if isinstance(s, int):  # note bools are ints
+        return True
+    else:
+        return math.isfinite(s) and s != 0
 
 
 T = TypeVar("T")
@@ -538,7 +541,7 @@ def test_abs(ctx, data):
         abs,  # type: ignore
         expr_template="abs({})={}",
         filter_=lambda s: (
-            s == float("infinity") or (math.isfinite(s) and s is not -0.0)
+            s == float("infinity") or (math.isfinite(s) and not ph.is_neg_zero(s))
         ),
     )