self-review

Author: crusaderky

array_api_strict/__init__.py

@@ -15,6 +15,7 @@
 consuming libraries to test their array API usage.
 
 """
+
 from types import ModuleType
 
 __all__ = []
@@ -123,7 +124,7 @@
     "bool",
 ]
 
-from ._elementwise_functions import (  # type: ignore[attr-defined]
+from ._elementwise_functions import (
     abs,
     acos,
     acosh,

array_api_strict/_array_object.py

@@ -47,6 +47,7 @@
 except ImportError:
     EllipsisType = type(Ellipsis)
 
+
 class Device:
     _device: str
     __slots__ = ("_device", "__weakref__")
@@ -91,6 +92,7 @@ class Array:
     functions, such as asarray().
 
     """
+
     _array: npt.NDArray[Any]
     _dtype: DType
     _device: Device

array_api_strict/_creation_functions.py

@@ -15,6 +15,7 @@
     # Circular import
     from ._array_object import Array, Device
 
+
 class _Default(Enum):
     DEFAULT = 0
 
@@ -140,7 +141,7 @@ def arange(
     _check_device(device)
 
     return Array._new(
-        np.arange(start, stop, step, dtype=_np_dtype(dtype)), 
+        np.arange(start, stop, step, dtype=_np_dtype(dtype)),
         device=device,
     )
 
@@ -201,7 +202,9 @@ def eye(
     _check_valid_dtype(dtype)
     _check_device(device)
 
-    return Array._new(np.eye(n_rows, M=n_cols, k=k, dtype=_np_dtype(dtype)), device=device)
+    return Array._new(
+        np.eye(n_rows, M=n_cols, k=k, dtype=_np_dtype(dtype)), device=device
+    )
 
 
 def from_dlpack(

array_api_strict/_data_type_functions.py

@@ -21,14 +21,14 @@
 from ._flags import get_array_api_strict_flags
 
 
-# _default is used to emulate the asarray(device) argument not existing in 2022.12
 # Note: astype is a function, not an array method as in NumPy.
 def astype(
     x: Array,
     dtype: DType,
     /,
     *,
     copy: bool = True,
+    # _default is used to emulate the device argument not existing in 2022.12
     device: Device | _Default | None = _default,
 ) -> Array:
     if device is not _default:
@@ -164,7 +164,7 @@ def isdtype(dtype: DType, kind: DType | str | tuple[DType | str, ...]) -> bool:
     for more details
     """
     if not isinstance(dtype, DType):
-       raise TypeError(f"'dtype' must be a dtype, not a {type(dtype)!r}")
+        raise TypeError(f"'dtype' must be a dtype, not a {type(dtype)!r}")
 
     if isinstance(kind, tuple):
         # Disallow nested tuples

array_api_strict/_dtypes.py

@@ -11,6 +11,7 @@
 
 py_bool = bool
 
+
 class DType:
     _np_dtype: np.dtype[Any]
     __slots__ = ("_np_dtype", "__weakref__")

array_api_strict/_flags.py

@@ -17,9 +17,9 @@
 import functools
 import os
 import warnings
-from collections.abc import Callable, Collection
+from collections.abc import Callable
 from types import TracebackType
-from typing import TYPE_CHECKING, Any, TypeVar
+from typing import TYPE_CHECKING, Any, Collection, TypeVar
 
 import array_api_strict
 
@@ -28,8 +28,7 @@
     from typing_extensions import ParamSpec
 
     P = ParamSpec("P")
-else:
-    P = object  # Sphinx hack
+
 T = TypeVar("T")
 
 

array_api_strict/_helpers.py

@@ -1,5 +1,5 @@
-"""Private helper routines.
-"""
+"""Private helper routines."""
+
 from __future__ import annotations
 
 from ._array_object import Array
@@ -11,11 +11,10 @@
 
 def _maybe_normalize_py_scalars(
     x1: Array | complex,
-    x2: Array | complex, 
+    x2: Array | complex,
     dtype_category: str,
     func_name: str,
 ) -> tuple[Array, Array]:
-
     flags = get_array_api_strict_flags()
     if flags["api_version"] < "2024.12":
         # scalars will fail at the call site

array_api_strict/_linalg.py

@@ -320,12 +320,8 @@ def slogdet(x: Array, /) -> SlogdetResult:
 def _solve(a: np.ndarray, b: np.ndarray) -> np.ndarray:
     try:
         from numpy.linalg._linalg import (  # type: ignore[attr-defined]
-            _assert_stacked_2d,
-            _assert_stacked_square,
-            _commonType,
-            _makearray,
-            _raise_linalgerror_singular,
-            isComplexType,
+        _makearray, _assert_stacked_2d, _assert_stacked_square,
+        _commonType, isComplexType, _raise_linalgerror_singular
         )
     except ImportError:
         from numpy.linalg.linalg import (  # type: ignore[attr-defined]
@@ -412,7 +408,8 @@ def trace(x: Array, /, *, offset: int = 0, dtype: DType | None = None) -> Array:
 
     # Note: trace always operates on the last two axes, whereas np.trace
     # operates on the first two axes by default
-    return Array._new(np.asarray(np.trace(x._array, offset=offset, axis1=-2, axis2=-1, dtype=np_dtype)), device=x.device)
+    res = np.trace(x._array, offset=offset, axis1=-2, axis2=-1, dtype=np_dtype)
+    return Array._new(np.asarray(res), device=x.device)
 
 # Note: the name here is different from norm(). The array API norm is split
 # into matrix_norm and vector_norm().

array_api_strict/_typing.py

@@ -35,7 +35,11 @@ def __dlpack__(self, /, *, stream: None = ...) -> PyCapsule: ...
 
 Capabilities = TypedDict(
     "Capabilities",
-    {"boolean indexing": bool, "data-dependent shapes": bool, "max dimensions": int},
+    {
+        "boolean indexing": bool,
+        "data-dependent shapes": bool,
+        "max dimensions": int,
+    },
 )
 
 DefaultDataTypes = TypedDict(

array_api_strict/tests/test_validation.py

@@ -1,11 +1,9 @@
-from typing import Callable
-
 import pytest
 
 import array_api_strict as xp
 
 
-def p(func: Callable, *args, **kwargs):
+def p(func, *args, **kwargs):
     f_sig = ", ".join(
         [str(a) for a in args] + [f"{k}={v}" for k, v in kwargs.items()]
     )