Fix ruff errors

Ensure nan propagation is still handled correctly for CuPy sign().

Author: asmeurer

array_api_compat/common/_aliases.py

@@ -532,14 +532,17 @@ def unstack(x: ndarray, /, xp, *, axis: int = 0) -> Tuple[ndarray, ...]:
 
 # numpy 1.26 does not use the standard definition for sign on complex numbers
 
-def sign(x: array, /, xp, **kwargs) -> array:
+def sign(x: ndarray, /, xp, **kwargs) -> ndarray:
     if isdtype(x.dtype, 'complex floating', xp=xp):
         out = (x/xp.abs(x, **kwargs))[...]
         # sign(0) = 0 but the above formula would give nan
         out[x == 0+0j] = 0+0j
-        return out[()]
     else:
-        return xp.sign(x, **kwargs)
+        out = xp.sign(x, **kwargs)
+    # CuPy sign() does not propagate nans. See
+    # https://github.com/data-apis/array-api-compat/issues/136
+    out[xp.isnan(x)] = xp.nan
+    return out[()]
 
 __all__ = ['arange', 'empty', 'empty_like', 'eye', 'full', 'full_like',
            'linspace', 'ones', 'ones_like', 'zeros', 'zeros_like',

array_api_compat/cupy/_aliases.py

@@ -110,13 +110,6 @@ def asarray(
 
         return cp.array(obj, dtype=dtype, **kwargs)
 
-def sign(x: ndarray, /) -> ndarray:
-    # CuPy sign() does not propagate nans. See
-    # https://github.com/data-apis/array-api-compat/issues/136
-    out = cp.sign(x)
-    out[cp.isnan(x)] = cp.nan
-    return out
-
 # These functions are completely new here. If the library already has them
 # (i.e., numpy 2.0), use the library version instead of our wrapper.
 if hasattr(cp, 'vecdot'):