fixes and reverts

Author: crusaderky

.github/workflows/array-api-tests-dask.yml

@@ -10,7 +10,9 @@ jobs:
       package-version: '>= 2024.9.0'
       module-name: dask.array
       extra-requires: numpy
-      # Dask is quite slower then other libraries on unit tests
-      # Reduce the number of examples to speed up CI, even though
-      # this can cause flakiness.
-      pytest-extra-args: --max-examples=50
+      # Dask is substantially slower then other libraries on unit tests.
+      # Reduce the number of examples to speed up CI, even though this means that this
+      # workflow is barely more than a smoke test, and one should expect extreme 
+      # flakiness. Before changes to dask-xfails.txt or dask-skips.txt, please run
+      # the full test suite with at least 200 examples.
+      pytest-extra-args: --max-examples=5

dask-skips.txt

@@ -1,3 +1,7 @@
+# NOTE: dask tests run on a very small number of examples in CI due to
+# slowness. This causes very high flakiness in the tests.
+# Before changing this file, please run with at least 200 examples.
+
 # Passes, but extremely slow
 array_api_tests/test_linalg.py::test_outer
 

dask-xfails.txt

@@ -1,3 +1,7 @@
+# NOTE: dask tests run on a very small number of examples in CI due to
+# slowness. This causes very high flakiness in the tests.
+# Before changing this file, please run with at least 200 examples.
+
 # Shape mismatch; needs high priority investigation
 array_api_tests/test_array_object.py::test_setitem
 array_api_tests/test_indexing_functions.py::test_take
@@ -35,7 +39,7 @@ array_api_tests/test_set_functions.py::test_unique_values
 # fails for ndim > 2
 array_api_tests/test_linalg.py::test_svdvals
 
-# dtype mismatch got uint64, but should be uint8, NPY_PROMOTION_STATE=weak doesn't help :(
+# dtype mismatch got uint64, but should be uint8; NPY_PROMOTION_STATE=weak doesn't help
 array_api_tests/test_linalg.py::test_tensordot
 
 # AssertionError: out.dtype=uint64, but should be uint8 [tensordot(uint8, uint8)]
@@ -105,13 +109,16 @@ array_api_tests/test_array_object.py::test_getitem_arrays_and_ints_1[None]
 array_api_tests/test_array_object.py::test_getitem_arrays_and_ints_2[1]
 array_api_tests/test_array_object.py::test_getitem_arrays_and_ints_2[None]
 array_api_tests/test_has_names.py::test_has_names[indexing-take_along_axis]
+array_api_tests/test_signatures.py::test_func_signature[count_nonzero]
 array_api_tests/test_signatures.py::test_func_signature[take_along_axis]
+
 array_api_tests/test_linalg.py::test_cholesky
 array_api_tests/test_linalg.py::test_linalg_matmul
 array_api_tests/test_linalg.py::test_matmul
 array_api_tests/test_linalg.py::test_matrix_norm
 array_api_tests/test_linalg.py::test_qr
-array_api_tests/test_signatures.py::test_func_signature[count_nonzero]
+array_api_tests/test_manipulation_functions.py::test_roll
+
 array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is +infinity and isfinite(x2_i) and x2_i > 0) -> +infinity]
 array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is +infinity and isfinite(x2_i) and x2_i < 0) -> -infinity]
 array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is -infinity and isfinite(x2_i) and x2_i > 0) -> -infinity]