feat(chart): delete allowlistsynchronizer in pre-delete hook #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Helm value operator.gke.autopilot.enabled is true, deploy the Dash0 AllowlistSynchronizer so the Dash0 WorkloadAllowlist resources will be installed into the cluster. The resource is annotated as a Helm hook (pre-install,pre-upgrade) to make sure the WorkloadAllowlist are rolled out before the rest of the Helm chart, that is, before the operator manager deployment (since that workload already needs the exemption to be in place). Additionally, lift the following feature set restrictions in GKE Autopilot mode: - allow node affinities on GKE Autopilot - enable host metrics receiver on GKE Autopilot
This was an attempt to get automatic deletion of the allowlistsynchronizer to work without requesting a new WorkloadAllowlist first, by cramming it into the pre-delete hook. Unfortunately, this is not an option -- the associated WorkloadAllowlists will be deleted immediately, while some Dash0 operator workloads are still present in the cluster, which produces "interesting" errors and ultimately an inconsistent state. Instead, we have to go the proper route, update the set of WorkloadAllowlists, add one for a new post-delete job there, wait for it to be reviewed and merged, and then roll out a new version of the operator that includes this additional cleanup hook. This commit/branch is mostly to keep the work for deleting the AllowlistSynchronizer, with the expectation that we move it to a new hook and untangle it from the existing pre-delete hook code. The business with the separate Goroutine and wait group can probably be removed again then. [skip ci]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PR, #571 needs to be merged first.
Also, this is very much WIP and not in any shape to be merged as-is.