Skip to content

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 24, 2025

Summary

  • add constraint-based revolute joint for closed-loop hinges and expose in dartpy
  • document the new constraint and add integration/python coverage for hinge loops
  • loosen hinge closure tolerances to stabilize cross-platform CI

Testing

  • CI Linux
  • CI Windows
  • CI macOS
  • CI gz-physics
  • Publish dartpy

Closes #465

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 68.37945% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.39%. Comparing base (9b39285) to head (39b7a7d).

Files with missing lines Patch % Lines
dart/constraint/RevoluteJointConstraint.cpp 68.37% 80 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
+ Coverage   61.06%   61.39%   +0.33%     
==========================================
  Files         353      354       +1     
  Lines       32144    32397     +253     
  Branches     4182     4223      +41     
==========================================
+ Hits        19628    19890     +262     
+ Misses      12516    12507       -9     
Flag Coverage Δ
unittests 61.39% <68.37%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dart/constraint/RevoluteJointConstraint.cpp 68.37% <68.37%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 added this to the DART 7.0 milestone Nov 24, 2025
@jslee02 jslee02 force-pushed the issue/465_closed_kinematic_changes branch from d8c485a to c1edbf5 Compare November 24, 2025 19:47
@jslee02
Copy link
Member Author

jslee02 commented Nov 24, 2025

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 59 to 60
COMPONENT headers
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve legacy Dantzig include install path

The CMake install rules no longer install the Dantzig LCP headers under the legacy include/dart/math/lcp/Dantzig path (the compatibility block was removed, leaving only the lowercase dantzig install). Downstream projects that still include headers via the old capitalized path will now fail to build once they upgrade to a package built from this commit, even though the change is unrelated to the new revolute constraint. Was the backward-compatibility removal intentional?

Useful? React with 👍 / 👎.

jslee02 and others added 3 commits November 24, 2025 15:41
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jslee02 jslee02 merged commit bf3bb25 into main Nov 24, 2025
0 of 16 checks passed
@jslee02 jslee02 deleted the issue/465_closed_kinematic_changes branch November 24, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for closed kinematic chains in hinge joints

2 participants