-
Notifications
You must be signed in to change notification settings - Fork 290
Add revolute joint constraint for closed-loop hinges #2252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2252 +/- ##
==========================================
+ Coverage 61.06% 61.39% +0.33%
==========================================
Files 353 354 +1
Lines 32144 32397 +253
Branches 4182 4223 +41
==========================================
+ Hits 19628 19890 +262
+ Misses 12516 12507 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
d8c485a to
c1edbf5
Compare
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| COMPONENT headers | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preserve legacy Dantzig include install path
The CMake install rules no longer install the Dantzig LCP headers under the legacy include/dart/math/lcp/Dantzig path (the compatibility block was removed, leaving only the lowercase dantzig install). Downstream projects that still include headers via the old capitalized path will now fail to build once they upgrade to a package built from this commit, even though the change is unrelated to the new revolute constraint. Was the backward-compatibility removal intentional?
Useful? React with 👍 / 👎.
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Summary
Testing
Closes #465