Apply dart_flutter_team_lints set
#2712
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the packages in this repo conformant with the recommended set of lints for packages maintained by the Dart and Flutter teams. This is done in preparation for migrating these packages into the Dart SDK.
parlough
reviewed
Nov 10, 2025
| # - avoid-double-slash-imports | ||
| - avoid-duplicate-exports | ||
| # - avoid-dynamic | ||
| # - avoid-Object? |
Member
There was a problem hiding this comment.
Suggested change
| # - avoid-Object? | |
| # - avoid-dynamic |
Comment on lines
18
to
41
| - always_declare_return_types | ||
| - avoid_classes_with_only_static_members | ||
| - avoid_returning_this | ||
| - avoid_unused_constructor_parameters | ||
| - avoid_void_async | ||
| - cancel_subscriptions | ||
| - directives_ordering | ||
| - join_return_with_assignment | ||
| - library_names | ||
| - literal_only_boolean_expressions | ||
| - omit_local_variable_types | ||
| - only_throw_errors | ||
| - package_prefixed_library_names | ||
| - prefer_final_in_for_each | ||
| - prefer_final_locals | ||
| - prefer_single_quotes | ||
| # - prefer_relative_imports | ||
| - prefer_void_to_null | ||
| - test_types_in_equals | ||
| - throw_in_finally | ||
| - unawaited_futures | ||
| - unnecessary_lambdas | ||
| - unnecessary_parenthesis | ||
| - unnecessary_statements |
Member
There was a problem hiding this comment.
Consider removing the lints already in dart_flutter_team_lints:
Suggested change
| - avoid_classes_with_only_static_members | |
| - avoid_returning_this | |
| - avoid_unused_constructor_parameters | |
| - avoid_void_async | |
| - cancel_subscriptions | |
| - join_return_with_assignment | |
| - library_names | |
| - literal_only_boolean_expressions | |
| - package_prefixed_library_names | |
| - prefer_final_in_for_each | |
| - prefer_final_locals | |
| - prefer_void_to_null |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the packages in this repo conformant with the recommended set of lints for packages maintained by the Dart and Flutter teams. This is done in preparation for migrating these packages into the Dart SDK.
This change also removes all usages of
dynamic, replacing them withObject?.