Don't show non-instantiated variables (#2061)

Author: elliette

dwds/lib/src/debugging/dart_scope.dart

@@ -67,6 +67,8 @@ Future<List<Property>> visibleProperties({
     if (value == null) return true;
 
     final type = value.type;
+    if (type == 'undefined') return true;
+
     final description = value.description ?? '';
     final name = property.name ?? '';
 

dwds/test/instances/patterns_inspection_test.dart

@@ -157,6 +157,31 @@ Future<void> _runTests({
           }
         });
       });
+
+      test('before instantiation of pattern-matching variables', () async {
+        await onBreakPoint('testPattern2Case1', (event) async {
+          final frame = event.topFrame!;
+
+          expect(
+            await getFrameVariables(frame),
+            {'dog': matchPrimitiveInstance(kind: 'String', value: 'Prismo')},
+          );
+        });
+      });
+
+      test('after instantiation of pattern-matching variables', () async {
+        await onBreakPoint('testPattern2Case2', (event) async {
+          final frame = event.topFrame!;
+
+          expect(await getFrameVariables(frame), {
+            'dog': matchPrimitiveInstance(kind: 'String', value: 'Prismo'),
+            'cats': matchListInstance(type: 'List<String>'),
+            'firstCat':
+                matchPrimitiveInstance(kind: 'String', value: 'Garfield'),
+            'secondCat': matchPrimitiveInstance(kind: 'String', value: 'Tom'),
+          });
+        });
+      });
     }, // TODO(annagrin): Remove when dart 3.0 is stable.
     skip: semver.Version.parse(Platform.version.split(' ')[0]) <
         semver.Version.parse('3.0.0-351.0.dev'),

fixtures/_experimentSound/web/main.dart

@@ -19,6 +19,7 @@ void main() {
     testPattern(['a', 1]);
     testPattern([3.14, 'b']);
     testPattern([0, 1]);
+    testPattern2();
   });
 
   document.body!.appendText('Program is running!');
@@ -64,3 +65,11 @@ String testPattern(Object obj) {
       return 'default'; // Breakpoint: testPatternDefault
   }
 }
+
+String testPattern2() {
+  final dog = 'Prismo'; 
+  final cats = ['Garfield', 'Tom']; // Breakpoint: testPattern2Case1
+  final [firstCat, secondCat] = cats;
+  print(firstCat); // Breakpoint: testPattern2Case2
+  return '$dog, $firstCat, $secondCat';
+}