Adds an IDE query parameter to the Dart DevTools URL (#1522)

Author: elliette

dwds/CHANGELOG.md

@@ -5,6 +5,7 @@
 - Temporarily disable the paused in debugger overlay.
 - Add `SdkConfiguration` and `SdkConfigurationProvider` classes to allow
   for lazily created SDK configurations.
+- Add an `ide` query parameter to the Dart DevTools URL for analytics.
 
 **Breaking changes:**
 - `Dwds.start` and `ExpressionCompilerService` now take 

dwds/lib/src/handlers/dev_handler.dart

@@ -375,8 +375,10 @@ class DevHandler {
 
     appServices.connectedInstanceId = appConnection.request.instanceId;
     dwdsStats.devToolsStart = DateTime.now();
-    await _launchDevTools(appServices.chromeProxyService.remoteDebugger,
-        _constructDevToolsUri(appServices.debugService.uri));
+    await _launchDevTools(
+        appServices.chromeProxyService.remoteDebugger,
+        _constructDevToolsUri(appServices.debugService.uri,
+            ideQueryParam: 'Dwds'));
   }
 
   Future<AppConnection> _handleConnectRequest(
@@ -523,16 +525,24 @@ class DevHandler {
         extensionDebugConnections.add(DebugConnection(appServices));
         _servicesByAppId[appId] = appServices;
       }
-      final devToolsUri = _constructDevToolsUri(
-          await _servicesByAppId[appId].debugService.encodedUri);
+      final encodedUri = await _servicesByAppId[appId].debugService.encodedUri;
       dwdsStats.devToolsStart = DateTime.now();
 
-      // If we only want the URI, then return early.
+      // If we only want the URI, this means we are embedding Dart DevTools in
+      // Chrome DevTools. Therefore return early.
       if (devToolsRequest.uriOnly != null && devToolsRequest.uriOnly) {
+        final devToolsUri = _constructDevToolsUri(
+          encodedUri,
+          ideQueryParam: 'ChromeDevTools',
+        );
         extensionDebugger.sendEvent('dwds.devtoolsUri', devToolsUri);
         return;
       }
 
+      final devToolsUri = _constructDevToolsUri(
+        encodedUri,
+        ideQueryParam: 'DebugExtension',
+      );
       await _launchDevTools(extensionDebugger, devToolsUri);
     });
   }
@@ -549,12 +559,18 @@ class DevHandler {
     });
   }
 
-  String _constructDevToolsUri(String debugServiceUri) {
+  String _constructDevToolsUri(
+    String debugServiceUri, {
+    String ideQueryParam = '',
+  }) {
     return Uri(
         scheme: 'http',
         host: _devTools.hostname,
         port: _devTools.port,
-        queryParameters: {'uri': debugServiceUri}).toString();
+        queryParameters: {
+          'uri': debugServiceUri,
+          if (ideQueryParam.isNotEmpty) 'ide': ideQueryParam,
+        }).toString();
   }
 }
 

dwds/test/debug_extension_test.dart

@@ -78,6 +78,8 @@ void main() async {
           // TODO(grouma): switch back to `fixture.webdriver.title` when
           // https://github.com/flutter/devtools/issues/2045 is fixed.
           expect(await context.webDriver.pageSource, contains('Flutter'));
+          expect(await context.webDriver.currentUrl,
+              contains('ide=DebugExtension'));
         });
 
         test('can close DevTools and relaunch', () async {

dwds/test/devtools_test.dart

@@ -47,6 +47,7 @@ void main() {
       // TODO(grouma): switch back to `fixture.webdriver.title` when
       // https://github.com/flutter/devtools/issues/2045 is fixed.
       expect(await context.webDriver.pageSource, contains('Flutter'));
+      expect(await context.webDriver.currentUrl, contains('ide=Dwds'));
     });
 
     test(