Remove unnecessary awaits (#1982)

* Validate only needed summaries in expression_compiler_service

* Remove unnecessary asyncs and awaits

Author: Anna Gringauze

dwds/CHANGELOG.md

@@ -11,6 +11,7 @@
   - Display records as a container of fields.
 - Remove test-only code from `sdk_configuration.dart`.
 - Move shared test-only code to a new `test_common` package.
+- Convert unnecessary async code to sync.
 
 **Breaking changes**
 

dwds/debug_extension/tool/update_dev_files.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'dart:async';
 import 'dart:io';
 
 void main() async {

dwds/debug_extension_mv3/tool/build_extension.dart

@@ -12,7 +12,6 @@
 //    - For prod: dart run tool/build_extension.dart prod
 //    - For MV3: dart run tool/build_extension.dart --mv3
 
-import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 

dwds/debug_extension_mv3/tool/update_dev_files.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'dart:async';
 import 'dart:io';
 
 void main() async {

dwds/debug_extension_mv3/web/background.dart

@@ -5,8 +5,6 @@
 @JS()
 library background;
 
-import 'dart:async';
-
 import 'package:dwds/data/debug_info.dart';
 import 'package:js/js.dart';
 

dwds/lib/shared/batched_stream.dart

@@ -39,7 +39,7 @@ class BatchedStreamController<T> {
   Stream<List<T>> get stream => _outputController.stream;
 
   /// Close the controller.
-  Future<dynamic> close() async {
+  Future<dynamic> close() {
     safeUnawaited(_inputController.close());
     return _completer.future.then((value) => _outputController.close());
   }

dwds/lib/src/debugging/classes.dart

@@ -1,6 +1,6 @@
 // Copyright (c) 2019, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.import 'dart:async';
+// BSD-style license that can be found in the LICENSE file.
 
 import 'package:dwds/src/debugging/metadata/class.dart';
 import 'package:dwds/src/loaders/strategy.dart';
@@ -191,7 +191,7 @@ class ClassHelper extends Domain {
     });
     final fieldRefs = <FieldRef>[];
     final fieldDescriptors = classDescriptor['fields'] as Map<String, dynamic>;
-    fieldDescriptors.forEach((name, descriptor) async {
+    fieldDescriptors.forEach((name, descriptor) {
       final classMetaData = ClassMetaData(
           jsName: descriptor['classRefName'],
           libraryId: descriptor['classRefLibraryId'],
@@ -214,7 +214,7 @@ class ClassHelper extends Domain {
 
     final staticFieldDescriptors =
         classDescriptor['staticFields'] as Map<String, dynamic>;
-    staticFieldDescriptors.forEach((name, descriptor) async {
+    staticFieldDescriptors.forEach((name, descriptor) {
       fieldRefs.add(
         FieldRef(
           name: name,

dwds/lib/src/debugging/debugger.dart

@@ -367,7 +367,7 @@ class Debugger extends Domain {
     // TODO(alanknight): Can these be moved to dart_scope.dart?
     final properties = await visibleProperties(debugger: this, frame: frame);
     final boundVariables = await Future.wait(
-      properties.map((property) async => await _boundVariable(property)),
+      properties.map(_boundVariable),
     );
 
     // Filter out variables that do not come from dart code, such as native
@@ -659,7 +659,7 @@ class Debugger extends Domain {
           // TODO(grouma) - In the future we should send all previously computed
           // skipLists.
           await _remoteDebugger.stepInto(params: {
-            'skipList': await _skipLists.compute(
+            'skipList': _skipLists.compute(
               scriptId,
               await _locations.locationsForUrl(url),
             )

dwds/lib/src/debugging/inspector.dart

@@ -1,6 +1,6 @@
 // Copyright (c) 2019, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.import 'dart:async';
+// BSD-style license that can be found in the LICENSE file.
 
 import 'package:async/async.dart';
 import 'package:collection/collection.dart';
@@ -114,9 +114,8 @@ class AppInspector implements AppInspectorInterface {
     final scripts = await scriptRefs;
 
     await DartUri.initialize();
-    await DartUri.recordAbsoluteUris(
-        libraries.map((lib) => lib.uri).whereNotNull());
-    await DartUri.recordAbsoluteUris(
+    DartUri.recordAbsoluteUris(libraries.map((lib) => lib.uri).whereNotNull());
+    DartUri.recordAbsoluteUris(
         scripts.map((script) => script.uri).whereNotNull());
 
     isolate.extensionRPCs?.addAll(await _getExtensionRpcs());

dwds/lib/src/debugging/instance.dart

@@ -79,7 +79,7 @@ class InstanceHelper extends Domain {
       ..offset = (truncated ? offset : null);
   }
 
-  Future<Instance?> _closureInstanceFor(RemoteObject remoteObject) async {
+  Instance? _closureInstanceFor(RemoteObject remoteObject) {
     final objectId = remoteObject.objectId;
     if (objectId == null) return null;
     final result = Instance(
@@ -354,8 +354,8 @@ class InstanceHelper extends Domain {
         count: count, elementCount: elements.length, length: length);
     final range = elements.sublist(0, rangeCount);
 
-    return Future.wait(range
-        .map((element) async => await _instanceRefForRemote(element.value)));
+    return Future.wait(
+        range.map((element) => _instanceRefForRemote(element.value)));
   }
 
   /// Return elements of the list from [properties].