Implement new getSourceReport parameter (#1598)

Author: Anna Gringauze

dwds/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 14.0.1-dev
+- Add `libraryFilters` optional parameter to the vm service implememtation
+  of `getSourceReport`.
+
 ## 14.0.0
 - Add column information to breakpoints to allow precise breakpoint placement.
 - Split SDK validation methods to allow validation of separate components.

dwds/lib/src/debugging/inspector.dart

@@ -428,12 +428,16 @@ function($argsString) {
   /// Return the VM SourceReport for the given parameters.
   ///
   /// Currently this implements the 'PossibleBreakpoints' report kind.
-  Future<SourceReport> getSourceReport(String isolateId, List<String> reports,
-      {String scriptId,
-      int tokenPos,
-      int endTokenPos,
-      bool forceCompile,
-      bool reportLines}) {
+  Future<SourceReport> getSourceReport(
+    String isolateId,
+    List<String> reports, {
+    String scriptId,
+    int tokenPos,
+    int endTokenPos,
+    bool forceCompile,
+    bool reportLines,
+    List<String> libraryFilters,
+  }) {
     checkIsolate('getSourceReport', isolateId);
 
     if (reports.contains(SourceReportKind.kCoverage)) {

dwds/lib/src/injected/client.js

@@ -562,20 +562,28 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
   }
 
   @override
-  Future<SourceReport> getSourceReport(String isolateId, List<String> reports,
-      {String scriptId,
-      int tokenPos,
-      int endTokenPos,
-      bool forceCompile,
-      bool reportLines}) async {
+  Future<SourceReport> getSourceReport(
+    String isolateId,
+    List<String> reports, {
+    String scriptId,
+    int tokenPos,
+    int endTokenPos,
+    bool forceCompile,
+    bool reportLines,
+    List<String> libraryFilters,
+  }) async {
     return await captureElapsedTime(() async {
       await isInitialized;
-      return await _inspector?.getSourceReport(isolateId, reports,
-          scriptId: scriptId,
-          tokenPos: tokenPos,
-          endTokenPos: endTokenPos,
-          forceCompile: forceCompile,
-          reportLines: reportLines);
+      return await _inspector?.getSourceReport(
+        isolateId,
+        reports,
+        scriptId: scriptId,
+        tokenPos: tokenPos,
+        endTokenPos: endTokenPos,
+        forceCompile: forceCompile,
+        reportLines: reportLines,
+        libraryFilters: libraryFilters,
+      );
     }, (result) => DwdsEvent.getSourceReport());
   }
 

dwds/lib/src/services/chrome_proxy_service.dart

@@ -1,6 +1,6 @@
 name: dwds
 # Every time this changes you need to run `dart run build_runner build`.
-version: 14.0.0
+version: 14.0.1-dev
 description: >-
   A service that proxies between the Chrome debug protocol and the Dart VM
   service protocol.

dwds/lib/src/version.dart

@@ -867,6 +867,16 @@ void main() {
             service.getSourceReport(isolateId, ['Coverage']), throwsRPCError);
       });
 
+      test('Coverage report', () async {
+        var vm = await service.getVM();
+        var isolateId = vm.isolates.first.id;
+
+        await expectLater(
+            service.getSourceReport(isolateId, ['Coverage'],
+                libraryFilters: ['foo']),
+            throwsRPCError);
+      });
+
       test('report type not understood', () async {
         var vm = await service.getVM();
         var isolateId = vm.isolates.first.id;