Skip to content

Commit 4e350cd

Browse files
authored
Fix issue with the inspector panel in the Dart Debug Extension (#2242)
1 parent bbddba2 commit 4e350cd

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

dwds/debug_extension_mv3/web/utils.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@ String addQueryParameters(
143143
}) {
144144
final originalUri = Uri.parse(uri);
145145
final newUri = originalUri.replace(
146+
path: '', // Replace the /debugger path so that the inspector url works.
146147
queryParameters: {
147148
...originalUri.queryParameters,
148149
...queryParameters,

dwds/test/puppeteer/extension_common.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -694,7 +694,8 @@ void testAll({
694694
// origin, and being able to connect to the embedded Dart app.
695695
// See https://github.com/dart-lang/webdev/issues/1779
696696

697-
test('The Dart DevTools IFRAME has the correct query parameters',
697+
test(
698+
'The Dart DevTools IFRAME has the correct query parameters and path',
698699
() async {
699700
final chromeDevToolsPage = await getChromeDevToolsPage(browser);
700701
// There are no hooks for when a panel is added to Chrome DevTools,
@@ -736,6 +737,7 @@ void testAll({
736737
queryParameters,
737738
containsPair('backgroundColor', isNotEmpty),
738739
);
740+
expect(uri.path, equals('/'));
739741
});
740742

741743
test('Trying to debug a page with multiple Dart apps shows warning',

0 commit comments

Comments
 (0)