Skip to content

Commit ca9ba19

Browse files
srawlinsCommit Bot
authored andcommitted
Tidy some comments in analyzer
* DirectiveResolver was removed. * There is no more nameScope parameter on ResolverVisitor. Change-Id: I3617538366c21407fd841bea0cddb2ce7b3ea536 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240500 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
1 parent 0c307c6 commit ca9ba19

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -739,8 +739,6 @@ class LibraryAnalyzer {
739739
for (var directive in directivesToResolve) {
740740
directive.element = _libraryElement;
741741
}
742-
743-
// TODO(scheglov) remove DirectiveResolver class
744742
}
745743

746744
void _resolveFile(FileState file, CompilationUnit unit) {

pkg/analyzer/lib/src/dart/micro/library_analyzer.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -665,8 +665,6 @@ class LibraryAnalyzer {
665665
for (var directive in directivesToResolve) {
666666
directive.element = _libraryElement;
667667
}
668-
669-
// TODO(scheglov) remove DirectiveResolver class
670668
}
671669

672670
void _resolveFile({

pkg/analyzer/lib/src/generated/resolver.dart

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -258,10 +258,7 @@ class ResolverVisitor extends ThrowingAstVisitor<void>
258258
/// unit containing the node being visited. The [typeProvider] is the object
259259
/// used to access the types from the core library. The [errorListener] is the
260260
/// error listener that will be informed of any errors that are found during
261-
/// resolution. The [nameScope] is the scope used to resolve identifiers in
262-
/// the node that will first be visited. If `null` or unspecified, a new
263-
/// [LibraryScope] will be created based on [definingLibrary] and
264-
/// [typeProvider].
261+
/// resolution.
265262
///
266263
/// TODO(paulberry): make [featureSet] a required parameter (this will be a
267264
/// breaking change).
@@ -2910,7 +2907,7 @@ class ScopeResolverVisitor extends UnifyingAstVisitor<void> {
29102907
/// [definingLibrary] is the element for the library containing the node being
29112908
/// visited.
29122909
/// [source] is the source representing the compilation unit containing the
2913-
/// node being visited
2910+
/// node being visited.
29142911
/// [typeProvider] is the object used to access the types from the core
29152912
/// library.
29162913
/// [errorListener] is the error listener that will be informed of any errors

0 commit comments

Comments
 (0)