Skip to content

Commit 7f8bf79

Browse files
bwilkersonCommit Bot
authored andcommitted
Remove three more handlers
Change-Id: I5c79fbc2867780811c5703b8619d0eac89e94aab Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240602 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
1 parent 4b7cb55 commit 7f8bf79

File tree

5 files changed

+24
-130
lines changed

5 files changed

+24
-130
lines changed

pkg/analysis_server/lib/src/analysis_server.dart

Lines changed: 24 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,25 @@ import 'package:analysis_server/src/channel/channel.dart';
1616
import 'package:analysis_server/src/computer/computer_highlights.dart';
1717
import 'package:analysis_server/src/context_manager.dart';
1818
import 'package:analysis_server/src/domain_analysis.dart';
19-
import 'package:analysis_server/src/domain_analytics.dart';
2019
import 'package:analysis_server/src/domain_completion.dart';
21-
import 'package:analysis_server/src/domain_diagnostic.dart';
22-
import 'package:analysis_server/src/domain_kythe.dart';
2320
import 'package:analysis_server/src/domain_server.dart';
2421
import 'package:analysis_server/src/domains/analysis/occurrences.dart';
2522
import 'package:analysis_server/src/domains/analysis/occurrences_dart.dart';
2623
import 'package:analysis_server/src/edit/edit_domain.dart';
2724
import 'package:analysis_server/src/flutter/flutter_domain.dart';
2825
import 'package:analysis_server/src/flutter/flutter_notifications.dart';
26+
import 'package:analysis_server/src/handler/legacy/analytics_enable.dart';
27+
import 'package:analysis_server/src/handler/legacy/analytics_is_enabled.dart';
28+
import 'package:analysis_server/src/handler/legacy/analytics_send_event.dart';
29+
import 'package:analysis_server/src/handler/legacy/analytics_send_timing.dart';
30+
import 'package:analysis_server/src/handler/legacy/diagnostic_get_diagnostics.dart';
31+
import 'package:analysis_server/src/handler/legacy/diagnostic_get_server_port.dart';
2932
import 'package:analysis_server/src/handler/legacy/execution_create_context.dart';
3033
import 'package:analysis_server/src/handler/legacy/execution_delete_context.dart';
3134
import 'package:analysis_server/src/handler/legacy/execution_get_suggestions.dart';
3235
import 'package:analysis_server/src/handler/legacy/execution_map_uri.dart';
3336
import 'package:analysis_server/src/handler/legacy/execution_set_subscriptions.dart';
37+
import 'package:analysis_server/src/handler/legacy/kythe_get_kythe_entries.dart';
3438
import 'package:analysis_server/src/handler/legacy/legacy_handler.dart';
3539
import 'package:analysis_server/src/operation/operation_analysis.dart';
3640
import 'package:analysis_server/src/plugin/notification_manager.dart';
@@ -81,6 +85,20 @@ class AnalysisServer extends AbstractAnalysisServer {
8185
/// A map from the name of a request to a function used to create a request
8286
/// handler.
8387
static final Map<String, HandlerGenerator> handlerGenerators = {
88+
ANALYTICS_REQUEST_IS_ENABLED: (server, request, cancellationToken) =>
89+
AnalyticsIsEnabledHandler(server, request, cancellationToken),
90+
ANALYTICS_REQUEST_ENABLE: (server, request, cancellationToken) =>
91+
AnalyticsEnableHandler(server, request, cancellationToken),
92+
ANALYTICS_REQUEST_SEND_EVENT: (server, request, cancellationToken) =>
93+
AnalyticsSendEventHandler(server, request, cancellationToken),
94+
ANALYTICS_REQUEST_SEND_TIMING: (server, request, cancellationToken) =>
95+
AnalyticsSendTimingHandler(server, request, cancellationToken),
96+
//
97+
DIAGNOSTIC_REQUEST_GET_DIAGNOSTICS: (server, request, cancellationToken) =>
98+
DiagnosticGetDiagnosticsHandler(server, request, cancellationToken),
99+
DIAGNOSTIC_REQUEST_GET_SERVER_PORT: (server, request, cancellationToken) =>
100+
DiagnosticGetServerPortHandler(server, request, cancellationToken),
101+
//
84102
EXECUTION_REQUEST_CREATE_CONTEXT: (server, request, cancellationToken) =>
85103
ExecutionCreateContextHandler(server, request, cancellationToken),
86104
EXECUTION_REQUEST_DELETE_CONTEXT: (server, request, cancellationToken) =>
@@ -91,6 +109,9 @@ class AnalysisServer extends AbstractAnalysisServer {
91109
ExecutionMapUriHandler(server, request, cancellationToken),
92110
EXECUTION_REQUEST_SET_SUBSCRIPTIONS: (server, request, cancellationToken) =>
93111
ExecutionSetSubscriptionsHandler(server, request, cancellationToken),
112+
//
113+
KYTHE_REQUEST_GET_KYTHE_ENTRIES: (server, request, cancellationToken) =>
114+
KytheGetKytheEntriesHandler(server, request, cancellationToken),
94115
};
95116

96117
/// The channel from which requests are received and to which responses should
@@ -248,9 +269,6 @@ class AnalysisServer extends AbstractAnalysisServer {
248269
EditDomainHandler(this),
249270
SearchDomainHandler(this),
250271
CompletionDomainHandler(this),
251-
DiagnosticDomainHandler(this),
252-
AnalyticsDomainHandler(this),
253-
KytheDomainHandler(this),
254272
FlutterDomainHandler(this)
255273
];
256274
}

pkg/analysis_server/lib/src/domain_analytics.dart

Lines changed: 0 additions & 41 deletions
This file was deleted.

pkg/analysis_server/lib/src/domain_diagnostic.dart

Lines changed: 0 additions & 41 deletions
This file was deleted.

pkg/analysis_server/lib/src/domain_kythe.dart

Lines changed: 0 additions & 34 deletions
This file was deleted.

pkg/analysis_server/test/domain_diagnostic_test.dart

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// BSD-style license that can be found in the LICENSE file.
44

55
import 'package:analysis_server/protocol/protocol_generated.dart';
6-
import 'package:analysis_server/src/domain_diagnostic.dart';
76
import 'package:test/test.dart';
87
import 'package:test_reflective_loader/test_reflective_loader.dart';
98

@@ -17,13 +16,6 @@ void main() {
1716

1817
@reflectiveTest
1918
class DiagnosticDomainTest extends AbstractAnalysisTest {
20-
@override
21-
void setUp() {
22-
super.setUp();
23-
handler = DiagnosticDomainHandler(server);
24-
server.handlers = [handler];
25-
}
26-
2719
Future<void> test_getDiagnostics() async {
2820
newPubspecYamlFile('/project', 'name: project');
2921
newFile2('/project/bin/test.dart', 'main() {}');

0 commit comments

Comments
 (0)