[vm, gc] Remove some dead code.

TEST=ci
Change-Id: Ia0d0f181b8d54c3ec0e1cc8f2076bea7854379ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311142
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>

Author: rmacnak-google

runtime/vm/cpu_arm.cc

@@ -9,10 +9,6 @@
 #include "vm/cpu_arm.h"
 
 #include "vm/cpuinfo.h"
-#include "vm/heap/heap.h"
-#include "vm/isolate.h"
-#include "vm/object.h"
-#include "vm/simulator.h"
 
 #if !defined(TARGET_HOST_MISMATCH)
 #if defined(DART_HOST_OS_MACOS) || defined(DART_HOST_OS_IOS)

runtime/vm/cpu_arm64.cc

@@ -9,7 +9,6 @@
 #include "vm/cpu_arm64.h"
 
 #include "vm/cpuinfo.h"
-#include "vm/simulator.h"
 
 #if !defined(USING_SIMULATOR)
 #if defined(DART_HOST_OS_FUCHSIA)

runtime/vm/cpu_ia32.cc

@@ -8,12 +8,7 @@
 #include "vm/cpu.h"
 #include "vm/cpu_ia32.h"
 
-#include "vm/compiler/assembler/assembler.h"
-#include "vm/constants.h"
 #include "vm/cpuinfo.h"
-#include "vm/heap/heap.h"
-#include "vm/isolate.h"
-#include "vm/object.h"
 
 namespace dart {
 

runtime/vm/cpu_riscv.cc

@@ -9,7 +9,6 @@
 #include "vm/cpu_riscv.h"
 
 #include "vm/cpuinfo.h"
-#include "vm/simulator.h"
 
 #if !defined(USING_SIMULATOR)
 #if !defined(DART_HOST_OS_FUCHSIA)

runtime/vm/cpu_x64.cc

@@ -8,11 +8,7 @@
 #include "vm/cpu.h"
 #include "vm/cpu_x64.h"
 
-#include "vm/constants.h"
 #include "vm/cpuinfo.h"
-#include "vm/heap/heap.h"
-#include "vm/isolate.h"
-#include "vm/object.h"
 
 namespace dart {
 

runtime/vm/handles_impl.h

@@ -5,7 +5,7 @@
 #ifndef RUNTIME_VM_HANDLES_IMPL_H_
 #define RUNTIME_VM_HANDLES_IMPL_H_
 
-#include "vm/heap/heap.h"
+#include "vm/handle_visitor.h"
 #include "vm/thread.h"
 #include "vm/visitor.h"
 

runtime/vm/handles_test.cc

@@ -6,7 +6,6 @@
 #include "platform/assert.h"
 #include "vm/dart_api_state.h"
 #include "vm/flags.h"
-#include "vm/heap/heap.h"
 #include "vm/object.h"
 #include "vm/unit_test.h"
 #include "vm/zone.h"

runtime/vm/heap/gc_shared.h

@@ -13,7 +13,7 @@
 #endif
 
 #include "vm/dart_api_state.h"
-#include "vm/heap/scavenger.h"
+#include "vm/heap/heap.h"
 #include "vm/log.h"
 #include "vm/message_handler.h"
 #include "vm/object.h"

runtime/vm/heap/marker.cc

@@ -430,7 +430,6 @@ class MarkingVisitorBase : public ObjectPointerVisitor {
     PushMarked(raw_obj);
   }
 
-  Thread* thread_;
   PageSpace* page_space_;
   MarkerWorkList work_list_;
   MarkerWorkList deferred_work_list_;

runtime/vm/heap/scavenger.h

@@ -212,11 +212,8 @@ class Scavenger {
     ASSERT(external_size_ >= 0);
   }
 
-  void MakeNewSpaceIterable();
   int64_t FreeSpaceInWords(Isolate* isolate) const;
 
-  bool scavenging() const { return scavenging_; }
-
   // The maximum number of Dart mutator threads we allow to execute at the same
   // time.
   static intptr_t MaxMutatorThreadCount() {