Clarify how augmentations affect existing compile-time errors. #4545
+57
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
reviewed
Oct 24, 2025
lrhn
approved these changes
Oct 24, 2025
Member
lrhn
left a comment
lrhn
left a comment
There was a problem hiding this comment.
Feel free to ignore my usual "denotational semantics are better" spiel.
What you have is consistent with the rest. (It's not more under-specified than the rest, and probably not than the entire existing specification, it'll fit right in.)
Member
Author
|
Let me know if this looks better. |
lrhn
approved these changes
Nov 11, 2025
Member
lrhn
left a comment
lrhn
left a comment
There was a problem hiding this comment.
(And then I'll just have to argue in issu 4542 that two implements shouldn't be an error.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3690.