Fix a bug where cronet_http did not set content-length correctly (#800)

Author: brianquinlan

pkgs/cronet_http/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.0.3
+
+* Fix
+  [contentLength property is not sent for streamed responses](https://github.com/dart-lang/http/issues/801)
+
 ## 0.0.2
 
 * Set `StreamedResponse.reasonPhrase` and `StreamedResponse.request`. 

pkgs/cronet_http/lib/cronet_client.dart

@@ -206,8 +206,11 @@ class CronetClient extends BaseClient {
     final responseHeaders = (result.headers.cast<String, List<Object?>>())
         .map((key, value) => MapEntry(key.toLowerCase(), value.join(',')));
 
+    final contentLengthHeader = responseHeaders['content-length'];
     return StreamedResponse(responseDataController.stream, result.statusCode,
-        contentLength: responseHeaders['content-lenght'] as int?,
+        contentLength: contentLengthHeader == null
+            ? null
+            : int.tryParse(contentLengthHeader),
         reasonPhrase: result.statusText,
         request: request,
         isRedirect: result.isRedirect,

pkgs/http_client_conformance_tests/lib/src/response_body_server.dart

@@ -17,10 +17,15 @@ import 'package:stream_channel/stream_channel.dart';
 void hybridMain(StreamChannel<Object?> channel) async {
   final server = (await HttpServer.bind('localhost', 0))
     ..listen((request) async {
+      const message = 'Hello World!';
       await request.drain<void>();
       request.response.headers.set('Access-Control-Allow-Origin', '*');
       request.response.headers.set('Content-Type', 'text/plain');
-      request.response.write('Hello World!');
+      if (request.requestedUri.pathSegments.isNotEmpty &&
+          request.requestedUri.pathSegments.last == 'length') {
+        request.response.contentLength = message.length;
+      }
+      request.response.write(message);
       await request.response.close();
     });
 

pkgs/http_client_conformance_tests/lib/src/response_body_streamed_test.dart

@@ -40,6 +40,7 @@ void testResponseBodyStreamed(Client client,
 
       final request = Request('GET', Uri.http(host, ''));
       final response = await client.send(request);
+      expect(response.contentLength, null);
       var lastReceived = 0;
       await const LineSplitter()
           .bind(const Utf8Decoder().bind(response.stream))

pkgs/http_client_conformance_tests/lib/src/response_body_tests.dart

@@ -60,5 +60,17 @@ void testResponseBody(Client client,
       expect(response.request!.method, 'GET');
       expect(response.statusCode, 200);
     });
+
+    test('small response streamed with content length', () async {
+      final request = Request('GET', Uri.http(host, 'length'));
+      final response = await client.send(request);
+      expect(await response.stream.bytesToString(), message);
+      expect(response.contentLength, 12);
+      expect(response.headers['content-type'], 'text/plain');
+      expect(response.isRedirect, isFalse);
+      expect(response.reasonPhrase, 'OK');
+      expect(response.request!.method, 'GET');
+      expect(response.statusCode, 200);
+    });
   });
 }