More final, more nodoc, more good.

Author: lrhn

pkgs/collection/lib/src/combined_wrappers/combined_list.dart

@@ -15,7 +15,7 @@ import 'combined_iterator.dart';
 ///
 /// The index operator (`[]`) and [length] property of a [CombinedListView] are
 /// both `O(lists)` rather than `O(1)`. A [CombinedListView] is unmodifiable.
-class CombinedListView<T> extends ListBase<T>
+final class CombinedListView<T> extends ListBase<T>
     implements UnmodifiableListView<T> {
   static Never _throw() {
     throw UnsupportedError('Cannot modify an unmodifiable List');

pkgs/collection/lib/src/combined_wrappers/combined_map.dart

@@ -19,7 +19,7 @@ import 'combined_iterable.dart';
 ///
 /// The `length` getter is `O(M)` where M is the total number of entries in
 /// all maps, since it has to remove duplicate entries.
-class CombinedMapView<K, V> extends UnmodifiableMapBase<K, V> {
+final class CombinedMapView<K, V> extends UnmodifiableMapBase<K, V> {
   final Iterable<Map<K, V>> _maps;
 
   /// Create a new combined view of multiple maps.

pkgs/collection/lib/src/empty_unmodifiable_set.dart

@@ -8,7 +8,7 @@ import 'unmodifiable_wrappers.dart';
 import 'wrappers.dart';
 
 /// An unmodifiable, empty set which can be constant.
-class EmptyUnmodifiableSet<E> extends IterableBase<E>
+final class EmptyUnmodifiableSet<E> extends IterableBase<E>
     with UnmodifiableSetMixin<E>
     implements UnmodifiableSetView<E> {
   const EmptyUnmodifiableSet();

pkgs/collection/lib/src/equality_map.dart

@@ -8,7 +8,7 @@ import 'equality.dart';
 import 'wrappers.dart';
 
 /// A [Map] whose key equality is determined by an [Equality] object.
-class EqualityMap<K, V> extends DelegatingMap<K, V> {
+final class EqualityMap<K, V> extends DelegatingMap<K, V> {
   /// Creates a map with equality based on [equality].
   EqualityMap(Equality<K> equality)
       : super(LinkedHashMap(

pkgs/collection/lib/src/equality_set.dart

@@ -8,7 +8,7 @@ import 'equality.dart';
 import 'wrappers.dart';
 
 /// A [Set] whose key equality is determined by an [Equality] object.
-class EqualitySet<E> extends DelegatingSet<E> {
+final class EqualitySet<E> extends DelegatingSet<E> {
   /// Creates a set with equality based on [equality].
   EqualitySet(Equality<E> equality)
       : super(LinkedHashSet(

pkgs/collection/lib/src/iterable_extensions.dart

@@ -604,13 +604,16 @@ extension IterableExtension<T> on Iterable<T> {
 }
 
 /// Extensions that apply to iterables with a nullable element type.
+/// @nodoc
+@Deprecated('Use .nonNulls instead.')
 extension IterableNullableExtension<T extends Object> on Iterable<T?> {
   /// The non-`null` elements of this `Iterable`.
   ///
   /// Returns an iterable which emits all the non-`null` elements
   /// of this iterable, in their original iteration order.
   ///
   /// For an `Iterable<X?>`, this method is equivalent to `.whereType<X>()`.
+  /// @nodoc
   @Deprecated('Use .nonNulls instead.')
   Iterable<T> whereNotNull() sync* {
     for (var element in this) {

pkgs/collection/lib/src/iterable_zip.dart

@@ -13,8 +13,9 @@ import 'dart:collection';
 /// combined into a single list, which becomes the next value of this
 /// [Iterable]'s [Iterator]. As soon as any of the iterators run out,
 /// the zipped iterator also stops.
+/// @nodoc
 @Deprecated('Use [i1, i2].zip from dart:collection')
-class IterableZip<T> extends IterableBase<List<T>> {
+final class IterableZip<T> extends IterableBase<List<T>> {
   final Iterable<Iterable<T>> _iterables;
 
   IterableZip(Iterable<Iterable<T>> iterables) : _iterables = iterables;
@@ -28,7 +29,7 @@ class IterableZip<T> extends IterableBase<List<T>> {
   }
 }
 
-class _IteratorZip<T> implements Iterator<List<T>> {
+final class _IteratorZip<T> implements Iterator<List<T>> {
   final List<Iterator<T>> _iterators;
   List<T>? _current;
 

pkgs/collection/lib/src/union_set.dart

@@ -13,7 +13,7 @@ import 'unmodifiable_wrappers.dart';
 /// If an element is in multiple sets and the outer set is ordered, the version
 /// in the earliest inner set is preferred. Component sets are assumed to use
 /// `==` and `hashCode` for equality.
-class UnionSet<E> extends SetBase<E> with UnmodifiableSetMixin<E> {
+final class UnionSet<E> extends SetBase<E> with UnmodifiableSetMixin<E> {
   /// The set of sets that this provides a view of.
   final Set<Set<E>> _sets;
 

pkgs/collection/lib/src/wrappers.dart

@@ -503,7 +503,7 @@ class DelegatingMap<K, V> implements Map<K, V> {
 /// getter only shows an [Iterable] view of the keys.
 ///
 /// Note that [lookup] is not supported for this set.
-class MapKeySet<E> extends _DelegatingIterableBase<E>
+final class MapKeySet<E> extends _DelegatingIterableBase<E>
     with UnmodifiableSetMixin<E> {
   final Map<E, dynamic> _baseMap;
 
@@ -597,7 +597,8 @@ class MapKeySet<E> extends _DelegatingIterableBase<E>
 /// `recordSet.add(databaseRecord)` and `recordMap[id]`.
 ///
 /// Effectively, the map will act as a kind of index for the set.
-class MapValueSet<K, V> extends _DelegatingIterableBase<V> implements Set<V> {
+final class MapValueSet<K, V> extends _DelegatingIterableBase<V>
+    implements Set<V> {
   final Map<K, V> _baseMap;
   final K Function(V) _keyForValue;
 

pkgs/collection/test/extensions_test.dart

@@ -2225,7 +2225,7 @@ Iterable<T> iterable<T>(Iterable<T> values) sync* {
   yield* values;
 }
 
-Never unreachable([Object? _, Object? _, Object? _]) => fail('Unreachable');
+Never unreachable([Object? _, Object? __, Object? ___]) => fail('Unreachable');
 
 String toString(Object? o) => '$o';