Fix build_daemon modify while building. #4275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4268
This is a regression from a few versions back: the "was it actually modified" check was changed during the refactor to use the readerWriter in buildSeries which can have a cache, which fails because the cache refuses to invalidate a file while there are pending writes. (Which is good! It would have corrupted the build).
Revert to using the one without a cache instead.
I tried to come up with an e2e test for it but the timing is awkward, I didn't manage to repro in a test; it repros easily enough manually, so confirmed the fix that way.