Skip to content

Conversation

@davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented Nov 10, 2025

Fix #4268

This is a regression from a few versions back: the "was it actually modified" check was changed during the refactor to use the readerWriter in buildSeries which can have a cache, which fails because the cache refuses to invalidate a file while there are pending writes. (Which is good! It would have corrupted the build).

Revert to using the one without a cache instead.

I tried to come up with an e2e test for it but the timing is awkward, I didn't manage to repro in a test; it repros easily enough manually, so confirmed the fix that way.

@davidmorgan davidmorgan added the publish-ignore-warnings Ignore warnings in the publish check bot label Nov 10, 2025
@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:build 4.0.2 already published at pub.dev
package:build_config 1.2.0 already published at pub.dev
package:build_daemon 4.1.0 already published at pub.dev
package:build_modules 5.1.1 already published at pub.dev
package:build_runner 2.10.2 ready to publish build_runner-v2.10.2
package:build_test 3.5.2 ready to publish build_test-v3.5.2
package:build_web_compilers 4.4.1 already published at pub.dev
package:scratch_space 1.2.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions
Copy link

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@davidmorgan davidmorgan requested a review from jensjoha November 10, 2025 15:01
@davidmorgan davidmorgan marked this pull request as ready for review November 11, 2025 08:00
@davidmorgan davidmorgan merged commit 98f0405 into dart-lang:master Nov 11, 2025
44 of 45 checks passed
@davidmorgan davidmorgan deleted the cache-invalidate-bug branch November 11, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

publish-ignore-warnings Ignore warnings in the publish check bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow build_runner to continue compiling when modifying a source file

2 participants