Skip to content

Commit 98f0405

Browse files
authored
Fix build_daemon modify while building. (#4275)
1 parent ce9f735 commit 98f0405

File tree

5 files changed

+8
-11
lines changed

5 files changed

+8
-11
lines changed

build_runner/CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
## 2.10.3-wip
1+
## 2.10.2
22

3+
- Bug fix: fix issue with webdev failing due to a modification during a build.
34
- In "serve" and "watch" modes, retry failed compiles instead of exiting.
45

56
## 2.10.1

build_runner/lib/src/build/build_series.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,8 @@ class BuildSeries {
162162

163163
// For modifications, confirm that the content actually changed.
164164
if (change.type == ChangeType.MODIFY) {
165-
_readerWriter.cache.invalidate([id]);
166-
final newDigest = await _readerWriter.digest(id);
165+
// Use `_buildPlan.readerWriter` which has no cache to do a real read.
166+
final newDigest = await _buildPlan.readerWriter.digest(id);
167167
if (node.digest != newDigest) {
168168
result.add(change);
169169
}

build_runner/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: build_runner
2-
version: 2.10.3-wip
2+
version: 2.10.2
33
description: A build system for Dart code generation and modular compilation.
44
repository: https://github.com/dart-lang/build/tree/master/build_runner
55
resolution: workspace

build_test/CHANGELOG.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
## 3.5.3-wip
2-
3-
- Use `build_runner` 2.10.3.
4-
5-
## 3.5.2-wip
1+
## 3.5.2
62

73
- Use `build_runner` 2.10.2.
84

build_test/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: build_test
22
description: Utilities for writing unit tests of Builders.
3-
version: 3.5.3-wip
3+
version: 3.5.2
44
repository: https://github.com/dart-lang/build/tree/master/build_test
55
resolution: workspace
66

@@ -10,7 +10,7 @@ environment:
1010
dependencies:
1111
build: ^4.0.0
1212
build_config: ^1.0.0
13-
build_runner: '2.10.3-wip'
13+
build_runner: '2.10.2'
1414
built_collection: ^5.1.1
1515
crypto: ^3.0.0
1616
glob: ^2.0.0

0 commit comments

Comments
 (0)