fix(dart_frog_prod_server): stop assuming directory name is package name when bundling (#1253)

Author: alestiago

bricks/dart_frog_prod_server/hooks/lib/src/create_external_packages_folder.dart

@@ -29,7 +29,7 @@ Future<List<String>> createExternalPackagesFolder({
             if (!isExternal) return null;
 
             return _ExternalPathDependency(
-              name: pathResolver.basename(d.path),
+              name: p.package(),
               path: path.join(projectDirectory.path, d.path),
             );
           },

bricks/dart_frog_prod_server/hooks/test/pubspec_locks.dart

@@ -6,6 +6,8 @@ library pubspec_locks;
 /// * A transitive dependency.
 /// * A direct main path dependency that is not a child of the project
 /// directory.
+/// * A direct main path dependency that is not a child of the project
+/// directory and has a different package name than the directory name.
 /// * A direct main dependency that is hosted.
 /// * A direct dev main dependency that is hosted.
 const fooPath = '''
@@ -25,6 +27,13 @@ packages:
       relative: true
     source: path
     version: "0.0.0"
+  second_foo:
+    dependency: "direct main"
+    description:
+      path: "../../foo2"
+      relative: true
+    source: path
+    version: "0.0.0"
   mason:
     dependency: "direct main"
     description:

bricks/dart_frog_prod_server/hooks/test/src/create_external_packages_folder_test.dart

@@ -25,14 +25,27 @@ void main() {
           },
         );
 
-        final from = path.join(projectDirectory.path, '../../foo');
-        final to = path.join(
+        final fooPackageDirectory =
+            path.join(projectDirectory.path, '../../foo');
+        final fooPackageDirectoryTarget = path.join(
           projectDirectory.path,
           'build',
           '.dart_frog_path_dependencies',
           'foo',
         );
-        expect(copyCalls, ['$from -> $to']);
+
+        final secondFooPackageDirectory =
+            path.join(projectDirectory.path, '../../foo2');
+        final secondFooPackageDirectoryTarget = path.join(
+          projectDirectory.path,
+          'build',
+          '.dart_frog_path_dependencies',
+          'second_foo',
+        );
+        expect(copyCalls, [
+          '$fooPackageDirectory -> $fooPackageDirectoryTarget',
+          '$secondFooPackageDirectory -> $secondFooPackageDirectoryTarget',
+        ]);
       },
     );