chore: support latest analyzer version

incendial · incendial · commit f3e18a4ee4b8 · 2022-10-28T11:11:15.000+04:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@
 * feat: **Breaking change** change severity for avoid-banned-imports, prefer-trailing-comma, ban-name rules.
 * feat: support proxy calls for check-unused-l10n.
 * feat: **Breaking change** cleanup public API.
+* chore: restrict `analyzer` version to `>=5.1.0 <5.3.0`.
 
 ## 4.21.2
 
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_collection_methods_with_unrelated_types/visitor.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_collection_methods_with_unrelated_types/visitor.dart
@@ -92,6 +92,7 @@ class _Visitor extends RecursiveAstVisitor<void> {
 
     final typeArgElements = type.typeArguments
         .map((typeArg) {
+          // ignore: deprecated_member_use
           final element = typeArg.element2;
 
           return element is ClassElement
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_global_state/visitor.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_global_state/visitor.dart
@@ -9,6 +9,7 @@ class _Visitor extends RecursiveAstVisitor<void> {
   void visitVariableDeclaration(VariableDeclaration node) {
     super.visitVariableDeclaration(node);
 
+    // ignore: deprecated_member_use
     if (node.declaredElement?.enclosingElement3 is CompilationUnitElement) {
       if (_isNodeValid(node)) {
         _declarations.add(node);
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_type_assertions/visitor.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_type_assertions/visitor.dart
@@ -98,12 +98,14 @@ class _Visitor extends RecursiveAstVisitor<void> {
     DartType objectType,
     DartType castedType,
   ) {
+    // ignore: deprecated_member_use
     if (objectType.element2 == castedType.element2) {
       return objectType;
     }
 
     if (objectType is InterfaceType) {
       return objectType.allSupertypes
+          // ignore: deprecated_member_use
           .firstWhereOrNull((value) => value.element2 == castedType.element2);
     }
 
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_type_casts/visitor.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_type_casts/visitor.dart
@@ -52,12 +52,14 @@ class _Visitor extends RecursiveAstVisitor<void> {
     DartType objectType,
     DartType castedType,
   ) {
+    // ignore: deprecated_member_use
     if (objectType.element2 == castedType.element2) {
       return objectType;
     }
 
     if (objectType is InterfaceType) {
       return objectType.allSupertypes
+          // ignore: deprecated_member_use
           .firstWhereOrNull((value) => value.element2 == castedType.element2);
     }
 
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unrelated_type_assertions/visitor.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unrelated_type_assertions/visitor.dart
@@ -66,6 +66,7 @@ class _Visitor extends RecursiveAstVisitor<void> {
             ? objectType.typeArguments.first
             : objectType;
 
+    // ignore: deprecated_member_use
     if ((correctObjectType.element2 == castedType.element2) ||
         castedType.isDynamic ||
         correctObjectType.isDynamic ||
@@ -75,6 +76,7 @@ class _Visitor extends RecursiveAstVisitor<void> {
 
     if (correctObjectType is InterfaceType) {
       return correctObjectType.allSupertypes
+          // ignore: deprecated_member_use
           .firstWhereOrNull((value) => value.element2 == castedType.element2);
     }
 
@@ -113,5 +115,6 @@ class _Visitor extends RecursiveAstVisitor<void> {
 
   bool _isObjectAndEnum(DartType objectType, DartType castedType) =>
       objectType.isDartCoreObject &&
+      // ignore: deprecated_member_use
       castedType.element2?.kind == ElementKind.ENUM;
 }
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_iterable_of/visitor.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_iterable_of/visitor.dart
@@ -89,12 +89,14 @@ class _Visitor extends RecursiveAstVisitor<void> {
     DartType objectType,
     DartType castedType,
   ) {
+    // ignore: deprecated_member_use
     if (objectType.element2 == castedType.element2) {
       return objectType;
     }
 
     if (objectType is InterfaceType) {
       return objectType.allSupertypes
+          // ignore: deprecated_member_use
           .firstWhereOrNull((value) => value.element2 == castedType.element2);
     }
 
diff --git a/lib/src/analyzers/unnecessary_nullable_analyzer/invocations_visitor.dart b/lib/src/analyzers/unnecessary_nullable_analyzer/invocations_visitor.dart
@@ -13,6 +13,7 @@ class InvocationsVisitor extends RecursiveAstVisitor<void> {
   void visitExportDirective(ExportDirective node) {
     super.visitExportDirective(node);
 
+    // ignore: deprecated_member_use
     final uri = node.element2?.uri;
     if (uri is DirectiveUriWithSource) {
       invocationsUsages.exports.add(uri.source.fullName);
diff --git a/lib/src/analyzers/unused_code_analyzer/used_code_visitor.dart b/lib/src/analyzers/unused_code_analyzer/used_code_visitor.dart
@@ -17,6 +17,7 @@ class UsedCodeVisitor extends RecursiveAstVisitor<void> {
   void visitExportDirective(ExportDirective node) {
     super.visitExportDirective(node);
 
+    // ignore: deprecated_member_use
     final path = node.element2?.exportedLibrary?.source.fullName;
     if (path != null) {
       fileElementsUsage.exports.add(path);
@@ -89,6 +90,7 @@ class UsedCodeVisitor extends RecursiveAstVisitor<void> {
 
   void _recordIfExtensionMember(Element? element) {
     if (element != null) {
+      // ignore: deprecated_member_use
       final enclosingElement = element.enclosingElement3;
       if (enclosingElement is ExtensionElement) {
         _recordUsedExtension(enclosingElement);
@@ -165,6 +167,7 @@ class UsedCodeVisitor extends RecursiveAstVisitor<void> {
       return;
     }
 
+    // ignore: deprecated_member_use
     final enclosingElement = element.enclosingElement3;
     if (enclosingElement is CompilationUnitElement) {
       _recordUsedElement(element);
@@ -199,6 +202,7 @@ class UsedCodeVisitor extends RecursiveAstVisitor<void> {
     return root.directives.fold<List<String>>([], (previousValue, directive) {
       if (directive is ImportDirective &&
           directive.prefix?.name == target.name) {
+        // ignore: deprecated_member_use
         final path = directive.element2?.importedLibrary?.source.fullName;
         if (path != null) {
           previousValue.add(path);
diff --git a/lib/src/analyzers/unused_files_analyzer/unused_files_visitor.dart b/lib/src/analyzers/unused_files_analyzer/unused_files_visitor.dart
@@ -49,14 +49,17 @@ class UnusedFilesVisitor extends GeneralizingAstVisitor<void> {
 
   String? _getAbsolutePath(UriBasedDirective node) {
     if (node is ImportDirective) {
+      // ignore: deprecated_member_use
       return node.element2?.importedLibrary?.source.fullName;
     }
 
     if (node is ExportDirective) {
+      // ignore: deprecated_member_use
       return node.element2?.exportedLibrary?.source.fullName;
     }
 
     if (node is PartDirective) {
+      // ignore: deprecated_member_use
       final uri = node.element2?.uri;
       if (uri is DirectiveUriWithSource) {
         return uri.source.fullName;
diff --git a/lib/src/analyzers/unused_l10n_analyzer/unused_l10n_analyzer.dart b/lib/src/analyzers/unused_l10n_analyzer/unused_l10n_analyzer.dart
@@ -136,6 +136,7 @@ class UnusedL10nAnalyzer {
         final supertype = classElement.supertype;
         if (supertype is InterfaceType) {
           final report = _getUnusedReports(
+            // ignore: deprecated_member_use
             supertype.element2,
             usages,
             rootFolder,
diff --git a/lib/src/analyzers/unused_l10n_analyzer/unused_l10n_visitor.dart b/lib/src/analyzers/unused_l10n_analyzer/unused_l10n_visitor.dart
@@ -107,6 +107,7 @@ class UnusedL10nVisitor extends RecursiveAstVisitor<void> {
 
   bool _matchExtension(Expression? target) =>
       target is PrefixedIdentifier &&
+      // ignore: deprecated_member_use
       target.staticElement?.enclosingElement3 is ExtensionElement;
 
   bool _matchStaticGetter(Expression? target) =>
@@ -119,13 +120,15 @@ class UnusedL10nVisitor extends RecursiveAstVisitor<void> {
     final staticElement = target.staticElement;
 
     if (staticElement is VariableElement) {
+      // ignore: deprecated_member_use
       final classElement = staticElement.type.element2;
       if (_classPattern.hasMatch(classElement?.name ?? '')) {
         _tryAddInvocation(classElement, name);
       }
 
       return;
     } else if (staticElement is PropertyAccessorElement) {
+      // ignore: deprecated_member_use
       final classElement = staticElement.type.returnType.element2;
       if (_classPattern.hasMatch(classElement?.name ?? '')) {
         _tryAddInvocation(classElement, name);
@@ -142,17 +145,20 @@ class UnusedL10nVisitor extends RecursiveAstVisitor<void> {
     String name,
   ) {
     final staticElement =
+        // ignore: deprecated_member_use
         target.constructorName.staticElement?.enclosingElement3;
 
     _tryAddInvocation(staticElement, name);
   }
 
   void _addMemberInvocationOnAccessor(SimpleIdentifier target, String name) {
     final staticElement =
+        // ignore: deprecated_member_use
         target.staticElement?.enclosingElement3 as ExtensionElement;
 
     for (final element in staticElement.accessors) {
       if (_classPattern.hasMatch(element.returnType.toString())) {
+        // ignore: deprecated_member_use
         final declaredElement = element.returnType.element2;
 
         _tryAddInvocation(declaredElement, name);
diff --git a/lib/src/utils/flutter_types_utils.dart b/lib/src/utils/flutter_types_utils.dart
@@ -48,6 +48,7 @@ bool _isWidget(DartType? type) =>
 bool _isSubclassOfWidget(DartType? type) =>
     type is InterfaceType && type.allSupertypes.any(_isWidget);
 
+// ignore: deprecated_member_use
 bool _isWidgetState(DartType? type) => type?.element2?.displayName == 'State';
 
 bool _isSubclassOfWidgetState(DartType? type) =>
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -15,7 +15,7 @@ platforms:
   macos:
 
 dependencies:
-  analyzer: ">=5.1.0 <5.2.0"
+  analyzer: ">=5.1.0 <5.3.0"
   analyzer_plugin: ">=0.11.0 <0.12.0"
   ansicolor: ^2.0.1
   args: ^2.0.0

Original file line number	Diff line number	Diff line change
`@@ -98,12 +98,14 @@ class _Visitor extends RecursiveAstVisitor<void> {`
`98`	`98`	`DartType objectType,`
`99`	`99`	`DartType castedType,`
`100`	`100`	`) {`
	`101`	`+ // ignore: deprecated_member_use`
`101`	`102`	`if (objectType.element2 == castedType.element2) {`
`102`	`103`	`return objectType;`
`103`	`104`	`}`
`104`	`105`
`105`	`106`	`if (objectType is InterfaceType) {`
`106`	`107`	`return objectType.allSupertypes`
	`108`	`+ // ignore: deprecated_member_use`
`107`	`109`	`.firstWhereOrNull((value) => value.element2 == castedType.element2);`
`108`	`110`	`}`
`109`	`111`
Original file line number	Diff line number	Diff line change
`@@ -52,12 +52,14 @@ class _Visitor extends RecursiveAstVisitor<void> {`
`52`	`52`	`DartType objectType,`
`53`	`53`	`DartType castedType,`
`54`	`54`	`) {`
	`55`	`+ // ignore: deprecated_member_use`
`55`	`56`	`if (objectType.element2 == castedType.element2) {`
`56`	`57`	`return objectType;`
`57`	`58`	`}`
`58`	`59`
`59`	`60`	`if (objectType is InterfaceType) {`
`60`	`61`	`return objectType.allSupertypes`
	`62`	`+ // ignore: deprecated_member_use`
`61`	`63`	`.firstWhereOrNull((value) => value.element2 == castedType.element2);`
`62`	`64`	`}`
`63`	`65`
Original file line number	Diff line number	Diff line change
`@@ -89,12 +89,14 @@ class _Visitor extends RecursiveAstVisitor<void> {`
`89`	`89`	`DartType objectType,`
`90`	`90`	`DartType castedType,`
`91`	`91`	`) {`
	`92`	`+ // ignore: deprecated_member_use`
`92`	`93`	`if (objectType.element2 == castedType.element2) {`
`93`	`94`	`return objectType;`
`94`	`95`	`}`
`95`	`96`
`96`	`97`	`if (objectType is InterfaceType) {`
`97`	`98`	`return objectType.allSupertypes`
	`99`	`+ // ignore: deprecated_member_use`
`98`	`100`	`.firstWhereOrNull((value) => value.element2 == castedType.element2);`
`99`	`101`	`}`
`100`	`102`