chore: fix some analyzer issues

Author: dkrutskikh

CHANGELOG.md

@@ -5,7 +5,7 @@
 * **Breaking Change:** cli arguments `--fatal-unused` and `--fatal-warnings` activate by default.
 * feat: add static code diagnostics `avoid-collection-methods-with-unrelated-types`, `ban-name`, `tag-name`.
 * fix: added parameter constant check in `avoid-border-all`.
-* chore: restrict `analyzer` version to `>=2.8.0 <3.3.0`.
+* chore: restrict `analyzer` version to `>=2.8.0 <3.4.0`.
 * chore: restrict `analyzer_plugin` version to `>=0.9.0 <0.10.0`.
 * chore: set min `mocktail` version to `^0.3.0`.
 

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_returning_widgets/visitor.dart

@@ -36,6 +36,7 @@ class _Visitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitClassDeclaration(ClassDeclaration node) {
+    // ignore: deprecated_member_use
     final classType = node.extendsClause?.superclass2.type;
     if (!isWidgetOrSubclass(classType) && !isWidgetStateOrSubclass(classType)) {
       return;

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_setstate/visitor.dart

@@ -14,6 +14,7 @@ class _Visitor extends RecursiveAstVisitor<void> {
   void visitClassDeclaration(ClassDeclaration node) {
     super.visitClassDeclaration(node);
 
+    // ignore: deprecated_member_use
     final type = node.extendsClause?.superclass2.type;
     if (type == null || !isWidgetStateOrSubclass(type)) {
       return;

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_extracting_callbacks/visitor.dart

@@ -11,6 +11,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitClassDeclaration(ClassDeclaration node) {
+    // ignore: deprecated_member_use
     final classType = node.extendsClause?.superclass2.type;
     if (!isWidgetOrSubclass(classType) && !isWidgetStateOrSubclass(classType)) {
       return;

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_single_widget_per_file/visitor.dart

@@ -15,6 +15,7 @@ class _Visitor extends SimpleAstVisitor<void> {
   void visitClassDeclaration(ClassDeclaration node) {
     super.visitClassDeclaration(node);
 
+    // ignore: deprecated_member_use
     final classType = node.extendsClause?.superclass2.type;
     if (isWidgetOrSubclass(classType) &&
         (!_ignorePrivateWidgets || !Identifier.isPrivateName(node.name.name))) {

lib/src/analyzers/lint_analyzer/rules/rules_list/tag_name/tag_name_rule.dart

@@ -2,7 +2,6 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:meta/meta_meta.dart';
 
 import '../../../../../utils/node_utils.dart';
 import '../../../lint_utils.dart';

pubspec.yaml

@@ -10,8 +10,8 @@ environment:
   sdk: ">=2.14.0 <3.0.0"
 
 dependencies:
-  analyzer: ">=2.8.0 <3.3.0"
-  analyzer_plugin: ">=0.8.0 <0.10.0"
+  analyzer: ">=2.8.0 <3.4.0"
+  analyzer_plugin: ^0.9.0
   ansicolor: ^2.0.1
   args: ^2.0.0
   collection: ^1.15.0

test/src/analyzers/lint_analyzer/rules/rules_list/ban_name/ban_name_rule.dart renamed to test/src/analyzers/lint_analyzer/rules/rules_list/ban_name/ban_name_rule_test.dart

@@ -0,0 +1,3 @@
+void myShowDialog(String arg1, String arg2) {}
+
+void showDialog(String arg1, String arg2) {}

test/src/analyzers/lint_analyzer/rules/rules_list/ban_name/examples/dialogs.dart

@@ -1,5 +1,5 @@
-import 'package:flutter/material.dart';
-import 'package:flutter/material.dart' as material;
+import 'dialog.dart';
+import 'dialog.dart' as material;
 
 void func() {
   myShowDialog('some_arguments', 'another_argument');