fix: update 'Maintainability Index' metric comment message (#488)

Author: dkrutskikh

CHANGELOG.md

@@ -8,6 +8,7 @@
 * feat: improve unused files check, add support for `vm:entry-point` annotation.
 * fix: compute NumberOfParametersMetric only for functions and methods.
 * fix: skip synthetic tokens while compute 'Source lines of Code'.
+* fix: update 'Maintainability Index' metric comment message.
 
 ## 4.3.3
 

lib/src/analyzers/lint_analyzer/metrics/metrics_list/maintainability_index_metric.dart

@@ -95,10 +95,10 @@ class MaintainabilityIndexMetric extends FunctionMetric<int> {
 
   @override
   String commentMessage(String nodeType, int value, int? threshold) {
-    final exceeds = threshold != null && value > threshold
-        ? ', exceeds the minimum of $threshold allowed'
+    final exceeds = threshold != null && value < threshold
+        ? ', below the minimum of $threshold allowed'
         : '';
-    final index = '$value maintability index';
+    final index = '$value maintainability index';
 
     return 'This $nodeType has $index$exceeds.';
   }

test/analyzers/lint_analyzer/metrics/metrics_list/maintainability_index_metric_test.dart

@@ -51,7 +51,9 @@ Future<void> main() async {
       expect(metricValue.level, equals(MetricValueLevel.warning));
       expect(
         metricValue.comment,
-        equals('This method has 46 maintability index.'),
+        equals(
+          'This method has 46 maintainability index, below the minimum of 50 allowed.',
+        ),
       );
       expect(metricValue.recommendation, isNull);
       expect(metricValue.context, isEmpty);