feat: add enums validations. (#507)

* Prefer correct identifier name

* Added rule to rules factory

* Review changes

* feat: formatted code

* feat: moved creating validator in rule constructor

* feat: moved validator file

* feat: sorted alphabetical

* fix: changed test case

* Update lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_correct_identifier_length/utils/config_parser.dart

Co-authored-by: Denis Grafov <grafov.denis@gmail.com>

* fix: Den review changes

* fix: Add getter and setter lint. Ignore _ in variable name

* fix: Analised issue

* fix: CHANGELOG.md

* fix: formatted code

* Update lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_correct_identifier_length/prefer_correct_identifier_length.dart

Co-authored-by: Denis Grafov <grafov.denis@gmail.com>

* fix: change error label

* Update CHANGELOG.md

Co-authored-by: Denis Grafov <grafov.denis@gmail.com>

* fix: change reduce -> decrease

* fix: change reduce -> decrease

* fix: change reduce -> decrease

* fix: change reduce -> decrease

* fix: change reduce -> decrease

* check const and global variable

* convert to normal function

* add examples and support enums

* Review changes

* Add lint comments

* Fix getter/setter issue and enums. Add test case without error

* fixes enums validation and test cases

* remeved from CHANGELOG.md

* rewrote add block

* restore loop

Co-authored-by: Denis Grafov <grafov.denis@gmail.com>
Co-authored-by: Dmitry Krutskikh <dmitry.krutskikh@gmail.com>

Author: 3 people

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_correct_identifier_length/visitor.dart

@@ -12,7 +12,7 @@ class _Visitor extends ScopeVisitor {
   void visitMethodDeclaration(MethodDeclaration node) {
     super.visitMethodDeclaration(node);
 
-    if (node.isGetter || node.isSetter && !validator.isValid(node.name)) {
+    if ((node.isGetter || node.isSetter) && !validator.isValid(node.name)) {
       _declarationNodes.add(node.name);
     }
   }
@@ -22,7 +22,9 @@ class _Visitor extends ScopeVisitor {
     super.visitEnumDeclaration(node);
 
     for (final node in node.constants) {
-      _declarationNodes.add(node.name);
+      if (!validator.isValid(node.name)) {
+        _declarationNodes.add(node.name);
+      }
     }
   }
 

test/analyzers/lint_analyzer/rules/rules_list/prefer_correct_identifier_length/examples/without_error_example.dart

@@ -0,0 +1,48 @@
+class WithoutErrorExample {
+  final abc;
+  const bcd;
+
+  WithoutErrorExample.todo() {
+    final abc = 1;
+    const bcd = 1;
+  }
+
+  WithoutErrorExample._() {
+    final abc = 1;
+    const bcd = 1;
+  }
+
+  bool get abcd => false;
+
+  bool set bcde() => true;
+
+  void test() {
+    final bcd = 1;
+    const abc = 1;
+  }
+}
+
+void test() {
+  final abc = 0;
+  final bcd = 1;
+}
+
+final abc = 1;
+const bcd = 1;
+
+enum Enum {
+  abc,
+  bcd,
+}
+
+extension Extension on String {
+  onExtension() {
+    final abc = 1;
+    const bcd = 1;
+  }
+}
+
+mixin Mixin {
+  final abc = 1;
+  const bcd = 1;
+}

test/analyzers/lint_analyzer/rules/rules_list/prefer_correct_identifier_length/prefer_correct_identifier_length_test.dart

@@ -10,6 +10,7 @@ const _commonExample = '$_path/common_example.dart';
 const _enumExample = '$_path/enum_example.dart';
 const _mixinExample = '$_path/mixin_example.dart';
 const _extensionExample = '$_path/extension_example.dart';
+const _withoutErrorExample = '$_path/without_error_example.dart';
 
 void main() {
   group('PreferCorrectIdentifierLength', () {
@@ -24,6 +25,13 @@ void main() {
       );
     });
 
+    test('reports no issues', () async {
+      final unit = await RuleTestHelper.resolveFromFile(_withoutErrorExample);
+      final issues = PreferCorrectIdentifierLength().check(unit);
+
+      RuleTestHelper.verifyNoIssues(issues);
+    });
+
     test('reports about found all issues in class_example.dart', () async {
       final unit = await RuleTestHelper.resolveFromFile(_classExample);
       final issues = PreferCorrectIdentifierLength({
@@ -97,11 +105,7 @@ void main() {
 
     test('reports about found all issues in common_example.dart', () async {
       final unit = await RuleTestHelper.resolveFromFile(_commonExample);
-      final issues = PreferCorrectIdentifierLength({
-        'max-identifier-length': 10,
-        'min-identifier-length': 3,
-        'exceptions': ['z'],
-      }).check(unit);
+      final issues = PreferCorrectIdentifierLength().check(unit);
 
       RuleTestHelper.verifyIssues(
         issues: issues,