fix: make check-unused-l10n report class fields (#517)

* fix: make check-unused-l10n report class fields

* chore: remove additional toList calls

Author: incendial

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+* fix: make check-unused-l10n report class fields.
+
 ## 4.5.0-dev.2
 
 * feat: add static code diagnostics `prefer-correct-type-name`, `prefer-last`, `avoid-nested-conditional-expressions`.

lib/src/analyzers/unused_l10n_analyzer/unused_l10n_analyzer.dart

@@ -166,8 +166,8 @@ class UnusedL10nAnalyzer {
     CompilationUnitElement unit,
   ) {
     final unusedAccessors = classElement.accessors
-        .where((field) => !usages.contains(field.name) && !field.isSynthetic)
-        .toList();
+        .where((field) => !usages.contains(field.name))
+        .map((field) => field.isSynthetic ? field.nonSynthetic : field);
 
     return unusedAccessors
         .map((accessor) => _createL10nIssues(accessor as ElementImpl, unit))
@@ -180,10 +180,8 @@ class UnusedL10nAnalyzer {
     CompilationUnitElement unit,
   ) {
     final unusedMethods = classElement.methods
-        .where(
-          (method) => !usages.contains(method.name) && !method.isSynthetic,
-        )
-        .toList();
+        .where((method) => !usages.contains(method.name))
+        .map((method) => method.isSynthetic ? method.nonSynthetic : method);
 
     return unusedMethods
         .map((method) => _createL10nIssues(method as ElementImpl, unit))

test/analyzers/unused_l10n_analyzer/unused_l10n_analyzer_test.dart

@@ -50,6 +50,43 @@ void main() {
         expect(secondIssues.location.column, 3);
       });
 
+      test('should analyze files with custom class pattern', () async {
+        final config = _createConfig(
+          analyzerExcludePatterns: analyzerExcludes,
+          classPattern: r'^S$',
+        );
+
+        final result = await analyzer.runCliAnalysis(
+          folders,
+          rootDirectory,
+          config,
+        );
+
+        final report = result.single;
+        expect(report.className, 'S');
+
+        final firstIssue = report.issues.elementAt(0);
+        expect(firstIssue.memberName, 'field');
+        expect(firstIssue.location.line, 13);
+        expect(firstIssue.location.column, 3);
+
+        final secondIssues = report.issues.elementAt(1);
+        expect(
+          secondIssues.memberName,
+          'method(String value)',
+        );
+        expect(secondIssues.location.line, 17);
+        expect(secondIssues.location.column, 3);
+
+        final thirdIssues = report.issues.elementAt(2);
+        expect(
+          thirdIssues.memberName,
+          'secondMethod(String value, num number)',
+        );
+        expect(thirdIssues.location.line, 19);
+        expect(thirdIssues.location.column, 3);
+      });
+
       test('should report no issues for a custom class name pattern', () async {
         final config = _createConfig(
           analyzerExcludePatterns: analyzerExcludes,

test/resources/unused_l10n_analyzer/test_i18n.dart

@@ -8,3 +8,14 @@ class TestI18n {
   static String secondMethod(String value, num number) =>
       value + number.toString();
 }
+
+class S {
+  static const String field = 'field'; // LINT
+
+  static String get getter => 'getter';
+
+  static String method(String value) => value; // LINT
+
+  static String secondMethod(String value, num number) => // LINT
+      value + number.toString();
+}

test/resources/unused_l10n_analyzer/unused_l10n_analyzer_example.dart

@@ -2,6 +2,8 @@ import 'test_i18n.dart';
 
 void main() {
   final _ = TestI18n.method('value');
+
+  S.getter;
 }
 
 class SomeClass {