Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Commit d041809

Browse files
orevialOlivier
orevial
and
Olivier
authored
fix: add const to edge insets constructors when appropriate (#972)
Co-authored-by: Olivier <olivier.revial@stack-labs.com>
1 parent 81f521c commit d041809

File tree

2 files changed

+99
-98
lines changed

2 files changed

+99
-98
lines changed

‎lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_correct_edge_insets_constructor/validator.dart‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class _Validator {
4545
}
4646

4747
if (isParamsSame) {
48-
return '${data.className}.all($horizontal)';
48+
return 'const ${data.className}.all($horizontal)';
4949
}
5050

5151
if (horizontal == 0 && vertical != null) {
@@ -80,7 +80,7 @@ class _Validator {
8080
}
8181

8282
if (paramsList.every((element) => element == top && top != null)) {
83-
return '${data.className}.all(${data.params.first.value})';
83+
return 'const ${data.className}.all(${data.params.first.value})';
8484
}
8585

8686
if (left == right && hasLeftParam && top == bottom && hasTopParam) {
@@ -98,7 +98,7 @@ class _Validator {
9898
}
9999

100100
if (paramsList.contains(0)) {
101-
return '${data.className}.only(${[
101+
return 'const ${data.className}.only(${[
102102
if (hasTopParam) 'top: $top',
103103
if (hasBottomParam) 'bottom: $bottom',
104104
if (hasLeftParam && data.className == 'EdgeInsetsDirectional')
@@ -123,7 +123,7 @@ class _Validator {
123123

124124
if (data.params
125125
.every((element) => element.value == data.params.first.value)) {
126-
return '${data.className}.all(${data.params.first.value})';
126+
return 'const ${data.className}.all(${data.params.first.value})';
127127
}
128128

129129
final left = data.params.first.value;
@@ -169,13 +169,14 @@ class _Validator {
169169
params.add('bottom: $bottom');
170170
}
171171

172-
return '${data.className}.only(${params.join(', ')})';
172+
return 'const ${data.className}.only(${params.join(', ')})';
173173
}
174174

175175
return null;
176176
}
177177

178178
String _replaceWithZero() => 'EdgeInsets.zero';
179179

180-
String _replaceWithSymmetric(String? param) => 'EdgeInsets.symmetric($param)';
180+
String _replaceWithSymmetric(String? param) =>
181+
'const EdgeInsets.symmetric($param)';
181182
}

‎test/src/analyzers/lint_analyzer/rules/rules_list/prefer_correct_edge_insets_constructor/prefer_correct_edge_insets_constructor_rule_test.dart‎

Lines changed: 92 additions & 92 deletions
Original file line numberDiff line numberDiff line change
@@ -47,28 +47,28 @@ void main() {
4747
'Prefer using correct EdgeInsets constructor.',
4848
],
4949
replacementComments: [
50-
'Prefer use EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
51-
'Prefer use EdgeInsets.all(10)',
52-
'Prefer use EdgeInsets.symmetric(horizontal: 12, vertical: 10)',
53-
'Prefer use EdgeInsets.symmetric(vertical: 10)',
54-
'Prefer use EdgeInsets.symmetric(horizontal: 10)',
55-
'Prefer use EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
56-
'Prefer use EdgeInsets.all(10.0)',
57-
'Prefer use EdgeInsets.symmetric(horizontal: 12.0, vertical: 10.0)',
58-
'Prefer use EdgeInsets.symmetric(vertical: 10.0)',
59-
'Prefer use EdgeInsets.symmetric(horizontal: 10.0)',
50+
'Prefer use const EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
51+
'Prefer use const EdgeInsets.all(10)',
52+
'Prefer use const EdgeInsets.symmetric(horizontal: 12, vertical: 10)',
53+
'Prefer use const EdgeInsets.symmetric(vertical: 10)',
54+
'Prefer use const EdgeInsets.symmetric(horizontal: 10)',
55+
'Prefer use const EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
56+
'Prefer use const EdgeInsets.all(10.0)',
57+
'Prefer use const EdgeInsets.symmetric(horizontal: 12.0, vertical: 10.0)',
58+
'Prefer use const EdgeInsets.symmetric(vertical: 10.0)',
59+
'Prefer use const EdgeInsets.symmetric(horizontal: 10.0)',
6060
],
6161
replacements: [
62-
'EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
63-
'EdgeInsets.all(10)',
64-
'EdgeInsets.symmetric(horizontal: 12, vertical: 10)',
65-
'EdgeInsets.symmetric(vertical: 10)',
66-
'EdgeInsets.symmetric(horizontal: 10)',
67-
'EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
68-
'EdgeInsets.all(10.0)',
69-
'EdgeInsets.symmetric(horizontal: 12.0, vertical: 10.0)',
70-
'EdgeInsets.symmetric(vertical: 10.0)',
71-
'EdgeInsets.symmetric(horizontal: 10.0)',
62+
'const EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
63+
'const EdgeInsets.all(10)',
64+
'const EdgeInsets.symmetric(horizontal: 12, vertical: 10)',
65+
'const EdgeInsets.symmetric(vertical: 10)',
66+
'const EdgeInsets.symmetric(horizontal: 10)',
67+
'const EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
68+
'const EdgeInsets.all(10.0)',
69+
'const EdgeInsets.symmetric(horizontal: 12.0, vertical: 10.0)',
70+
'const EdgeInsets.symmetric(vertical: 10.0)',
71+
'const EdgeInsets.symmetric(horizontal: 10.0)',
7272
],
7373
locationTexts: [
7474
'const EdgeInsets.only(\n'
@@ -131,28 +131,28 @@ void main() {
131131
'Prefer using correct EdgeInsets constructor.',
132132
],
133133
replacementComments: [
134-
'Prefer use EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
135-
'Prefer use EdgeInsetsDirectional.all(10)',
136-
'Prefer use EdgeInsets.symmetric(horizontal: 12, vertical: 10)',
137-
'Prefer use EdgeInsets.symmetric(vertical: 10)',
138-
'Prefer use EdgeInsets.symmetric(horizontal: 10)',
139-
'Prefer use EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
140-
'Prefer use EdgeInsetsDirectional.all(10.0)',
141-
'Prefer use EdgeInsets.symmetric(horizontal: 12.0, vertical: 10.0)',
142-
'Prefer use EdgeInsets.symmetric(vertical: 10.0)',
143-
'Prefer use EdgeInsets.symmetric(horizontal: 10.0)',
134+
'Prefer use const EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
135+
'Prefer use const EdgeInsetsDirectional.all(10)',
136+
'Prefer use const EdgeInsets.symmetric(horizontal: 12, vertical: 10)',
137+
'Prefer use const EdgeInsets.symmetric(vertical: 10)',
138+
'Prefer use const EdgeInsets.symmetric(horizontal: 10)',
139+
'Prefer use const EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
140+
'Prefer use const EdgeInsetsDirectional.all(10.0)',
141+
'Prefer use const EdgeInsets.symmetric(horizontal: 12.0, vertical: 10.0)',
142+
'Prefer use const EdgeInsets.symmetric(vertical: 10.0)',
143+
'Prefer use const EdgeInsets.symmetric(horizontal: 10.0)',
144144
],
145145
replacements: [
146-
'EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
147-
'EdgeInsetsDirectional.all(10)',
148-
'EdgeInsets.symmetric(horizontal: 12, vertical: 10)',
149-
'EdgeInsets.symmetric(vertical: 10)',
150-
'EdgeInsets.symmetric(horizontal: 10)',
151-
'EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
152-
'EdgeInsetsDirectional.all(10.0)',
153-
'EdgeInsets.symmetric(horizontal: 12.0, vertical: 10.0)',
154-
'EdgeInsets.symmetric(vertical: 10.0)',
155-
'EdgeInsets.symmetric(horizontal: 10.0)',
146+
'const EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
147+
'const EdgeInsetsDirectional.all(10)',
148+
'const EdgeInsets.symmetric(horizontal: 12, vertical: 10)',
149+
'const EdgeInsets.symmetric(vertical: 10)',
150+
'const EdgeInsets.symmetric(horizontal: 10)',
151+
'const EdgeInsets.symmetric(horizontal: 5, vertical: 10)',
152+
'const EdgeInsetsDirectional.all(10.0)',
153+
'const EdgeInsets.symmetric(horizontal: 12.0, vertical: 10.0)',
154+
'const EdgeInsets.symmetric(vertical: 10.0)',
155+
'const EdgeInsets.symmetric(horizontal: 10.0)',
156156
],
157157
locationTexts: [
158158
'const EdgeInsetsDirectional.only(\n'
@@ -214,29 +214,29 @@ void main() {
214214
'Prefer using correct EdgeInsets constructor.',
215215
],
216216
replacementComments: [
217-
'Prefer use EdgeInsets.only(left: 1, top: 1)',
218-
'Prefer use EdgeInsets.all(12)',
219-
'Prefer use EdgeInsets.all(1)',
220-
'Prefer use EdgeInsets.symmetric(horizontal: 3, vertical: 2)',
221-
'Prefer use EdgeInsets.only(left: 3, bottom: 2)',
222-
'Prefer use EdgeInsets.only(left: 1.0, top: 1.0)',
223-
'Prefer use EdgeInsets.all(12.0)',
224-
'Prefer use EdgeInsets.all(1.0)',
225-
'Prefer use EdgeInsets.symmetric(horizontal: 3.0, vertical: 2.0)',
226-
'Prefer use EdgeInsets.only(left: 3.0, bottom: 2.0)',
217+
'Prefer use const EdgeInsets.only(left: 1, top: 1)',
218+
'Prefer use const EdgeInsets.all(12)',
219+
'Prefer use const EdgeInsets.all(1)',
220+
'Prefer use const EdgeInsets.symmetric(horizontal: 3, vertical: 2)',
221+
'Prefer use const EdgeInsets.only(left: 3, bottom: 2)',
222+
'Prefer use const EdgeInsets.only(left: 1.0, top: 1.0)',
223+
'Prefer use const EdgeInsets.all(12.0)',
224+
'Prefer use const EdgeInsets.all(1.0)',
225+
'Prefer use const EdgeInsets.symmetric(horizontal: 3.0, vertical: 2.0)',
226+
'Prefer use const EdgeInsets.only(left: 3.0, bottom: 2.0)',
227227
'Prefer use EdgeInsets.zero',
228228
],
229229
replacements: [
230-
'EdgeInsets.only(left: 1, top: 1)',
231-
'EdgeInsets.all(12)',
232-
'EdgeInsets.all(1)',
233-
'EdgeInsets.symmetric(horizontal: 3, vertical: 2)',
234-
'EdgeInsets.only(left: 3, bottom: 2)',
235-
'EdgeInsets.only(left: 1.0, top: 1.0)',
236-
'EdgeInsets.all(12.0)',
237-
'EdgeInsets.all(1.0)',
238-
'EdgeInsets.symmetric(horizontal: 3.0, vertical: 2.0)',
239-
'EdgeInsets.only(left: 3.0, bottom: 2.0)',
230+
'const EdgeInsets.only(left: 1, top: 1)',
231+
'const EdgeInsets.all(12)',
232+
'const EdgeInsets.all(1)',
233+
'const EdgeInsets.symmetric(horizontal: 3, vertical: 2)',
234+
'const EdgeInsets.only(left: 3, bottom: 2)',
235+
'const EdgeInsets.only(left: 1.0, top: 1.0)',
236+
'const EdgeInsets.all(12.0)',
237+
'const EdgeInsets.all(1.0)',
238+
'const EdgeInsets.symmetric(horizontal: 3.0, vertical: 2.0)',
239+
'const EdgeInsets.only(left: 3.0, bottom: 2.0)',
240240
'EdgeInsets.zero',
241241
],
242242
locationTexts: [
@@ -277,29 +277,29 @@ void main() {
277277
'Prefer using correct EdgeInsets constructor.',
278278
],
279279
replacementComments: [
280-
'Prefer use EdgeInsetsDirectional.only(start: 1, top: 1)',
281-
'Prefer use EdgeInsetsDirectional.all(12)',
282-
'Prefer use EdgeInsetsDirectional.all(1)',
283-
'Prefer use EdgeInsets.symmetric(horizontal: 3, vertical: 2)',
284-
'Prefer use EdgeInsetsDirectional.only(start: 3, bottom: 2)',
285-
'Prefer use EdgeInsetsDirectional.only(start: 1.0, top: 1.0)',
286-
'Prefer use EdgeInsetsDirectional.all(12.0)',
287-
'Prefer use EdgeInsetsDirectional.all(1.0)',
288-
'Prefer use EdgeInsets.symmetric(horizontal: 3.0, vertical: 2.0)',
289-
'Prefer use EdgeInsetsDirectional.only(start: 3.0, bottom: 2.0)',
280+
'Prefer use const EdgeInsetsDirectional.only(start: 1, top: 1)',
281+
'Prefer use const EdgeInsetsDirectional.all(12)',
282+
'Prefer use const EdgeInsetsDirectional.all(1)',
283+
'Prefer use const EdgeInsets.symmetric(horizontal: 3, vertical: 2)',
284+
'Prefer use const EdgeInsetsDirectional.only(start: 3, bottom: 2)',
285+
'Prefer use const EdgeInsetsDirectional.only(start: 1.0, top: 1.0)',
286+
'Prefer use const EdgeInsetsDirectional.all(12.0)',
287+
'Prefer use const EdgeInsetsDirectional.all(1.0)',
288+
'Prefer use const EdgeInsets.symmetric(horizontal: 3.0, vertical: 2.0)',
289+
'Prefer use const EdgeInsetsDirectional.only(start: 3.0, bottom: 2.0)',
290290
'Prefer use EdgeInsets.zero',
291291
],
292292
replacements: [
293-
'EdgeInsetsDirectional.only(start: 1, top: 1)',
294-
'EdgeInsetsDirectional.all(12)',
295-
'EdgeInsetsDirectional.all(1)',
296-
'EdgeInsets.symmetric(horizontal: 3, vertical: 2)',
297-
'EdgeInsetsDirectional.only(start: 3, bottom: 2)',
298-
'EdgeInsetsDirectional.only(start: 1.0, top: 1.0)',
299-
'EdgeInsetsDirectional.all(12.0)',
300-
'EdgeInsetsDirectional.all(1.0)',
301-
'EdgeInsets.symmetric(horizontal: 3.0, vertical: 2.0)',
302-
'EdgeInsetsDirectional.only(start: 3.0, bottom: 2.0)',
293+
'const EdgeInsetsDirectional.only(start: 1, top: 1)',
294+
'const EdgeInsetsDirectional.all(12)',
295+
'const EdgeInsetsDirectional.all(1)',
296+
'const EdgeInsets.symmetric(horizontal: 3, vertical: 2)',
297+
'const EdgeInsetsDirectional.only(start: 3, bottom: 2)',
298+
'const EdgeInsetsDirectional.only(start: 1.0, top: 1.0)',
299+
'const EdgeInsetsDirectional.all(12.0)',
300+
'const EdgeInsetsDirectional.all(1.0)',
301+
'const EdgeInsets.symmetric(horizontal: 3.0, vertical: 2.0)',
302+
'const EdgeInsetsDirectional.only(start: 3.0, bottom: 2.0)',
303303
'EdgeInsets.zero',
304304
],
305305
locationTexts: [
@@ -336,20 +336,20 @@ void main() {
336336
'Prefer using correct EdgeInsets constructor.',
337337
],
338338
replacementComments: [
339-
'Prefer use EdgeInsets.all(10)',
340-
'Prefer use EdgeInsets.symmetric(horizontal: 10)',
341-
'Prefer use EdgeInsets.symmetric(vertical: 10)',
342-
'Prefer use EdgeInsets.all(10.0)',
343-
'Prefer use EdgeInsets.symmetric(horizontal: 10.0)',
344-
'Prefer use EdgeInsets.symmetric(vertical: 10.0)',
339+
'Prefer use const EdgeInsets.all(10)',
340+
'Prefer use const EdgeInsets.symmetric(horizontal: 10)',
341+
'Prefer use const EdgeInsets.symmetric(vertical: 10)',
342+
'Prefer use const EdgeInsets.all(10.0)',
343+
'Prefer use const EdgeInsets.symmetric(horizontal: 10.0)',
344+
'Prefer use const EdgeInsets.symmetric(vertical: 10.0)',
345345
],
346346
replacements: [
347-
'EdgeInsets.all(10)',
348-
'EdgeInsets.symmetric(horizontal: 10)',
349-
'EdgeInsets.symmetric(vertical: 10)',
350-
'EdgeInsets.all(10.0)',
351-
'EdgeInsets.symmetric(horizontal: 10.0)',
352-
'EdgeInsets.symmetric(vertical: 10.0)',
347+
'const EdgeInsets.all(10)',
348+
'const EdgeInsets.symmetric(horizontal: 10)',
349+
'const EdgeInsets.symmetric(vertical: 10)',
350+
'const EdgeInsets.all(10.0)',
351+
'const EdgeInsets.symmetric(horizontal: 10.0)',
352+
'const EdgeInsets.symmetric(vertical: 10.0)',
353353
],
354354
locationTexts: [
355355
'const EdgeInsets.symmetric(horizontal: 10, vertical: 10)',

0 commit comments

Comments
 (0)