revert fix: correctly split exclude path

This reverts commit 3397933

Author: dkrutskikh

CHANGELOG.md

@@ -6,7 +6,6 @@
 * fix: add check for supertypes for [`avoid-non-null-assertions`](https://dartcodemetrics.dev/docs/rules/common/avoid-non-null-assertion) rule.
 * fix: cover more cases in [`prefer-immediate-return`](https://dartcodemetrics.dev/docs/rules/common/prefer-immediate-return) rule
 * fix: support index expressions for [`no-magic-number`](https://dartcodemetrics.dev/docs/rules/common/no-magic-number) rule.
-* fix: correctly split exclude path
 * chore: restrict `analyzer` version to `>=2.4.0 <3.4.0`.
 * fix: correctly handle nullable types of collections for [`avoid-collection-methods-with-unrelated-types`](https://dartcodemetrics.dev/docs/rules/common/avoid-collection-methods-with-unrelated-types)
 

lib/src/analyzers/lint_analyzer/lint_config.dart

@@ -1,7 +1,6 @@
 import '../../cli/models/parsed_arguments.dart';
 import '../../config_builder/analysis_options_utils.dart';
 import '../../config_builder/models/analysis_options.dart';
-import '../../utils/exclude_utils.dart';
 import 'metrics/metrics_factory.dart';
 
 /// Represents raw lint config which can be merged with other raw configs.
@@ -40,7 +39,8 @@ class LintConfig {
 
   /// Creates the config from cli [arguments].
   factory LintConfig.fromArgs(ParsedArguments arguments) => LintConfig(
-        excludePatterns: extractExcludes(arguments.excludePath),
+        excludePatterns:
+            arguments.excludePath.isNotEmpty ? [arguments.excludePath] : [],
         excludeForMetricsPatterns: const [],
         metrics: {
           for (final metric in getMetrics(config: {}))

lib/src/analyzers/unused_code_analyzer/unused_code_config.dart

@@ -1,5 +1,4 @@
 import '../../config_builder/models/analysis_options.dart';
-import '../../utils/exclude_utils.dart';
 
 /// Represents raw unused code config which can be merged with other raw configs.
 class UnusedCodeConfig {
@@ -24,11 +23,11 @@ class UnusedCodeConfig {
 
   /// Creates the config from cli args.
   factory UnusedCodeConfig.fromArgs(
-    String excludePath, {
+    Iterable<String> excludePatterns, {
     required bool isMonorepo,
   }) =>
       UnusedCodeConfig(
-        excludePatterns: extractExcludes(excludePath),
+        excludePatterns: excludePatterns,
         analyzerExcludePatterns: const [],
         isMonorepo: isMonorepo,
       );

lib/src/analyzers/unused_files_analyzer/unused_files_config.dart

@@ -1,5 +1,4 @@
 import '../../config_builder/models/analysis_options.dart';
-import '../../utils/exclude_utils.dart';
 
 /// Represents raw unused files config which can be merged with other raw configs.
 class UnusedFilesConfig {
@@ -24,11 +23,11 @@ class UnusedFilesConfig {
 
   /// Creates the config from cli args.
   factory UnusedFilesConfig.fromArgs(
-    String excludePath, {
+    Iterable<String> excludePatterns, {
     required bool isMonorepo,
   }) =>
       UnusedFilesConfig(
-        excludePatterns: extractExcludes(excludePath),
+        excludePatterns: excludePatterns,
         analyzerExcludePatterns: const [],
         isMonorepo: isMonorepo,
       );

lib/src/analyzers/unused_l10n_analyzer/unused_l10n_config.dart

@@ -1,5 +1,4 @@
 import '../../config_builder/models/analysis_options.dart';
-import '../../utils/exclude_utils.dart';
 
 /// Represents raw unused files config which can be merged with other raw configs.
 class UnusedL10nConfig {
@@ -26,11 +25,11 @@ class UnusedL10nConfig {
 
   /// Creates the config from cli args.
   factory UnusedL10nConfig.fromArgs(
-    String excludePath,
+    Iterable<String> excludePatterns,
     String classPattern,
   ) =>
       UnusedL10nConfig(
-        excludePatterns: extractExcludes(excludePath),
+        excludePatterns: excludePatterns,
         analyzerExcludePatterns: const [],
         classPattern: classPattern,
       );

lib/src/cli/commands/check_unused_code_command.dart

@@ -35,7 +35,7 @@ class CheckUnusedCodeCommand extends BaseCommand {
     final noCongratulate = argResults[FlagNames.noCongratulate] as bool;
 
     final config = ConfigBuilder.getUnusedCodeConfigFromArgs(
-      excludePath,
+      [excludePath],
       isMonorepo: isMonorepo,
     );
 

lib/src/cli/commands/check_unused_files_command.dart

@@ -36,7 +36,7 @@ class CheckUnusedFilesCommand extends BaseCommand {
     final deleteFiles = argResults[FlagNames.deleteFiles] as bool;
 
     final config = ConfigBuilder.getUnusedFilesConfigFromArgs(
-      excludePath,
+      [excludePath],
       isMonorepo: isMonorepo,
     );
 

lib/src/cli/commands/check_unused_l10n_command.dart

@@ -37,7 +37,7 @@ class CheckUnusedL10nCommand extends BaseCommand {
     final folders = argResults.rest;
 
     final config = ConfigBuilder.getUnusedL10nConfigFromArgs(
-      excludePath,
+      [excludePath],
       classPattern,
     );
 

lib/src/config_builder/config_builder.dart

@@ -68,12 +68,12 @@ class ConfigBuilder {
     );
   }
 
-  /// Creates a raw unused files config from given [excludePath].
+  /// Creates a raw unused files config from given [excludePatterns].
   static UnusedFilesConfig getUnusedFilesConfigFromArgs(
-    String excludePath, {
+    Iterable<String> excludePatterns, {
     required bool isMonorepo,
   }) =>
-      UnusedFilesConfig.fromArgs(excludePath, isMonorepo: isMonorepo);
+      UnusedFilesConfig.fromArgs(excludePatterns, isMonorepo: isMonorepo);
 
   /// Creates a raw unused files config from given [options].
   static UnusedFilesConfig getUnusedFilesConfigFromOption(
@@ -91,12 +91,12 @@ class ConfigBuilder {
         prepareExcludes(config.analyzerExcludePatterns, rootPath),
       );
 
-  /// Creates a raw unused code config from given [excludePath].
+  /// Creates a raw unused code config from given [excludePatterns].
   static UnusedCodeConfig getUnusedCodeConfigFromArgs(
-    String excludePath, {
+    Iterable<String> excludePatterns, {
     required bool isMonorepo,
   }) =>
-      UnusedCodeConfig.fromArgs(excludePath, isMonorepo: isMonorepo);
+      UnusedCodeConfig.fromArgs(excludePatterns, isMonorepo: isMonorepo);
 
   /// Creates a raw unused code config from given [options].
   static UnusedCodeConfig getUnusedCodeConfigFromOption(
@@ -114,12 +114,12 @@ class ConfigBuilder {
         prepareExcludes(config.analyzerExcludePatterns, rootPath),
       );
 
-  /// Creates a raw unused localization config from given [excludePath] and [classPattern].
+  /// Creates a raw unused localization config from given [excludePatterns] and [classPattern].
   static UnusedL10nConfig getUnusedL10nConfigFromArgs(
-    String excludePath,
+    Iterable<String> excludePatterns,
     String classPattern,
   ) =>
-      UnusedL10nConfig.fromArgs(excludePath, classPattern);
+      UnusedL10nConfig.fromArgs(excludePatterns, classPattern);
 
   /// Creates a raw unused localization config from given [options].
   static UnusedL10nConfig getUnusedL10nConfigFromOption(

lib/src/utils/exclude_utils.dart

@@ -15,7 +15,3 @@ Iterable<Glob> prepareExcludes(
         .map((exclude) =>
             Glob(p.normalize(p.join(root, exclude)).replaceAll(r'\', '/')))
         .toList();
-
-Iterable<String> extractExcludes(String excludePath) => excludePath.isNotEmpty
-    ? excludePath.split(',').map((path) => path.trim())
-    : [];