fix: add static byte store to reuse between plugin instances (#676)

* fix: add static bytestore to reuse between plugin instances

* chore: update changelog

Author: incendial

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+* fix: move byte store out of driver creation to reuse it between multiple plugins.
 * fix: add `monorepo` flag for `check-unused-code` command.
 * fix: ignore a class usage inside `State<T>` for `check-unused-code` command.
 * fix: correctly handle variables declaration for `check-unused-code` command.

lib/src/analyzer_plugin/analyzer_plugin.dart

@@ -2,16 +2,16 @@
 
 import 'dart:async';
 
-import 'package:analyzer/dart/analysis/context_builder.dart';
 import 'package:analyzer/dart/analysis/context_locator.dart';
 import 'package:analyzer/dart/analysis/results.dart';
 import 'package:analyzer/file_system/file_system.dart';
+import 'package:analyzer/file_system/physical_file_system.dart';
 // ignore: implementation_imports
 import 'package:analyzer/src/analysis_options/analysis_options_provider.dart';
 // ignore: implementation_imports
-import 'package:analyzer/src/dart/analysis/driver.dart';
+import 'package:analyzer/src/dart/analysis/context_builder.dart';
 // ignore: implementation_imports
-import 'package:analyzer/src/dart/analysis/driver_based_analysis_context.dart';
+import 'package:analyzer/src/dart/analysis/driver.dart';
 import 'package:analyzer_plugin/plugin/plugin.dart';
 import 'package:analyzer_plugin/protocol/protocol_generated.dart' as plugin;
 
@@ -21,9 +21,12 @@ import '../analyzers/lint_analyzer/metrics/metrics_list/number_of_parameters_met
 import '../analyzers/lint_analyzer/metrics/metrics_list/source_lines_of_code/source_lines_of_code_metric.dart';
 import '../config_builder/config_builder.dart';
 import '../config_builder/models/analysis_options.dart';
+import '../utils/analyzer_utils.dart';
 import '../utils/yaml_utils.dart';
 import 'analyzer_plugin_utils.dart';
 
+final _byteStore = createByteStore(PhysicalResourceProvider.INSTANCE);
+
 class AnalyzerPlugin extends ServerPlugin {
   static const _analyzer = LintAnalyzer();
 
@@ -72,9 +75,11 @@ class AnalyzerPlugin extends ServerPlugin {
       throw error;
     }
 
-    final builder = ContextBuilder(resourceProvider: resourceProvider);
-    final context = builder.createContext(contextRoot: locator.first)
-        as DriverBasedAnalysisContext;
+    final builder = ContextBuilderImpl(resourceProvider: resourceProvider);
+    final context = builder.createContext(
+      contextRoot: locator.first,
+      byteStore: _byteStore,
+    );
     final dartDriver = context.driver;
     final config = _createConfig(dartDriver, rootPath);
 

lib/src/utils/analyzer_utils.dart

@@ -22,7 +22,7 @@ AnalysisContextCollection createAnalysisContextCollection(
     includedPaths:
         folders.map((path) => normalize(join(rootFolder, path))).toList(),
     resourceProvider: resourceProvider,
-    byteStore: _createByteStore(resourceProvider),
+    byteStore: createByteStore(resourceProvider),
   );
 }
 
@@ -44,7 +44,7 @@ Set<String> getFilePaths(
 
 /// If the state location can be accessed, return the file byte store,
 /// otherwise return the memory byte store.
-ByteStore _createByteStore(PhysicalResourceProvider resourceProvider) {
+ByteStore createByteStore(PhysicalResourceProvider resourceProvider) {
   const M = 1024 * 1024 /*1 MiB*/;
   const G = 1024 * 1024 * 1024 /*1 GiB*/;