fix: correctly handle prefixed enums and static instance fields for prefer-moving-to-variable (#1123)

* test: add test cases

* fix: correctly handle prefixed enums and static instance fields for prefer-moving-to-variable

* test: restore test example

Author: incendial

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+* fix: correctly handle prefixed enums and static instance fields for [`prefer-moving-to-variable`](https://dartcodemetrics.dev/docs/rules/common/prefer-moving-to-variable).
 * feat: add static code diagnostic [`prefer-provide-intl-description`](https://dartcodemetrics.dev/docs/rules/intl/prefer-provide-intl-description).
 * feat: exclude `.freezed.dart` files by default.
 * fix: handle try and switch statements for [`use-setstate-synchronously`](https://dartcodemetrics.dev/docs/rules/flutter/use-setstate-synchronously)

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_moving_to_variable/prefer_moving_to_variable_rule.dart

@@ -2,6 +2,7 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
+import 'package:analyzer/dart/element/element.dart';
 
 import '../../../../../utils/node_utils.dart';
 import '../../../lint_utils.dart';

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_moving_to_variable/visitor.dart

@@ -40,10 +40,18 @@ class _BlockVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitPropertyAccess(PropertyAccess node) {
-    if (node.target == null) {
+    final target = node.target;
+    if (target == null) {
       return;
     }
 
+    if (target is PrefixedIdentifier) {
+      final element = target.identifier.staticElement;
+      if (element is EnumElement || element is ClassElement) {
+        return;
+      }
+    }
+
     final hasDuplicates = _checkForDuplicates(node, node.target);
     if (!hasDuplicates) {
       super.visitPropertyAccess(node);

test/src/analyzers/lint_analyzer/rules/rules_list/prefer_moving_to_variable/examples/example.dart

@@ -56,3 +56,18 @@ class Theme {
 }
 
 String getValue() => 'hello';
+
+enum SomeValue {
+  firstValue,
+  secondValue,
+  entry1,
+  entry2,
+}
+
+class SomeClass {
+  static final value = '10';
+
+  final field = 11;
+}
+
+final instance = SomeClass();

test/src/analyzers/lint_analyzer/rules/rules_list/prefer_moving_to_variable/examples/generics_example.dart

@@ -12,3 +12,8 @@ class GetIt {
 
   T call<T extends Object>() => get<T>;
 }
+
+enum AnotherEnum {
+  firstValue,
+  anotherValue,
+}

test/src/analyzers/lint_analyzer/rules/rules_list/prefer_moving_to_variable/examples/prefix_example.dart

@@ -0,0 +1,19 @@
+import 'example.dart' as prefix;
+import 'generics_example.dart';
+
+void main() {
+  AnotherEnum.anotherValue;
+  AnotherEnum.anotherValue;
+  AnotherEnum.firstValue;
+
+  prefix.SomeValue.firstValue;
+  prefix.SomeValue.firstValue;
+  prefix.SomeValue.secondValue;
+
+  prefix.SomeClass.value;
+  prefix.SomeClass.value;
+  prefix.instance.field;
+
+  print(prefix.SomeValue.entry1);
+  print(prefix.SomeValue.entry2);
+}

test/src/analyzers/lint_analyzer/rules/rules_list/prefer_moving_to_variable/prefer_moving_to_variable_rule_test.dart

@@ -15,6 +15,8 @@ const _cascadeExamplePath =
     'prefer_moving_to_variable/examples/cascade_example.dart';
 const _genericsExamplePath =
     'prefer_moving_to_variable/examples/generics_example.dart';
+const _prefixExamplePath =
+    'prefer_moving_to_variable/examples/prefix_example.dart';
 
 void main() {
   group('PreferMovingToVariableRule', () {
@@ -222,6 +224,13 @@ void main() {
       RuleTestHelper.verifyNoIssues(issues);
     });
 
+    test('reports no issues for prefix imports', () async {
+      final unit = await RuleTestHelper.resolveFromFile(_prefixExamplePath);
+      final issues = PreferMovingToVariableRule().check(unit);
+
+      RuleTestHelper.verifyNoIssues(issues);
+    });
+
     test('reports issues with custom config', () async {
       final unit = await RuleTestHelper.resolveFromFile(_examplePath);
       final config = {