fix: added parameter constant check in avoid-border-all. (#723)

* fix: added parameter constant check in `avoid-border-all`.

* fix: removed extra code

Author: Konoshenko Vlad

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 * feat: add static code diagnostic `avoid-collection-methods-with-unrelated-types`
+* fix: added parameter constant check in `avoid-border-all`.
 
 ## 4.11.0
 

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_border_all/avoid_border_all_rule.dart

@@ -2,6 +2,7 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
+import 'package:analyzer/dart/element/element.dart';
 
 import '../../../../../utils/node_utils.dart';
 import '../../../lint_utils.dart';

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_border_all/visitor.dart

@@ -15,7 +15,25 @@ class _Visitor extends RecursiveAstVisitor<void> {
     if (expression.staticType?.getDisplayString(withNullability: true) ==
             _className &&
         expression.constructorName.name?.name == _borderRadiusConstructorName) {
-      _expressions.add(expression);
+      var isAllConst = true;
+
+      for (final argument in expression.argumentList.arguments) {
+        final arg = (argument as NamedExpression).expression;
+        if (arg is Literal) {
+          continue;
+        } else if (arg is MethodInvocation || arg is ConditionalExpression) {
+          isAllConst = false;
+        } else if (arg is SimpleIdentifier) {
+          final element = arg.staticElement;
+          if (element is PropertyAccessorElement && !element.variable.isConst) {
+            isAllConst = false;
+          }
+        }
+      }
+
+      if (isAllConst) {
+        _expressions.add(expression);
+      }
     }
   }
 }

test/src/analyzers/lint_analyzer/rules/rules_list/avoid_border_all/examples/example.dart

@@ -20,7 +20,33 @@ class MyWidget extends StatelessWidget {
             style: BorderStyle.none,
           ),
         ), // LINT
+        Container(
+          border: Border.all(
+            color: const Color(0),
+            width: foo(),
+            style: BorderStyle.none,
+          ),
+        ),
+        Container(
+          border: Border.all(
+            color: const Color(0),
+            width: someBool ? 1 : 0,
+            style: BorderStyle.none,
+          ),
+        ),
+        Container(
+          border: Border.all(
+            color: const Color(0),
+            width: someInt,
+            style: BorderStyle.none,
+          ),
+        ),
       ]);
+
+  var someBool = false;
+  var someInt = 5;
+
+  double foo() => 20.0;
 }
 
 class Border {