feat: support boolean literals removal for prefer-conditional-expressions auto-fix (#1096)

Author: incendial

CHANGELOG.md

@@ -6,6 +6,7 @@
 * feat: add static code diagnostic [`avoid-double-slash-imports`](https://dartcodemetrics.dev/docs/rules/common/avoid-double-slash-imports).
 * feat: add static code diagnostic [`prefer-using-list-view`](https://dartcodemetrics.dev/docs/rules/flutter/prefer-using-list-view).
 * feat: add static code diagnostic [`avoid-unnecessary-conditionals`](https://dartcodemetrics.dev/docs/rules/common/avoid-unnecessary-conditionals).
+* feat: support boolean literals removal for [`prefer-conditional-expressions`](https://dartcodemetrics.dev/docs/rules/common/prefer-conditional-expressions) auto-fix.
 
 ## 5.1.0
 

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_conditional_expressions/prefer_conditional_expressions_rule.dart

@@ -75,19 +75,34 @@ class PreferConditionalExpressionsRule extends CommonRule {
       return _isAssignmentOperatorNotEq(thenStatementOperator) &&
               _isAssignmentOperatorNotEq(elseStatementOperator)
           ? '$condition ? ${thenStatement.leftHandSide} ${thenStatementOperator.stringValue} $firstExpression : ${thenStatement.leftHandSide} ${elseStatementOperator.stringValue} $secondExpression;'
-          : '$target = $condition ? $firstExpression : $secondExpression;';
+          : '$target = ${_createCorrectionForLiterals(condition, firstExpression, secondExpression)}';
     }
 
     if (thenStatement is ReturnStatement && elseStatement is ReturnStatement) {
       final firstExpression = thenStatement.expression;
       final secondExpression = elseStatement.expression;
 
-      return 'return $condition ? $firstExpression : $secondExpression;';
+      return 'return ${_createCorrectionForLiterals(condition, firstExpression, secondExpression)}';
     }
 
     return null;
   }
 
+  String _createCorrectionForLiterals(
+    Expression condition,
+    Expression? firstExpression,
+    Expression? secondExpression,
+  ) {
+    if (firstExpression is BooleanLiteral &&
+        secondExpression is BooleanLiteral) {
+      final isInverted = !firstExpression.value && secondExpression.value;
+
+      return '${isInverted ? "!" : ""}$condition;';
+    }
+
+    return '$condition ? $firstExpression : $secondExpression;';
+  }
+
   bool _isAssignmentOperatorNotEq(TokenType token) =>
       token.isAssignmentOperator && token != TokenType.EQ;
 }

test/src/analyzers/lint_analyzer/rules/rules_list/prefer_conditional_expressions/examples/example.dart

@@ -173,4 +173,12 @@ int newCase() {
   } else {
     value /= 5;
   }
+
+  // LINT
+  bool val = false;
+  if (true) {
+    val = true;
+  } else {
+    val = false;
+  }
 }

test/src/analyzers/lint_analyzer/rules/rules_list/prefer_conditional_expressions/prefer_conditional_expressions_rule_test.dart

@@ -25,21 +25,8 @@ void main() {
 
       RuleTestHelper.verifyIssues(
         issues: issues,
-        startLines: [
-          11,
-          30,
-          45,
-          51,
-          58,
-          64,
-          93,
-          109,
-          150,
-          157,
-          164,
-          171,
-        ],
-        startColumns: [3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3],
+        startLines: [11, 30, 45, 51, 58, 64, 93, 109, 150, 157, 164, 171, 179],
+        startColumns: [3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3],
         locationTexts: [
           'if (a == 3) {\n'
               '    a = 2;\n'
@@ -97,6 +84,11 @@ void main() {
               '  } else {\n'
               '    value /= 5;\n'
               '  }',
+          'if (true) {\n'
+              '    val = true;\n'
+              '  } else {\n'
+              '    val = false;\n'
+              '  }',
         ],
         messages: [
           'Prefer conditional expression.',
@@ -111,6 +103,7 @@ void main() {
           'Prefer conditional expression.',
           'Prefer conditional expression.',
           'Prefer conditional expression.',
+          'Prefer conditional expression.',
         ],
         replacements: [
           'a = a == 3 ? 2 : 3;',
@@ -125,6 +118,7 @@ void main() {
           'cond ? value -= delta : value += delta;',
           'cond ? value -= 2 : value += 5;',
           'cond ? value *= 2 : value /= 5;',
+          'val = true;',
         ],
         replacementComments: [
           'Convert to conditional expression.',
@@ -139,6 +133,7 @@ void main() {
           'Convert to conditional expression.',
           'Convert to conditional expression.',
           'Convert to conditional expression.',
+          'Convert to conditional expression.',
         ],
       );
     });