fix: make avoid-border-all not report errors on final variables (#988)

Author: Ascenio

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_border_all/visitor.dart

@@ -29,6 +29,8 @@ class _Visitor extends RecursiveAstVisitor<void> {
           final element = arg.staticElement;
           if (element is PropertyAccessorElement && !element.variable.isConst) {
             isAllConst = false;
+          } else if (element is VariableElement && !element.isConst) {
+            isAllConst = false;
           }
         }
       }

test/src/analyzers/lint_analyzer/rules/rules_list/avoid_border_all/avoid_border_all_rule_test.dart

@@ -5,6 +5,8 @@ import 'package:test/test.dart';
 import '../../../../../helpers/rule_test_helper.dart';
 
 const _examplePath = 'avoid_border_all/examples/example.dart';
+const _exampleWithVariablesPath =
+    'avoid_border_all/examples/example_with_variables..dart';
 
 void main() {
   group('AvoidBorderAllRule', () {
@@ -62,5 +64,14 @@ void main() {
         ],
       );
     });
+
+    test('does not report a issue when final variable is used as argument',
+        () async {
+      final unit =
+          await RuleTestHelper.resolveFromFile(_exampleWithVariablesPath);
+      final issues = AvoidBorderAllRule().check(unit);
+
+      RuleTestHelper.verifyNoIssues(issues);
+    });
   });
 }

test/src/analyzers/lint_analyzer/rules/rules_list/avoid_border_all/examples/example_with_final_variables.dart

@@ -0,0 +1,23 @@
+import 'package:flutter/material.dart';
+
+void main() {
+  runApp(const MyApp());
+}
+
+class MyApp extends StatelessWidget {
+  const MyApp({Key? key}) : super(key: key);
+
+  @override
+  Widget build(BuildContext context) {
+    final boolean = MediaQuery.of(context).size.width > 300;
+    final aLocalColor = boolean ? Colors.red : Colors.black;
+
+    return MaterialApp(
+      home: Container(
+        decoration: BoxDecoration(
+          border: Border.all(color: aLocalColor),
+        ),
+      ),
+    );
+  }
+}