chore: remove @immutable annotation from code. (#652)

dkrutskikh · web-flow · commit 8a7319c16d4e · 2022-01-17T20:41:21.000+03:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 * feat: support excludes for a separate anti-pattern.
 * chore: restrict `analyzer` version to `>=2.4.0 <3.2.0`.
 * feat: ignore private members for `check-unused-l10n` command.
+* chore: remove `@immutable` annotation from code.
 
 ## 4.9.1
 
diff --git a/lib/src/analyzers/lint_analyzer/lint_analysis_config.dart b/lib/src/analyzers/lint_analyzer/lint_analysis_config.dart
@@ -1,13 +1,11 @@
 import 'package:glob/glob.dart';
-import 'package:meta/meta.dart';
 
 import 'anti_patterns/models/pattern.dart';
 import 'metrics/models/metric.dart';
 import 'rules/models/rule.dart';
 
 /// Represents converted lint config which contains parsed entities.
 
-@immutable
 class LintAnalysisConfig {
   final Iterable<Glob> globalExcludes;
   final Iterable<Rule> codeRules;
diff --git a/lib/src/analyzers/lint_analyzer/lint_config.dart b/lib/src/analyzers/lint_analyzer/lint_config.dart
@@ -1,12 +1,9 @@
-import 'package:meta/meta.dart';
-
 import '../../cli/models/parsed_arguments.dart';
 import '../../config_builder/analysis_options_utils.dart';
 import '../../config_builder/models/analysis_options.dart';
 import 'metrics/metrics_factory.dart';
 
 /// Represents raw lint config which can be merged with other raw configs.
-@immutable
 class LintConfig {
   final Iterable<String> excludePatterns;
   final Iterable<String> excludeForMetricsPatterns;
diff --git a/lib/src/analyzers/lint_analyzer/metrics/models/metric_computation_result.dart b/lib/src/analyzers/lint_analyzer/metrics/models/metric_computation_result.dart
@@ -1,9 +1,6 @@
-import 'package:meta/meta.dart';
-
 import '../../models/context_message.dart';
 
 /// An internal model for representing a value computed by a metric.
-@immutable
 class MetricComputationResult<T> {
   /// The actual value computed by the metric.
   final T value;
diff --git a/lib/src/analyzers/lint_analyzer/metrics/models/metric_documentation.dart b/lib/src/analyzers/lint_analyzer/metrics/models/metric_documentation.dart
@@ -1,9 +1,6 @@
-import 'package:meta/meta.dart';
-
 import '../../models/entity_type.dart';
 
 /// Represents any metric documentation.
-@immutable
 class MetricDocumentation {
   /// The name of the metric.
   final String name;
diff --git a/lib/src/analyzers/lint_analyzer/metrics/models/metric_value.dart b/lib/src/analyzers/lint_analyzer/metrics/models/metric_value.dart
@@ -1,11 +1,8 @@
-import 'package:meta/meta.dart';
-
 import '../../models/context_message.dart';
 import 'metric_documentation.dart';
 import 'metric_value_level.dart';
 
 /// Represents a value computed by the metric.
-@immutable
 class MetricValue<T> {
   /// The id of the computed metric.
   final String metricsId;
diff --git a/lib/src/analyzers/lint_analyzer/models/context_message.dart b/lib/src/analyzers/lint_analyzer/models/context_message.dart
@@ -1,8 +1,6 @@
-import 'package:meta/meta.dart';
 import 'package:source_span/source_span.dart';
 
 /// Represents a message with a relevant information associated with a diagnostic.
-@immutable
 class ContextMessage {
   /// The message to be displayed to the user.
   final String message;
diff --git a/lib/src/analyzers/lint_analyzer/models/issue.dart b/lib/src/analyzers/lint_analyzer/models/issue.dart
@@ -1,11 +1,9 @@
-import 'package:meta/meta.dart';
 import 'package:source_span/source_span.dart';
 
 import 'replacement.dart';
 import 'severity.dart';
 
 /// Represents an issue detected by the analysis rule.
-@immutable
 class Issue {
   /// The id of the rule associated with this issue.
   final String ruleId;
diff --git a/lib/src/analyzers/lint_analyzer/models/lint_file_report.dart b/lib/src/analyzers/lint_analyzer/models/lint_file_report.dart
@@ -1,11 +1,8 @@
-import 'package:meta/meta.dart';
-
 import '../../../reporters/models/file_report.dart';
 import 'issue.dart';
 import 'report.dart';
 
 /// Represents the metrics report collected for a file.
-@immutable
 class LintFileReport implements FileReport {
   /// The path to the target file.
   @override
diff --git a/lib/src/analyzers/lint_analyzer/models/replacement.dart b/lib/src/analyzers/lint_analyzer/models/replacement.dart
@@ -1,7 +1,4 @@
-import 'package:meta/meta.dart';
-
 /// Represents a single change.
-@immutable
 class Replacement {
   /// The human-readable description of the change to be applied.
   final String comment;
diff --git a/lib/src/analyzers/lint_analyzer/models/report.dart b/lib/src/analyzers/lint_analyzer/models/report.dart
@@ -1,13 +1,11 @@
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:collection/collection.dart';
-import 'package:meta/meta.dart';
 import 'package:source_span/source_span.dart';
 
 import '../metrics/models/metric_value.dart';
 import '../metrics/models/metric_value_level.dart';
 
 /// Represents a metrics report collected for an entity.
-@immutable
 class Report {
   /// The source code location of the target entity.
   final SourceSpan location;
diff --git a/lib/src/analyzers/lint_analyzer/models/scoped_class_declaration.dart b/lib/src/analyzers/lint_analyzer/models/scoped_class_declaration.dart
@@ -1,10 +1,8 @@
 import 'package:analyzer/dart/ast/ast.dart';
-import 'package:meta/meta.dart';
 
 import 'class_type.dart';
 
 /// Represents a declaration of a class / mixin / extension.
-@immutable
 class ScopedClassDeclaration {
   /// The type of the declared class entity.
   final ClassType type;
diff --git a/lib/src/analyzers/lint_analyzer/models/scoped_function_declaration.dart b/lib/src/analyzers/lint_analyzer/models/scoped_function_declaration.dart
@@ -1,11 +1,9 @@
 import 'package:analyzer/dart/ast/ast.dart';
-import 'package:meta/meta.dart';
 
 import 'function_type.dart';
 import 'scoped_class_declaration.dart';
 
 /// Represents a declaration of function / method.
-@immutable
 class ScopedFunctionDeclaration {
   /// The type of the declared function entity.
   final FunctionType type;
diff --git a/lib/src/analyzers/lint_analyzer/models/summary_lint_report_record.dart b/lib/src/analyzers/lint_analyzer/models/summary_lint_report_record.dart
@@ -1,9 +1,6 @@
-import 'package:meta/meta.dart';
-
 import 'summary_lint_report_record_status.dart';
 
 /// Represents a summary for a lint report.
-@immutable
 class SummaryLintReportRecord<T> {
   final SummaryLintReportRecordStatus status;
 
diff --git a/lib/src/analyzers/lint_analyzer/reporters/reporters_list/code_climate/models/code_climate_issue.dart b/lib/src/analyzers/lint_analyzer/reporters/reporters_list/code_climate/models/code_climate_issue.dart
@@ -1,11 +1,8 @@
-import 'package:meta/meta.dart';
-
 import 'code_climate_issue_category.dart';
 import 'code_climate_issue_location.dart';
 import 'code_climate_issue_severity.dart';
 
 /// Represents a Code Climate issue.
-@immutable
 class CodeClimateIssue {
   static const String type = 'issue';
 
diff --git a/lib/src/analyzers/lint_analyzer/reporters/reporters_list/code_climate/models/code_climate_issue_location.dart b/lib/src/analyzers/lint_analyzer/reporters/reporters_list/code_climate/models/code_climate_issue_location.dart
@@ -1,8 +1,6 @@
-import 'package:meta/meta.dart';
 import 'package:source_span/source_span.dart';
 
 /// Represents a Code Climate issue location.
-@immutable
 class CodeClimateIssueLocation {
   final String path;
   final SourceSpan location;
diff --git a/lib/src/analyzers/lint_analyzer/reporters/reporters_list/html/models/file_metrics_report.dart b/lib/src/analyzers/lint_analyzer/reporters/reporters_list/html/models/file_metrics_report.dart
@@ -1,8 +1,5 @@
 // ignore_for_file: public_member_api_docs
 
-import 'package:meta/meta.dart';
-
-@immutable
 class FileMetricsReport {
   final int averageArgumentsCount;
   final int argumentsCountViolations;
diff --git a/lib/src/analyzers/lint_analyzer/reporters/reporters_list/html/models/function_metrics_report.dart b/lib/src/analyzers/lint_analyzer/reporters/reporters_list/html/models/function_metrics_report.dart
@@ -1,10 +1,7 @@
 // ignore_for_file: public_member_api_docs
 
-import 'package:meta/meta.dart';
-
 import '../../../../metrics/models/metric_value.dart';
 
-@immutable
 class FunctionMetricsReport {
   final MetricValue<int> cyclomaticComplexity;
   final MetricValue<int> sourceLinesOfCode;
diff --git a/lib/src/analyzers/lint_analyzer/reporters/reporters_list/html/models/report_table_record.dart b/lib/src/analyzers/lint_analyzer/reporters/reporters_list/html/models/report_table_record.dart
@@ -1,11 +1,8 @@
-import 'package:meta/meta.dart';
-
 import 'file_metrics_report.dart';
 
 /// A table record
 ///
 /// used by html reporter to represent file system entiry with accomulated metrics
-@immutable
 class ReportTableRecord {
   final String title;
   final String link;
diff --git a/lib/src/analyzers/lint_analyzer/reporters/reporters_list/json/lint_json_reporter.dart b/lib/src/analyzers/lint_analyzer/reporters/reporters_list/json/lint_json_reporter.dart
@@ -1,7 +1,6 @@
 import 'dart:convert';
 import 'dart:io';
 
-import 'package:meta/meta.dart';
 import 'package:source_span/source_span.dart';
 
 import '../../../../../reporters/models/json_reporter.dart';
@@ -16,7 +15,6 @@ import '../../../models/summary_lint_report_record.dart';
 /// Lint JSON reporter.
 ///
 /// Use it to create reports in JSON format.
-@immutable
 class LintJsonReporter extends JsonReporter<LintFileReport,
     SummaryLintReportRecord<Object>, void> {
   const LintJsonReporter(IOSink output) : super(output, 2);
diff --git a/lib/src/analyzers/lint_analyzer/rules/base_visitors/intl_base_visitor.dart b/lib/src/analyzers/lint_analyzer/rules/base_visitors/intl_base_visitor.dart
@@ -159,7 +159,6 @@ abstract class IntlBaseVisitor extends GeneralizingAstVisitor<void> {
   }
 }
 
-@immutable
 abstract class IntlBaseIssue {
   final AstNode node;
   final String? nameFailure;
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/component_annotation_arguments_ordering/component_annotation_arguments_ordering_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/component_annotation_arguments_ordering/component_annotation_arguments_ordering_rule.dart
@@ -4,7 +4,6 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:collection/collection.dart';
-import 'package:meta/meta.dart';
 
 import '../../../../../utils/node_utils.dart';
 import '../../../../../utils/string_extensions.dart';
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/component_annotation_arguments_ordering/visitor.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/component_annotation_arguments_ordering/visitor.dart
@@ -71,7 +71,6 @@ class _Visitor extends SimpleAstVisitor<List<_ArgumentInfo>> {
       node.name.name == 'Component' && node.atSign.type == TokenType.AT;
 }
 
-@immutable
 class _ArgumentGroup {
   final String name;
   final Iterable<String> arguments;
@@ -139,7 +138,6 @@ class _ArgumentGroup {
       _groupsOrder.firstWhereOrNull((group) => group.arguments.contains(name));
 }
 
-@immutable
 class _ArgumentInfo {
   final NamedExpression argument;
   final _ArgumentOrder argumentOrder;
@@ -150,7 +148,6 @@ class _ArgumentInfo {
   });
 }
 
-@immutable
 class _ArgumentOrder {
   final bool isWrong;
   final _ArgumentGroup argumentGroup;
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering/member_ordering_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering/member_ordering_rule.dart
@@ -3,7 +3,6 @@
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:collection/collection.dart';
-import 'package:meta/meta.dart';
 
 import '../../../../../utils/node_utils.dart';
 import '../../../../../utils/string_extensions.dart';
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering/visitor.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering/visitor.dart
@@ -149,7 +149,6 @@ class _Visitor extends RecursiveAstVisitor<List<_MemberInfo>> {
       _groupsOrder.indexOf(lastMemberGroup) > _groupsOrder.indexOf(memberGroup);
 }
 
-@immutable
 class _MembersGroup {
   final String name;
 
@@ -197,7 +196,6 @@ class _MembersGroup {
       _groupsOrder.firstWhereOrNull((group) => group.name == name);
 }
 
-@immutable
 class _Annotation {
   final String name;
   final _MembersGroup group;
@@ -234,7 +232,6 @@ class _Annotation {
       _annotations.firstWhereOrNull((annotation) => annotation.name == name);
 }
 
-@immutable
 class _MemberInfo {
   final ClassMember classMember;
   final _MemberOrder memberOrder;
@@ -245,7 +242,6 @@ class _MemberInfo {
   });
 }
 
-@immutable
 class _MemberOrder {
   final bool isWrong;
   final bool isAlphabeticallyWrong;
@@ -262,7 +258,6 @@ class _MemberOrder {
   });
 }
 
-@immutable
 class _MemberNames {
   final String currentName;
   final String? previousName;
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering_extended/member_ordering_extended_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering_extended/member_ordering_extended_rule.dart
@@ -4,7 +4,6 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/nullability_suffix.dart';
 import 'package:collection/collection.dart';
-import 'package:meta/meta.dart';
 
 import '../../../../../utils/node_utils.dart';
 import '../../../lint_utils.dart';
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering_extended/models/annotation.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering_extended/models/annotation.dart
@@ -1,6 +1,5 @@
 part of '../member_ordering_extended_rule.dart';
 
-@immutable
 class _Annotation {
   final String name;
   final String? publicName;
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering_extended/models/field_keyword.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering_extended/models/field_keyword.dart
@@ -1,6 +1,5 @@
 part of '../member_ordering_extended_rule.dart';
 
-@immutable
 class _FieldKeyword {
   final String type;
 
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering_extended/models/member_type.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering_extended/models/member_type.dart
@@ -1,6 +1,5 @@
 part of '../member_ordering_extended_rule.dart';
 
-@immutable
 class _MemberType {
   final String type;
 
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering_extended/models/modifier.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering_extended/models/modifier.dart
@@ -1,6 +1,5 @@
 part of '../member_ordering_extended_rule.dart';
 
-@immutable
 class _Modifier {
   final String type;
 
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering_extended/visitor.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/member_ordering_extended/visitor.dart
@@ -213,7 +213,6 @@ class _Visitor extends RecursiveAstVisitor<List<_MemberInfo>> {
           group.annotation == parsedGroup.annotation);
 }
 
-@immutable
 class _MemberInfo {
   final ClassMember classMember;
   final _MemberOrder memberOrder;
@@ -224,7 +223,6 @@ class _MemberInfo {
   });
 }
 
-@immutable
 class _MemberOrder {
   final bool isWrong;
   final bool isAlphabeticallyWrong;
@@ -243,7 +241,6 @@ class _MemberOrder {
   });
 }
 
-@immutable
 class _MemberNames {
   final String currentName;
   final String? previousName;
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_conditional_expressions/prefer_conditional_expressions_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_conditional_expressions/prefer_conditional_expressions_rule.dart
@@ -3,7 +3,6 @@
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:meta/meta.dart';
 
 import '../../../../../utils/node_utils.dart';
 import '../../../lint_utils.dart';
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_conditional_expressions/visitor.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_conditional_expressions/visitor.dart
@@ -80,7 +80,6 @@ class _Visitor extends RecursiveAstVisitor<void> {
   }
 }
 
-@immutable
 class _StatementInfo {
   final IfStatement statement;
   final AstNode unwrappedThenStatement;
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_intl_name/prefer_intl_name_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_intl_name/prefer_intl_name_rule.dart
@@ -2,7 +2,6 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:collection/collection.dart';
-import 'package:meta/meta.dart';
 
 import '../../../../../utils/node_utils.dart';
 import '../../../../../utils/object_extensions.dart';
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_intl_name/visitor.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_intl_name/visitor.dart
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/provide_correct_intl_args/provide_correct_intl_args_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/provide_correct_intl_args/provide_correct_intl_args_rule.dart
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/provide_correct_intl_args/visitor.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/provide_correct_intl_args/visitor.dart
diff --git a/lib/src/analyzers/unused_files_analyzer/reporters/reporters_list/json/unused_files_json_reporter.dart b/lib/src/analyzers/unused_files_analyzer/reporters/reporters_list/json/unused_files_json_reporter.dart
diff --git a/lib/src/analyzers/unused_files_analyzer/unused_files_config.dart b/lib/src/analyzers/unused_files_analyzer/unused_files_config.dart
diff --git a/lib/src/analyzers/unused_l10n_analyzer/models/unused_l10n_issue.dart b/lib/src/analyzers/unused_l10n_analyzer/models/unused_l10n_issue.dart
diff --git a/lib/src/analyzers/unused_l10n_analyzer/reporters/reporters_list/json/unused_l10n_json_reporter.dart b/lib/src/analyzers/unused_l10n_analyzer/reporters/reporters_list/json/unused_l10n_json_reporter.dart
diff --git a/lib/src/analyzers/unused_l10n_analyzer/unused_l10n_config.dart b/lib/src/analyzers/unused_l10n_analyzer/unused_l10n_config.dart
diff --git a/lib/src/cli/exceptions/invalid_argument_exception.dart b/lib/src/cli/exceptions/invalid_argument_exception.dart
diff --git a/lib/src/cli/models/parsed_arguments.dart b/lib/src/cli/models/parsed_arguments.dart
diff --git a/lib/src/config_builder/models/analysis_options.dart b/lib/src/config_builder/models/analysis_options.dart
diff --git a/lib/src/config_builder/models/deprecated_option.dart b/lib/src/config_builder/models/deprecated_option.dart
diff --git a/lib/src/reporters/models/file_report.dart b/lib/src/reporters/models/file_report.dart
