chore: change unnecessary nullable parameters (#875)

* feat: introduce new command check-unnecessary-nullable

* chore: update changelog

* fix: add support for property access

* fix: add support for index expressions

* fix: add support for all expressions as arguments

* fix: add null literal check

* chore: remove unnecessary nullable parameters

Author: incendial

CHANGELOG.md

@@ -12,6 +12,7 @@
 * fix: correctly handle `-` symbol for [`prefer-commenting-analyzer-ignores`](https://dartcodemetrics.dev/docs/rules/common/prefer-commenting-analyzer-ignores).
 * fix: change elements equality check to overcome incorrect libs resolution.
 * chore: restrict `analyzer` version to `>=2.4.0 <4.2.0`.
+* chore: clean up unnecessary nullable parameters.
 * test: added test case in [`prefer-const-border-radius`](https://dartcodemetrics.dev/docs/rules/flutter/prefer-const-border-radius) rule.
 
 ## 4.15.2

lib/src/analyzers/lint_analyzer/metrics/scope_utils.dart

@@ -4,7 +4,7 @@ import '../models/scoped_function_declaration.dart';
 
 /// Returns functions belonging to the passed [classNode]
 Iterable<ScopedFunctionDeclaration> classMethods(
-  AstNode? classNode,
+  AstNode classNode,
   Iterable<ScopedFunctionDeclaration> functionDeclarations,
 ) =>
     functionDeclarations

lib/src/analyzers/lint_analyzer/models/suppression.dart

@@ -14,7 +14,7 @@ class Suppression {
   bool isSuppressed(String id) => _ignoreForFileSet.contains(_canonicalize(id));
 
   /// Checks that the [id] is suppressed for the [lineIndex].
-  bool isSuppressedAt(String id, int? lineIndex) =>
+  bool isSuppressedAt(String id, int lineIndex) =>
       isSuppressed(id) ||
       (_ignoreMap[lineIndex]?.contains(_canonicalize(id)) ?? false);
 

lib/src/analyzers/lint_analyzer/rules/base_visitors/intl_base_visitor.dart

@@ -20,17 +20,13 @@ abstract class IntlBaseVisitor extends GeneralizingAstVisitor<void> {
   Iterable<IntlBaseIssue> get issues => _issues;
 
   @protected
-  void addIssue(IntlBaseIssue? issue) {
-    if (issue != null) {
-      _issues.add(issue);
-    }
+  void addIssue(IntlBaseIssue issue) {
+    _issues.add(issue);
   }
 
   @protected
-  void addIssues(Iterable<IntlBaseIssue>? issues) {
-    if (issues != null) {
-      _issues.addAll(issues);
-    }
+  void addIssues(Iterable<IntlBaseIssue> issues) {
+    _issues.addAll(issues);
   }
 
   @override
@@ -98,8 +94,8 @@ abstract class IntlBaseVisitor extends GeneralizingAstVisitor<void> {
   @protected
   void checkMethodInvocation(
     MethodInvocation methodInvocation, {
+    required String variableName,
     String? className,
-    String? variableName,
     FormalParameterList? parameterList,
   });
 
@@ -141,8 +137,8 @@ abstract class IntlBaseVisitor extends GeneralizingAstVisitor<void> {
 
   void _checkMethodInvocation(
     MethodInvocation methodInvocation, {
+    required String variableName,
     String? className,
-    String? variableName,
     FormalParameterList? parameterList,
   }) {
     if ((methodInvocation.target?.as<SimpleIdentifier>()?.name != 'Intl') ||

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_non_null_assertion/visitor.dart

@@ -27,6 +27,5 @@ class _Visitor extends RecursiveAstVisitor<void> {
     return false;
   }
 
-  bool _isMapOrSubclassOfMap(DartType? type) =>
-      type != null && type.isDartCoreMap;
+  bool _isMapOrSubclassOfMap(DartType type) => type.isDartCoreMap;
 }

lib/src/reporters/github_workflow_commands.dart

@@ -36,27 +36,27 @@ class GitHubWorkflowCommands {
       );
 
   String _construct(
-    String command, [
-    String? message,
-    Map<String, Object>? parameters,
-  ]) {
+    String command,
+    String message,
+    Map<String, Object> parameters,
+  ) {
     final buffer = StringBuffer('::$command');
     final params =
-        parameters?.entries.map((e) => '${e.key}=${e.value}').join(',').trim();
-    if (params != null && params.isNotEmpty) {
+        parameters.entries.map((e) => '${e.key}=${e.value}').join(',').trim();
+    if (params.isNotEmpty) {
       buffer.write(' $params');
     }
-    buffer.write('::');
-    if (message != null) {
-      buffer.write(message);
-    }
+
+    buffer
+      ..write('::')
+      ..write(message);
 
     return buffer.toString();
   }
 
-  Map<String, Object> _params(String? file, int? line, int? column) => {
-        if (file != null) 'file': file,
-        if (line != null) 'line': line,
-        if (column != null) 'col': column,
+  Map<String, Object> _params(String file, int line, int column) => {
+        'file': file,
+        'line': line,
+        'col': column,
       };
 }

lib/src/utils/exclude_utils.dart

@@ -1,10 +1,10 @@
 import 'package:glob/glob.dart';
 import 'package:path/path.dart' as p;
 
-bool isExcluded(String? absolutePath, Iterable<Glob> excludes) {
-  final path = absolutePath?.replaceAll(r'\', '/');
+bool isExcluded(String absolutePath, Iterable<Glob> excludes) {
+  final path = absolutePath.replaceAll(r'\', '/');
 
-  return path != null && excludes.any((exclude) => exclude.matches(path));
+  return excludes.any((exclude) => exclude.matches(path));
 }
 
 Iterable<Glob> prepareExcludes(

test/src/analyzers/lint_analyzer/models/suppression_test.dart

@@ -19,9 +19,6 @@ void main() {
     expect(suppression.isSuppressed('rule_id3'), isTrue);
     expect(suppression.isSuppressed('rule_id4'), isFalse);
 
-    expect(suppression.isSuppressedAt('rule_id1', null), isTrue);
-    expect(suppression.isSuppressedAt('rule_id2', null), isTrue);
-    expect(suppression.isSuppressedAt('rule_id3', null), isTrue);
     expect(suppression.isSuppressedAt('rule_id4', 5), isTrue);
     expect(suppression.isSuppressedAt('rule_id5', 5), isTrue);
     expect(suppression.isSuppressedAt('rule_id6', 9), isTrue);

test/src/analyzers/utils/scope_utils_test.dart

@@ -50,7 +50,6 @@ void main() {
       ),
     ];
 
-    expect(classMethods(null, functions), hasLength(1));
     expect(classMethods(firstClass.declaration, functions), hasLength(2));
     expect(classMethods(secondClass.declaration, functions), hasLength(2));
     expect(classMethods(thirdClass.declaration, functions), isEmpty);