fix: unhandled exception while parsing analysis_options.yaml (#473)

* fix: unhandled exception while parsing `analysis_options.yaml`

* chore: sync with stable branch

Author: dkrutskikh

CHANGELOG.md

@@ -2,9 +2,17 @@
 
 ## Unreleased
 
-* Don't trigger prefer-extracting-callbacks on empty function blocks.
+* Improve static code diagnostic `prefer-extracting-callbacks`, don't trigger on empty function blocks.
 * Improve unused files check, add support for `vm:entry-point` annotation.
 
+## 4.3.3
+
+* Fix unhandled exception while parsing `analysis_options.yaml`
+
+## 4.3.2
+
+* Restrict analyzer version to '>=2.1.0 <2.4.0'
+
 ## 4.3.1
 
 * Update .pubignore

CONTRIBUTING.md

@@ -89,7 +89,7 @@ To set this up:
     ```yaml
     name: dart_code_metrics_plugin_loader
     description: This pubspec determines the version of the analyzer plugin to load.
-    version: 4.3.1
+    version: 4.3.3
 
     environment:
       sdk: '>=2.12.0 <3.0.0'

README.md

@@ -56,7 +56,7 @@ A plugin for the Dart `analyzer` [package](https://pub.dev/packages/analyzer) pr
 
     ```yaml
     dev_dependencies:
-      dart_code_metrics: ^4.3.1
+      dart_code_metrics: ^4.3.3
     ```
 
     and then run

lib/src/analyzers/lint_analyzer/anti_patterns/anti_patterns_list/long_method.dart

@@ -53,28 +53,29 @@ class LongMethod extends Pattern {
       functionMetrics.entries
           .where((entry) => !_isExcluded(entry.key))
           .expand((entry) => [
-                ...entry.value.metrics
-                    .where((metricValue) =>
-                        metricValue.metricsId ==
-                            SourceLinesOfCodeMetric.metricId &&
-                        metricValue.level >= MetricValueLevel.warning)
-                    .map(
-                      (metricValue) => createIssue(
-                        pattern: this,
-                        location: nodeLocation(
-                          node: entry.key.declaration,
-                          source: source,
-                        ),
-                        message: _compileMessage(
-                          lines: metricValue.value,
-                          functionType: entry.key.type,
-                        ),
-                        verboseMessage: _compileRecommendationMessage(
-                          maximumLines: _sourceLinesOfCodeMetricTreshold,
-                          functionType: entry.key.type,
+                if (_sourceLinesOfCodeMetricTreshold != null)
+                  ...entry.value.metrics
+                      .where((metricValue) =>
+                          metricValue.metricsId ==
+                              SourceLinesOfCodeMetric.metricId &&
+                          metricValue.value > _sourceLinesOfCodeMetricTreshold!)
+                      .map(
+                        (metricValue) => createIssue(
+                          pattern: this,
+                          location: nodeLocation(
+                            node: entry.key.declaration,
+                            source: source,
+                          ),
+                          message: _compileMessage(
+                            lines: metricValue.value,
+                            functionType: entry.key.type,
+                          ),
+                          verboseMessage: _compileRecommendationMessage(
+                            maximumLines: _sourceLinesOfCodeMetricTreshold,
+                            functionType: entry.key.type,
+                          ),
                         ),
                       ),
-                    ),
                 if (_sourceLinesOfCodeMetricTreshold == null)
                   // ignore: deprecated_member_use_from_same_package
                   ..._legacyBehaviour(source, entry),

lib/src/analyzers/lint_analyzer/anti_patterns/anti_patterns_list/long_parameter_list.dart

@@ -50,28 +50,30 @@ class LongParameterList extends Pattern {
   ) =>
       functionMetrics.entries
           .expand((entry) => [
-                ...entry.value.metrics
-                    .where((metricValue) =>
-                        metricValue.metricsId ==
-                            NumberOfParametersMetric.metricId &&
-                        metricValue.level >= MetricValueLevel.warning)
-                    .map(
-                      (metricValue) => createIssue(
-                        pattern: this,
-                        location: nodeLocation(
-                          node: entry.key.declaration,
-                          source: source,
-                        ),
-                        message: _compileMessage(
-                          args: metricValue.value,
-                          functionType: entry.key.type,
-                        ),
-                        verboseMessage: _compileRecommendationMessage(
-                          maximumArguments: _numberOfParametersMetricTreshold,
-                          functionType: entry.key.type,
+                if (_numberOfParametersMetricTreshold != null)
+                  ...entry.value.metrics
+                      .where((metricValue) =>
+                          metricValue.metricsId ==
+                              NumberOfParametersMetric.metricId &&
+                          metricValue.value >
+                              _numberOfParametersMetricTreshold!)
+                      .map(
+                        (metricValue) => createIssue(
+                          pattern: this,
+                          location: nodeLocation(
+                            node: entry.key.declaration,
+                            source: source,
+                          ),
+                          message: _compileMessage(
+                            args: metricValue.value,
+                            functionType: entry.key.type,
+                          ),
+                          verboseMessage: _compileRecommendationMessage(
+                            maximumArguments: _numberOfParametersMetricTreshold,
+                            functionType: entry.key.type,
+                          ),
                         ),
                       ),
-                    ),
                 if (_numberOfParametersMetricTreshold == null)
                   // ignore: deprecated_member_use_from_same_package
                   ..._legacyBehaviour(source, entry),

lib/src/utils/yaml_utils.dart

@@ -8,7 +8,7 @@ List<Object> yamlListToDartList(YamlList list) =>
 Map<String, Object> yamlMapToDartMap(YamlMap map) =>
     Map.unmodifiable(Map<String, Object>.fromEntries(map.nodes.keys
         .whereType<YamlScalar>()
-        .where((key) => key.value is String)
+        .where((key) => key.value is String && map.nodes[key]?.value != null)
         .map((key) => MapEntry(
               key.value as String,
               yamlNodeToDartObject(map.nodes[key]),

pubspec.yaml

@@ -1,5 +1,5 @@
 name: dart_code_metrics
-version: 4.3.1
+version: 4.3.3
 description: Software analytics tool that helps developers analyse and improve software quality.
 homepage: https://dartcodemetrics.dev
 repository: https://github.com/dart-code-checker/dart-code-metrics

test/resources/analysis_options_repo.yaml

@@ -1,5 +1,9 @@
 include: ./analysis_options_common.yaml
 
+linter:
+  # rules:
+    # avoid_print: true
+
 analyzer:
   plugins:
     - code_checker

tools/analyzer_plugin/pubspec.yaml

@@ -1,9 +1,9 @@
 name: dart_code_metrics_plugin_loader
 description: This pubspec determines the version of the analyzer plugin to load.
-version: 4.3.1
+version: 4.3.3
 
 environment:
   sdk: ">=2.12.0 <3.0.0"
 
 dependencies:
-  dart_code_metrics: ^4.3.1
+  dart_code_metrics: ^4.3.3