refactor: remove useless calculate node location with with comment or… (#769)

dkrutskikh · web-flow · commit 76705e598f92 · 2022-03-26T22:44:34.000+03:00
* refactor: remove useless calculate node location with with comment or metadata
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## Unreleased
 
-* fix: support index expressions for no-magic-number rule.
+* fix: support index expressions for [`no-magic-number`](https://dartcodemetrics.dev/docs/rules/common/no-magic-number) rule.
 
 ## 4.13.0
 
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_border_all/avoid_border_all_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_border_all/avoid_border_all_rule.dart
@@ -36,11 +36,7 @@ class AvoidBorderAllRule extends FlutterRule {
     return visitor.expressions
         .map((expression) => createIssue(
               rule: this,
-              location: nodeLocation(
-                node: expression,
-                source: source,
-                withCommentOrMetadata: true,
-              ),
+              location: nodeLocation(node: expression, source: source),
               message: _issueMessage,
               replacement: _createReplacement(expression),
             ))
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_preserve_whitespace_false/avoid_preserve_whitespace_false_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_preserve_whitespace_false/avoid_preserve_whitespace_false_rule.dart
@@ -36,11 +36,7 @@ class AvoidPreserveWhitespaceFalseRule extends AngularRule {
     return visitor.expression
         .map((expression) => createIssue(
               rule: this,
-              location: nodeLocation(
-                node: expression,
-                source: source,
-                withCommentOrMetadata: true,
-              ),
+              location: nodeLocation(node: expression, source: source),
               message: _warning,
             ))
         .toList(growable: false);
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unused_parameters/avoid_unused_parameters_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unused_parameters/avoid_unused_parameters_rule.dart
@@ -39,11 +39,7 @@ class AvoidUnusedParametersRule extends CommonRule {
     return visitor.unusedParameters
         .map((parameter) => createIssue(
               rule: this,
-              location: nodeLocation(
-                node: parameter,
-                source: source,
-                withCommentOrMetadata: true,
-              ),
+              location: nodeLocation(node: parameter, source: source),
               message: _warningMessage,
             ))
         .toList(growable: false);
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/binary_expression_operand_order/binary_expression_operand_order_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/binary_expression_operand_order/binary_expression_operand_order_rule.dart
@@ -38,11 +38,7 @@ class BinaryExpressionOperandOrderRule extends CommonRule {
     return visitor.binaryExpressions
         .map((lit) => createIssue(
               rule: this,
-              location: nodeLocation(
-                node: lit,
-                source: source,
-                withCommentOrMetadata: true,
-              ),
+              location: nodeLocation(node: lit, source: source),
               message: _warningMessage,
               replacement: Replacement(
                 comment: _correctionComment,
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/component_annotation_arguments_ordering/component_annotation_arguments_ordering_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/component_annotation_arguments_ordering/component_annotation_arguments_ordering_rule.dart
@@ -45,11 +45,7 @@ class ComponentAnnotationArgumentsOrderingRule extends AngularRule {
     return argumentsInfo.where((info) => info.argumentOrder.isWrong).map(
           (info) => createIssue(
             rule: this,
-            location: nodeLocation(
-              node: info.argument,
-              source: source,
-              withCommentOrMetadata: true,
-            ),
+            location: nodeLocation(node: info.argument, source: source),
             message:
                 'Arguments group ${info.argumentOrder.argumentGroup.name} $_warningMessage ${info.argumentOrder.previousArgumentGroup?.name}.',
           ),
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/no_boolean_literal_compare/no_boolean_literal_compare_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/no_boolean_literal_compare/no_boolean_literal_compare_rule.dart
@@ -66,11 +66,7 @@ class NoBooleanLiteralCompareRule extends CommonRule {
 
       issues.add(createIssue(
         rule: this,
-        location: nodeLocation(
-          node: expression,
-          source: source,
-          withCommentOrMetadata: true,
-        ),
+        location: nodeLocation(node: expression, source: source),
         message: _warning,
         replacement: Replacement(
           comment: useDirect ? _useItDirectly : _negate,
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/no_empty_block/no_empty_block_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/no_empty_block/no_empty_block_rule.dart
@@ -37,11 +37,7 @@ class NoEmptyBlockRule extends CommonRule {
     return visitor.emptyBlocks
         .map((block) => createIssue(
               rule: this,
-              location: nodeLocation(
-                node: block,
-                source: source,
-                withCommentOrMetadata: true,
-              ),
+              location: nodeLocation(node: block, source: source),
               message: _warning,
             ))
         .toList(growable: false);
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/no_equal_arguments/no_equal_arguments_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/no_equal_arguments/no_equal_arguments_rule.dart
@@ -38,11 +38,7 @@ class NoEqualArgumentsRule extends CommonRule {
     return visitor.arguments
         .map((argument) => createIssue(
               rule: this,
-              location: nodeLocation(
-                node: argument,
-                source: source,
-                withCommentOrMetadata: true,
-              ),
+              location: nodeLocation(node: argument, source: source),
               message: _warningMessage,
             ))
         .toList(growable: false);
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/no_equal_then_else/no_equal_then_else_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/no_equal_then_else/no_equal_then_else_rule.dart
@@ -37,11 +37,7 @@ class NoEqualThenElseRule extends CommonRule {
         .map(
           (node) => createIssue(
             rule: this,
-            location: nodeLocation(
-              node: node,
-              source: source,
-              withCommentOrMetadata: true,
-            ),
+            location: nodeLocation(node: node, source: source),
             message: _warningMessage,
           ),
         )
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/no_magic_number/no_magic_number_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/no_magic_number/no_magic_number_rule.dart
@@ -46,11 +46,7 @@ class NoMagicNumberRule extends CommonRule {
         .where(_isNotInsideIndexExpression)
         .map((lit) => createIssue(
               rule: this,
-              location: nodeLocation(
-                node: lit,
-                source: source,
-                withCommentOrMetadata: true,
-              ),
+              location: nodeLocation(node: lit, source: source),
               message: _warningMessage,
             ))
         .toList(growable: false);
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/no_object_declaration/no_object_declaration_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/no_object_declaration/no_object_declaration_rule.dart
@@ -36,11 +36,7 @@ class NoObjectDeclarationRule extends CommonRule {
         .map(
           (member) => createIssue(
             rule: this,
-            location: nodeLocation(
-              node: member,
-              source: source,
-              withCommentOrMetadata: true,
-            ),
+            location: nodeLocation(node: member, source: source),
             message: _warningMessage,
           ),
         )
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_conditional_expressions/prefer_conditional_expressions_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_conditional_expressions/prefer_conditional_expressions_rule.dart
@@ -40,11 +40,7 @@ class PreferConditionalExpressionsRule extends CommonRule {
         .map(
           (info) => createIssue(
             rule: this,
-            location: nodeLocation(
-              node: info.statement,
-              source: source,
-              withCommentOrMetadata: true,
-            ),
+            location: nodeLocation(node: info.statement, source: source),
             message: _warningMessage,
             replacement: _createReplacement(info),
           ),
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_const_border_radius/prefer_const_border_radius_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_const_border_radius/prefer_const_border_radius_rule.dart
@@ -36,11 +36,7 @@ class PreferConstBorderRadiusRule extends FlutterRule {
     return visitor.expressions
         .map((expression) => createIssue(
               rule: this,
-              location: nodeLocation(
-                node: expression,
-                source: source,
-                withCommentOrMetadata: true,
-              ),
+              location: nodeLocation(node: expression, source: source),
               message: _issueMessage,
               replacement: _createReplacement(expression),
             ))
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_first/prefer_first_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_first/prefer_first_rule.dart
@@ -36,11 +36,7 @@ class PreferFirstRule extends CommonRule {
     return visitor.expressions
         .map((expression) => createIssue(
               rule: this,
-              location: nodeLocation(
-                node: expression,
-                source: source,
-                withCommentOrMetadata: true,
-              ),
+              location: nodeLocation(node: expression, source: source),
               message: _warningMessage,
               replacement: _createReplacement(expression),
             ))
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_immediate_return/prefer_immediate_return_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_immediate_return/prefer_immediate_return_rule.dart
@@ -36,11 +36,7 @@ class PreferImmediateReturnRule extends CommonRule {
         .map(
           (issue) => createIssue(
             rule: this,
-            location: nodeLocation(
-              node: issue.returnStatement,
-              source: source,
-              withCommentOrMetadata: true,
-            ),
+            location: nodeLocation(node: issue.returnStatement, source: source),
             message: _warningMessage,
             replacement: Replacement(
               comment: _replaceComment,
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_intl_name/prefer_intl_name_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_intl_name/prefer_intl_name_rule.dart
@@ -51,11 +51,7 @@ class PreferIntlNameRule extends IntlRule {
 
         return createIssue(
           rule: this,
-          location: nodeLocation(
-            node: issue.node,
-            source: source,
-            withCommentOrMetadata: true,
-          ),
+          location: nodeLocation(node: issue.node, source: source),
           message: '$_notCorrectNameFailure $correction.',
           replacement: Replacement(
             comment: _notCorrectNameCorrectionComment,
@@ -67,11 +63,7 @@ class PreferIntlNameRule extends IntlRule {
           .whereType<_NotExistNameIssue>()
           .map((issue) => createIssue(
                 rule: this,
-                location: nodeLocation(
-                  node: issue.node,
-                  source: source,
-                  withCommentOrMetadata: true,
-                ),
+                location: nodeLocation(node: issue.node, source: source),
                 message: _notExistsNameFailure,
               )),
     ];
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_last/prefer_last_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_last/prefer_last_rule.dart
@@ -38,11 +38,7 @@ class PreferLastRule extends CommonRule {
     return visitor.expressions
         .map((expression) => createIssue(
               rule: this,
-              location: nodeLocation(
-                node: expression,
-                source: source,
-                withCommentOrMetadata: true,
-              ),
+              location: nodeLocation(node: expression, source: source),
               message: _warningMessage,
               replacement: _createReplacement(expression),
             ))
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_on_push_cd_strategy/prefer_on_push_cd_strategy_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_on_push_cd_strategy/prefer_on_push_cd_strategy_rule.dart
@@ -36,11 +36,7 @@ class PreferOnPushCdStrategyRule extends AngularRule {
     return visitor.expression
         .map((expression) => createIssue(
               rule: this,
-              location: nodeLocation(
-                node: expression,
-                source: source,
-                withCommentOrMetadata: true,
-              ),
+              location: nodeLocation(node: expression, source: source),
               message: _failure,
             ))
         .toList(growable: false);
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_trailing_comma/prefer_trailing_comma_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_trailing_comma/prefer_trailing_comma_rule.dart
@@ -44,11 +44,7 @@ class PreferTrailingCommaRule extends CommonRule {
         .map(
           (node) => createIssue(
             rule: this,
-            location: nodeLocation(
-              node: node,
-              source: source,
-              withCommentOrMetadata: true,
-            ),
+            location: nodeLocation(node: node, source: source),
             message: _warningMessage,
             replacement: Replacement(
               comment: _correctionMessage,
diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_list/provide_correct_intl_args/provide_correct_intl_args_rule.dart b/lib/src/analyzers/lint_analyzer/rules/rules_list/provide_correct_intl_args/provide_correct_intl_args_rule.dart
@@ -43,11 +43,7 @@ class ProvideCorrectIntlArgsRule extends IntlRule {
     return visitor.issues
         .map((issue) => createIssue(
               rule: this,
-              location: nodeLocation(
-                node: issue.node,
-                source: source,
-                withCommentOrMetadata: true,
-              ),
+              location: nodeLocation(node: issue.node, source: source),
               message: issue.nameFailure!,
             ))
         .toList();
diff --git a/test/src/analyzers/lint_analyzer/rules/rules_factory_test.dart b/test/src/analyzers/lint_analyzer/rules/rules_factory_test.dart
@@ -43,9 +43,15 @@ void main() {
         'avoid-throw-in-catch-block': <String, Object>{},
         'prefer-correct-type-name': <String, Object>{},
         'avoid-unrelated-type-assertions': <String, Object>{},
+        'avoid-border-all': <String, Object>{},
+        'ban-name': <String, Object>{},
+        'format-comment': <String, Object>{},
+        'prefer-immediate-return': <String, Object>{},
+        'tag-name': <String, Object>{},
       }).map((rule) => rule.id),
       equals([
         'always-remove-listener',
+        'avoid-border-all',
         'avoid-ignoring-return-values',
         'avoid-late-keyword',
         'avoid-missing-enum-constant-in-map',
@@ -58,9 +64,11 @@ void main() {
         'avoid-unrelated-type-assertions',
         'avoid-unused-parameters',
         'avoid-wrapping-in-padding',
+        'ban-name',
         'binary-expression-operand-order',
         'component-annotation-arguments-ordering',
         'double-literal-format',
+        'format-comment',
         'member-ordering',
         'member-ordering-extended',
         'newline-before-return',
@@ -75,12 +83,14 @@ void main() {
         'prefer-correct-identifier-length',
         'prefer-correct-type-name',
         'prefer-extracting-callbacks',
+        'prefer-immediate-return',
         'prefer-intl-name',
         'prefer-match-file-name',
         'prefer-on-push-cd-strategy',
         'prefer-single-widget-per-file',
         'prefer-trailing-comma',
         'provide-correct-intl-args',
+        'tag-name',
       ]),
     );
   });
