Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Commit 714ca26

Browse files
authored
chore: bump analyzer (#714)
* chore: restrict analyzer version to >=2.8.0 <3.4.0 * chore: add missed trailing comma * chore: tune lints settings * fix: update link in documentation * fix
1 parent 96b976f commit 714ca26

File tree

9 files changed

+15
-13
lines changed

9 files changed

+15
-13
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
## Unreleased
44

55
* **Breaking Change:** cli arguments `--fatal-unused` and `--fatal-warnings` activate by default.
6-
* chore: restrict `analyzer` version to `>=2.8.0 <3.3.0`.
6+
* chore: restrict `analyzer` version to `>=3.3.0 <3.4.0`.
7+
* chore: restrict `analyzer_plugin` version to `>=0.9.0 <0.10.0`.
78
* feat: add static code diagnostic `avoid-collection-methods-with-unrelated-types`
89

910
## 4.11.0

analysis_options.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@ dart_code_metrics:
7070
exceptions:
7171
- id
7272
- ok
73-
- prefer-correct-type-name
73+
- prefer-correct-type-name:
74+
max-length: 44
7475
- prefer-first
7576
- prefer-last
7677
- prefer-match-file-name:

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_collection_methods_with_unrelated_types/avoid_collection_methods_with_unrelated_types_rule.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ class AvoidCollectionMethodsWithUnrelatedTypesRule extends CommonRule {
2222

2323
static const _warning = 'Avoid collection methods with unrelated types.';
2424

25-
AvoidCollectionMethodsWithUnrelatedTypesRule(
26-
[Map<String, Object> config = const {}])
27-
: super(
25+
AvoidCollectionMethodsWithUnrelatedTypesRule([
26+
Map<String, Object> config = const {},
27+
]) : super(
2828
id: ruleId,
2929
severity: readSeverity(config, Severity.warning),
3030
excludes: readExcludes(config),

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_returning_widgets/visitor.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class _Visitor extends RecursiveAstVisitor<void> {
3636

3737
@override
3838
void visitClassDeclaration(ClassDeclaration node) {
39-
final classType = node.extendsClause?.superclass2.type;
39+
final classType = node.extendsClause?.superclass.type;
4040
if (!isWidgetOrSubclass(classType) && !isWidgetStateOrSubclass(classType)) {
4141
return;
4242
}

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_setstate/visitor.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class _Visitor extends RecursiveAstVisitor<void> {
1414
void visitClassDeclaration(ClassDeclaration node) {
1515
super.visitClassDeclaration(node);
1616

17-
final type = node.extendsClause?.superclass2.type;
17+
final type = node.extendsClause?.superclass.type;
1818
if (type == null || !isWidgetStateOrSubclass(type)) {
1919
return;
2020
}

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_extracting_callbacks/visitor.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class _Visitor extends SimpleAstVisitor<void> {
1111

1212
@override
1313
void visitClassDeclaration(ClassDeclaration node) {
14-
final classType = node.extendsClause?.superclass2.type;
14+
final classType = node.extendsClause?.superclass.type;
1515
if (!isWidgetOrSubclass(classType) && !isWidgetStateOrSubclass(classType)) {
1616
return;
1717
}

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_single_widget_per_file/visitor.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class _Visitor extends SimpleAstVisitor<void> {
1515
void visitClassDeclaration(ClassDeclaration node) {
1616
super.visitClassDeclaration(node);
1717

18-
final classType = node.extendsClause?.superclass2.type;
18+
final classType = node.extendsClause?.superclass.type;
1919
if (isWidgetOrSubclass(classType) &&
2020
(!_ignorePrivateWidgets || !Identifier.isPrivateName(node.name.name))) {
2121
_nodes.add(node);

pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ environment:
1010
sdk: ">=2.14.0 <3.0.0"
1111

1212
dependencies:
13-
analyzer: ">=2.8.0 <3.3.0"
14-
analyzer_plugin: ">=0.8.0 <0.10.0"
13+
analyzer: ">=3.3.0 <3.4.0"
14+
analyzer_plugin: ">=0.9.0 <0.10.0"
1515
ansicolor: ^2.0.1
1616
args: ^2.0.0
1717
collection: ^1.15.0

website/docs/cli/check-unused-files.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ The reporter prints a single JSON object containing meta information and the unu
5454

5555
- `formatVersion` - an integer representing the format version (will be incremented each time the serialization format changes)
5656
- `timestamp` - a creation time of the report in YYYY-MM-DD HH:MM:SS format
57-
- `unusedFiles` - an array of [unused files](#the-unusedFiles-object-fields-are)
57+
- `unusedFiles` - an array of [unused files](#the-unused-files-object-fields-are)
5858
- `automaticallyDeleted` - an indication of unused files being automatically deleted
5959

6060
```JSON
@@ -76,7 +76,7 @@ The reporter prints a single JSON object containing meta information and the unu
7676
}
7777
```
7878

79-
#### The **unusedFiles** object fields are {#the-unusedfiles-object-fields-are}
79+
#### The **unusedFiles** object fields are {#the-unused-files-object-fields-are}
8080

8181
- `path` - a relative path of the unused file
8282

0 commit comments

Comments
 (0)